supernova-ws / SuperNova

classes/debug.php

Spacing +39 added lines, -40 removed lines

@@ -25,7 +25,7 @@ 
  * que esperabas!!! soy newbie!!! D':<
 */
 
-if(!defined('INSIDE')) {
+if (!defined('INSIDE')) {
   die("attemp hacking");
 }
 
@@ -84,8 +84,8 @@ 
     $result = array();
     $transaction_id = SN::db_transaction_check(false) ? SN::$transaction_id : SN::$transaction_id++;
     $result[] = "tID {$transaction_id}";
-    foreach($backtrace as $a_trace) {
-      if(in_array($a_trace['function'], $exclude_functions)) {
+    foreach ($backtrace as $a_trace) {
+      if (in_array($a_trace['function'], $exclude_functions)) {
         continue;
       }
       $function =
@@ -102,7 +102,7 @@ 
       $line = !empty($a_trace['line']) ? $a_trace['line'] : '_UNDEFINED_';
       $result[] = "{$function} - '{$file}' Line {$line}";
 
-      if(!$long_comment) {
+      if (!$long_comment) {
         break;
       }
     }
@@ -111,26 +111,26 @@ 
   }
 
   function dump($dump = false, $force_base = false, $deadlock = false) {
-    if($dump === false) {
+    if ($dump === false) {
       return [];
     }
 
     $error_backtrace = array();
     $base_dump = false;
 
-    if($force_base === true) {
+    if ($force_base === true) {
       $base_dump = true;
     }
 
-    if($dump === true) {
+    if ($dump === true) {
       $base_dump = true;
     } else {
-      if(!is_array($dump)) {
+      if (!is_array($dump)) {
         $dump = array('var' => $dump);
       }
 
-      foreach($dump as $dump_var_name => $dump_var) {
-        if($dump_var_name == 'base_dump') {
+      foreach ($dump as $dump_var_name => $dump_var) {
+        if ($dump_var_name == 'base_dump') {
           $base_dump = $dump_var;
         } else {
           $error_backtrace[$dump_var_name] = $dump_var;
@@ -138,22 +138,21 @@ 
       }
     }
 
-    if($deadlock && ($q = SN::$db->mysql_get_innodb_status())) {
+    if ($deadlock && ($q = SN::$db->mysql_get_innodb_status())) {
       $error_backtrace['deadlock'] = explode("\n", $q['Status']);
-      foreach($error_backtrace['cSN_data'] as &$location) {
-        foreach($location as $location_id => &$location_data) //          $location_data = $location_id;
+      foreach ($error_backtrace['cSN_data'] as &$location) {
+        foreach ($location as $location_id => &$location_data) //          $location_data = $location_id;
         {
-          $location_data = isset($location_data['username']) ? $location_data['username'] :
-            (isset($location_data['name']) ? $location_data['name'] : $location_id);
+          $location_data = isset($location_data['username']) ? $location_data['username'] : (isset($location_data['name']) ? $location_data['name'] : $location_id);
         }
       }
     }
 
-    if($base_dump) {
-      if(!is_array($this->log_array) || empty($this->log_array)) {
+    if ($base_dump) {
+      if (!is_array($this->log_array) || empty($this->log_array)) {
         $this->log_array = [];
       } else {
-        foreach($this->log_array as $log) {
+        foreach ($this->log_array as $log) {
           $error_backtrace['queries'][] = $log;
         }
       }
@@ -165,17 +164,17 @@ 
       // Converting object instances to object names
 
       foreach ($error_backtrace['backtrace'] as &$backtrace) {
-        if(is_object($backtrace['object'])) {
+        if (is_object($backtrace['object'])) {
           $backtrace['object'] = get_class($backtrace['object']);
         }
 
-        if(empty($backtrace['args'])) {
+        if (empty($backtrace['args'])) {
           continue;
         }
 
         // Doing same conversion for backtrace params
-        foreach($backtrace['args'] as &$arg) {
-          if(is_object($arg)) {
+        foreach ($backtrace['args'] as &$arg) {
+          if (is_object($arg)) {
             $arg = 'object::' . get_class($arg);
           }
         }
@@ -204,14 +203,14 @@ 
   function error($message = 'There is a error on page', $title = 'Internal Error', $httpCode = 500, $dump = true) {
     global $config, $sys_stop_log_hit, $lang, $sys_log_disabled, $user;
 
-    if(empty(SN::$db->connected)) {
+    if (empty(SN::$db->connected)) {
       // TODO - писать ошибку в файл
       die('SQL server currently unavailable. Please contact Administration...');
     }
 
     SN::db_transaction_rollback();
 
-    if(SN::$config->debug == 1) {
+    if (SN::$config->debug == 1) {
       /** @noinspection HtmlDeprecatedTag */
       /** @noinspection XmlDeprecatedElement */
       /** @noinspection HtmlDeprecatedAttribute */
@@ -224,7 +223,7 @@ 
     $error_text = SN::$db->db_escape($message);
     $error_backtrace = $this->dump($dump, true, strpos($message, 'Deadlock') !== false);
 
-    if(!$sys_log_disabled) {
+    if (!$sys_log_disabled) {
       $this->_writeLogMessage($httpCode, $user, $title, $message, $error_backtrace, $fatal_error);
 
       $message = "Пожалуйста, свяжитесь с админом, если ошибка повторится. Ошибка №: <b>" . SN::$db->db_insert_id() . "</b>";
@@ -237,7 +236,7 @@ 
       ob_start();
       print("<hr>User ID {$user['id']} raised error code {$httpCode} titled '{$title}' with text '{$error_text}' on page {$_SERVER['SCRIPT_NAME']}");
 
-      foreach($error_backtrace as $name => $value) {
+      foreach ($error_backtrace as $name => $value) {
         print('<hr>');
         pdump($value, $name);
       }
@@ -249,7 +248,7 @@ 
   function warning($message, $title = 'System Message', $httpCode = 300, $dump = false) {
     global $user, $lang, $sys_log_disabled;
 
-    if(empty(SN::$db->connected)) {
+    if (empty(SN::$db->connected)) {
       // TODO - писать ошибку в файл
       die('SQL server currently unavailable. Please contact Administration...');
     }
@@ -258,7 +257,7 @@ 
 
     $error_backtrace = $this->dump($dump, false);
 
-    if(empty($sys_log_disabled)) {
+    if (empty($sys_log_disabled)) {
       $this->_writeLogMessage($httpCode, $user, $title, $message, $error_backtrace, $fatal_error);
     } else {
 //        // TODO Здесь надо писать в файло
@@ -295,11 +294,11 @@ 
 // Dump variables nicer then var_dump()
 
 function dump($value, $varname = null, $level = 0, $dumper = '') {
-  if(isset($varname)) {
+  if (isset($varname)) {
     $varname .= " = ";
   }
 
-  if($level == -1) {
+  if ($level == -1) {
     $trans[' '] = '&there4;';
     $trans["\t"] = '&rArr;';
     $trans["\n"] = '&para;;';
@@ -308,7 +307,7 @@ 
 
     return strtr(htmlspecialchars($value), $trans);
   }
-  if($level == 0) {
+  if ($level == 0) {
 //    $dumper = '<pre>' . mt_rand(10, 99) . '|' . $varname;
     $dumper = mt_rand(10, 99) . '|' . $varname;
   }
@@ -316,22 +315,22 @@ 
   $type = gettype($value);
   $dumper .= $type;
 
-  if($type == 'string') {
+  if ($type == 'string') {
     $dumper .= '(' . strlen($value) . ')';
     $value = dump($value, '', -1);
-  } elseif($type == 'boolean') {
+  } elseif ($type == 'boolean') {
     $value = ($value ? 'true' : 'false');
-  } elseif($type == 'object') {
+  } elseif ($type == 'object') {
     $props = get_class_vars(get_class($value));
     $dumper .= '(' . count($props) . ') <u>' . get_class($value) . '</u>';
-    foreach($props as $key => $val) {
+    foreach ($props as $key => $val) {
       $dumper .= "\n" . str_repeat("\t", $level + 1) . $key . ' => ';
       $dumper .= dump($value->$key, '', $level + 1);
     }
     $value = '';
-  } elseif($type == 'array') {
+  } elseif ($type == 'array') {
     $dumper .= '(' . count($value) . ')';
-    foreach($value as $key => $val) {
+    foreach ($value as $key => $val) {
       $dumper .= "\n" . str_repeat("\t", $level + 1) . dump($key, '', -1) . ' => ';
       $dumper .= dump($val, '', $level + 1);
     }
@@ -351,7 +350,7 @@ 
 //  $backtrace = $backtrace[1];
 
   $caller = '';
-  if(defined('SN_DEBUG_PDUMP_CALLER') && SN_DEBUG_PDUMP_CALLER) {
+  if (defined('SN_DEBUG_PDUMP_CALLER') && SN_DEBUG_PDUMP_CALLER) {
     $caller = (!empty($backtrace[1]['class']) ? $backtrace[1]['class'] : '') .
       (!empty($backtrace[1]['type']) ? $backtrace[1]['type'] : '') .
       $backtrace[1]['function'] .
@@ -386,7 +385,7 @@ 
 }
 
 function pr($prePrint = false) {
-  if($prePrint) {
+  if ($prePrint) {
     print("<br>");
   }
   print(mt_rand() . "<br>");
@@ -396,7 +395,7 @@ 
   global $_PRINT_COUNT_VALUE;
   $_PRINT_COUNT_VALUE++;
 
-  if($prePrint) {
+  if ($prePrint) {
     print("<br>");
   }
   print($_PRINT_COUNT_VALUE . "<br>");

classes/Unit/DBStaticUnit.php

Spacing +4 added lines, -4 removed lines

@@ -44,7 +44,7 @@ 
 
     $unit_snid = intval($unit_snid);
 
-    $resultOld = $unit_snid ? (isset($allUnits[$unit_snid]) ? $allUnits[$unit_snid] : null ) : $allUnits;
+    $resultOld = $unit_snid ? (isset($allUnits[$unit_snid]) ? $allUnits[$unit_snid] : null) : $allUnits;
 
     return $resultOld;
   }
@@ -87,7 +87,7 @@ 
   }
 
   public static function db_unit_count_by_user_and_type_and_snid($user_id, $unit_type = 0, $unit_snid = 0) {
-    $query  = doquery(
+    $query = doquery(
       "SELECT unit_snid, sum(unit_level) as `qty`  FROM {{unit}} WHERE `unit_player_id` = {$user_id} " .
       ($unit_type ? "AND `unit_type` = {$unit_type} " : '') .
       ($unit_snid ? "AND `unit_snid` = {$unit_snid} " : '') .
@@ -236,7 +236,7 @@ 
    * @return bool
    */
   protected static function dbAdd($playerId, $planetId, $unitSnId, $amount) {
-    if (!in_array($unitSnId, sn_get_groups([UNIT_SHIPS_STR, UNIT_DEFENCE_STR, UNIT_ARTIFACTS_STR, UNIT_STRUCTURES_STR,]))) {
+    if (!in_array($unitSnId, sn_get_groups([UNIT_SHIPS_STR, UNIT_DEFENCE_STR, UNIT_ARTIFACTS_STR, UNIT_STRUCTURES_STR, ]))) {
       return false;
     }
 
@@ -269,7 +269,7 @@ 
 //        'unit_level'         => $level,
 //      ]);
 
-      $fields     += [
+      $fields += [
         'unit_type'  => get_unit_param($unitSnId, P_UNIT_TYPE),
         'unit_level' => $amount,
       ];

classes/classConfig.php

Spacing +25 added lines, -25 removed lines

@@ -237,9 +237,9 @@ 
     'advGoogleLeftMenuCode'        => '(Place here code for banner)',
 
     // Alliance bonus calculations
-    'ali_bonus_algorithm'          => 0,  // Bonus calculation algorithm
+    'ali_bonus_algorithm'          => 0, // Bonus calculation algorithm
     'ali_bonus_brackets'           => 10, // Brackets count for ALI_BONUS_BY_RANK
-    'ali_bonus_brackets_divisor'   => 10,// Bonus divisor for ALI_BONUS_BY_RANK
+    'ali_bonus_brackets_divisor'   => 10, // Bonus divisor for ALI_BONUS_BY_RANK
     'ali_bonus_divisor'            => 10000000, // Rank divisor for ALI_BONUS_BY_POINTS
     'ali_bonus_members'            => 10, // Minimum alliance size to start using bonus
 
@@ -281,7 +281,7 @@ 
 
     'eco_scale_storage'            => 1,
     'eco_stockman_fleet'           => '', // Black Market - Starting amount of s/h ship merchant to sell
-    'eco_stockman_fleet_populate'  => 1,  // Populate empty Stockman fleet with ships or not
+    'eco_stockman_fleet_populate'  => 1, // Populate empty Stockman fleet with ships or not
     'empire_mercenary_base_period' => PERIOD_MONTH, // Base
     'empire_mercenary_temporary'   => 0, // Temporary empire-wide mercenaries
 
@@ -292,21 +292,21 @@ 
     'energy_basic_income'          => 0,
 
     // Bashing protection settings
-    'fleet_bashing_attacks'        => 3,      // Max amount of attack per wave - 3 by default
-    'fleet_bashing_interval'       => 1800,   // Maximum interval between attacks when they still count as one wave - 30m by default
-    'fleet_bashing_scope'          => 86400,  // Interval on which bashing waves counts - 24h by default
-    'fleet_bashing_war_delay'      => 43200,  // Delay before start bashing after declaring war to alliance - 12h by default
-    'fleet_bashing_waves'          => 3,      // Max amount of waves per day - 3 by default
+    'fleet_bashing_attacks'        => 3, // Max amount of attack per wave - 3 by default
+    'fleet_bashing_interval'       => 1800, // Maximum interval between attacks when they still count as one wave - 30m by default
+    'fleet_bashing_scope'          => 86400, // Interval on which bashing waves counts - 24h by default
+    'fleet_bashing_war_delay'      => 43200, // Delay before start bashing after declaring war to alliance - 12h by default
+    'fleet_bashing_waves'          => 3, // Max amount of waves per day - 3 by default
 
     'Fleet_Cdr'   => 30,
     'fleet_speed' => 1,
 
-    self::FLEET_UPDATE_MAX_RUN_TIME => 30,     // Maximum length in seconds for single fleet dispatch run
+    self::FLEET_UPDATE_MAX_RUN_TIME => 30, // Maximum length in seconds for single fleet dispatch run
     'fleet_update_interval'         => 4,
     'fleet_update_lock'             => '', // SQL time when lock was acquired
 
-    'game_adminEmail'       => 'root@localhost',    // Admin email to show to users
-    'game_counter'          => 0,  // Does built-in page hit counter is on?
+    'game_adminEmail'       => 'root@localhost', // Admin email to show to users
+    'game_counter'          => 0, // Does built-in page hit counter is on?
     // Defaults
     'game_default_language' => 'ru',
     'game_default_skin'     => 'skins/EpicBlue/',
@@ -320,14 +320,14 @@ 
     'game_maxSystem'      => 199,
     'game_maxPlanet'      => 15,
     // Game global settings
-    'game_mode'           => 0,           // 0 - SuperNova, 1 - oGame
+    'game_mode'           => 0, // 0 - SuperNova, 1 - oGame
     'game_name'           => 'SuperNova', // Server name (would be on banners and on top of left menu)
 
     'game_news_actual'        => PERIOD_DAY_3, // How long announcement would be marked as "New". In seconds. Default - 3 days
-    'game_news_overview'      => 3,    // How much last news to show in Overview page
-    'game_news_overview_show' => PERIOD_WEEK_2,    // How long news will be shown in Overview page in seconds. Default - 2 weeks
+    'game_news_overview'      => 3, // How much last news to show in Overview page
+    'game_news_overview_show' => PERIOD_WEEK_2, // How long news will be shown in Overview page in seconds. Default - 2 weeks
     // Noob protection
-    'game_noob_factor'        => 5,    // Multiplier to divide "stronger" and "weaker" users
+    'game_noob_factor'        => 5, // Multiplier to divide "stronger" and "weaker" users
     'game_noob_points'        => 5000, // Below this point user treated as noob. 0 to disable
 
     'game_multiaccount_enabled' => 0, // 1 - allow interactions for players with same IP (multiaccount)
@@ -382,12 +382,12 @@ 
     'payment_currency_exchange_wmz' => 1,
     'payment_currency_exchange_pln' => 3.86,
 
-    'payment_lot_price' => 1,     // Lot's price in default currency
-    'payment_lot_size'  => 2500,  // Lot size. Also service as minimum amount of DM that could be bought with one transaction
+    'payment_lot_price' => 1, // Lot's price in default currency
+    'payment_lot_size'  => 2500, // Lot size. Also service as minimum amount of DM that could be bought with one transaction
 
     'planet_capital_cost'          => 25000, // Cost in DM to move Capital to current planet
-    'planet_capital_mining_rate'   => 2.0,   // Capital Mining rates
-    'planet_capital_building_rate' => 2.0,   // Capital Building rates
+    'planet_capital_mining_rate'   => 2.0, // Capital Mining rates
+    'planet_capital_building_rate' => 2.0, // Capital Building rates
     'planet_teleport_cost'         => 50000, // Cost of planet teleportation
     'planet_teleport_timeout'      => 86400, // Timeout for next teleportation
 
@@ -409,7 +409,7 @@ 
     'resource_multiplier'     => 1,
 
     //Role play system
-    'rpg_bonus_divisor'       => 10,    // Amount of DM referral should get for partner have 1 DM bonus
+    'rpg_bonus_divisor'       => 10, // Amount of DM referral should get for partner have 1 DM bonus
     'rpg_bonus_minimum'       => 10000, // Minimum DM amount for starting paying bonuses to affiliate
 
     // Black Market - General
@@ -474,12 +474,12 @@ 
     'url_purchase_metamatter' => '',
     'url_rules'               => '',
 
-    'users_amount'              => 1,                // Total users count
+    'users_amount'              => 1, // Total users count
     'game_users_online_timeout' => PERIOD_MINUTE_15, // Seconds, How long user should consider ONLINE for online counter
-    'game_users_update_online'  => 30,               // How often user online should be refreshed (seconds)
-    'var_online_user_time'      => 0,                // When last time user online was refreshed
-    'var_online_user_count'     => 0,                // Last calculated online user count
-    'server_log_online'         => 0,                // Log online user count
+    'game_users_update_online'  => 30, // How often user online should be refreshed (seconds)
+    'var_online_user_time'      => 0, // When last time user online was refreshed
+    'var_online_user_count'     => 0, // Last calculated online user count
+    'server_log_online'         => 0, // Log online user count
 
     'user_birthday_celebrate' => 0, // When last time celebrations (i.e. gift-giving) was made - timestamp
     'user_birthday_gift'      => 0, // User birthday gift - Dark Matter points

classes/SnTemplate.php

Spacing +6 added lines, -6 removed lines

@@ -128,7 +128,7 @@ 
         $insert_position = $is_positioned == '-' ? 0 : count($menu);
       }
 
-      $insert_position     += $is_positioned == '+' ? 1 : 0;
+      $insert_position += $is_positioned == '+' ? 1 : 0;
       $spliced             = array_splice($menu, $insert_position, count($menu) - $insert_position);
       $menu[$menu_item_id] = $menu_item;
 
@@ -541,11 +541,11 @@ 
    * @return array
    */
   public static function addFileName($fileNames, $anArray, $ext = '.css') {
-    if(!is_array($fileNames)) {
+    if (!is_array($fileNames)) {
       $fileNames = [$fileNames];
     }
 
-    foreach($fileNames as $fileName) {
+    foreach ($fileNames as $fileName) {
       if (file_exists(SN_ROOT_PHYSICAL . $fileName . '.min' . $ext)) {
         $anArray[$fileName . '.min' . $ext] = '';
       } elseif (file_exists(SN_ROOT_PHYSICAL . $fileName . '.css' . $ext)) {
@@ -676,7 +676,7 @@ 
       'LANG'     => $language ? $language : '',
       'referral' => $id_ref ? '&id_ref=' . $id_ref : '',
 
-      'REQUEST_PARAMS' => !empty($url_params) ? '?' . implode('&', $url_params) : '',// "?lang={$language}" . ($id_ref ? "&id_ref={$id_ref}" : ''),
+      'REQUEST_PARAMS' => !empty($url_params) ? '?' . implode('&', $url_params) : '', // "?lang={$language}" . ($id_ref ? "&id_ref={$id_ref}" : ''),
       'FILENAME'       => basename($_SERVER['PHP_SELF']),
     ));
 
@@ -909,7 +909,7 @@ 
       'QUE_ID'   => QUE_RESEARCH,
       'QUE_HTML' => 'topnav',
 
-      'RESEARCH_ONGOING' => (boolean)$user['que'],
+      'RESEARCH_ONGOING' => (boolean) $user['que'],
 
       'TIME_TEXT'       => sprintf($str_date_format, $time_now_parsed['year'], $lang['months'][$time_now_parsed['mon']], $time_now_parsed['mday'],
         $time_now_parsed['hours'], $time_now_parsed['minutes'], $time_now_parsed['seconds']
@@ -1199,7 +1199,7 @@ 
       SnTemplate::renderFooter($page, $template_result);
     }
 
-    $user['authlevel'] >= 3 && $config->debug ? $debug->echo_log() : false;;
+    $user['authlevel'] >= 3 && $config->debug ? $debug->echo_log() : false; ;
 
     SN::$db->db_disconnect();
 

tools/classes/Spritify.php

Spacing +1 added lines, -1 removed lines

@@ -99,7 +99,7 @@
     $images = [];
 
     foreach (scandir($dirRealPath) as $fileNameOnly) {
-      if (in_array($fileNameOnly, ['.', '..',]) || is_dir($fullPath = "$dirRealPath/$fileNameOnly")) {
+      if (in_array($fileNameOnly, ['.', '..', ]) || is_dir($fullPath = "$dirRealPath/$fileNameOnly")) {
         continue;
       }
       $images = self::tryReadFile($fullPath, $images);

tools/classes/ImageContainer.php

Spacing +1 added lines, -1 removed lines

@@ -54,7 +54,7 @@
   }
 
   public function __get($property) {
-    if (in_array($property, ['height', 'width',]) && ($this->$property === -1)) {
+    if (in_array($property, ['height', 'width', ]) && ($this->$property === -1)) {
       if (isset($this->image)) {
         $this->width  = imagesx($this->image);
         $this->height = imagesy($this->image);

tools/classes/ImageFile.php

Spacing +1 added lines, -1 removed lines

@@ -50,7 +50,7 @@
   }
 
   public function __get($property) {
-    if (in_array($property, ['height', 'width',])) {
+    if (in_array($property, ['height', 'width', ])) {
       return $this->getImageContainer() ? $this->getImageContainer()->$property : 0;
     }
 

tools/classes/Sprite.php

Spacing +2 added lines, -2 removed lines

@@ -46,7 +46,7 @@ 
    */
   public static function createGridSquare($images, $layout) {
     $gridSize = ceil(sqrt(count($images)));
-    usort($images, function (ImageFile $a, ImageFile $b) { return $b->height - $a->height; });
+    usort($images, function(ImageFile $a, ImageFile $b) { return $b->height - $a->height; });
 
     $sprite = new static($gridSize);
     foreach ($images as $image) {
@@ -94,7 +94,7 @@ 
       $line->generate($this->height, $scaleToPx);
 
       $this->height += $line->height;
-      $this->width  = max($this->width, $line->width);
+      $this->width = max($this->width, $line->width);
 
       // $line->image2->savePng($dirOut . count($breakpoints) . '.png'); // TODO remove debug
     }

includes/functions/_news.php

Spacing +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
  * @param int      $query_limit
  */
 function nws_render(&$user, &$template, $query_where = '', $query_limit = 20) {
-  if($user['authlevel'] < AUTH_LEVEL_ADMINISTRATOR) {
+  if ($user['authlevel'] < AUTH_LEVEL_ADMINISTRATOR) {
     $query_where .= (!empty($query_where) ? ' AND ' : '')
       . '`tsTimeStamp` <= (NOW())';
   }