It seems like $gc->unitModel can also be of type object<Closure>. However, the property $unitModel is declared as type object<V2Unit\V2UnitModel>. Maybe add an additional type check?
Our type inference engine has found a suspicous assignment of a value to a property.
This check raises an issue when a value that can be of a mixed type is assigned to
a property that is type hinted more strictly.
For example, imagine you have a variable $accountId that can either hold an
Id object or false (if there is no account id yet). Your code now assigns that
value to the id property of an instance of the Account class. This class
holds a proper account, so the id value must no longer be false.
Either this assignment is in error or a type check should be added for that assignment.
classId{public$id;publicfunction__construct($id){$this->id=$id;}}classAccount{/** @var Id $id */public$id;}$account_id=false;if(starsAreRight()){$account_id=newId(42);}$account=newAccount();if($accountinstanceofId){$account->id=$account_id;}
Loading history...
29
}
30
31
public function load(V2Location $location) {
32
if (!($unitRows = DBStaticUnit::getUnitListByV2Location($location))) {
33
return;
34
}
35
36
foreach ($unitRows as $dbId => $unitRow) {
37
$unit = $this->unitModel->fromArray($unitRow);
38
$this[$unit->snId] = $unit;
39
}
40
}
41
42
public function unitAdd($snId, $level) {
43
$unit = $this->unitModel->buildContainer();
44
$unit->snId = $snId;
45
$unit->level = $level;
46
$this[$snId] = $unit;
47
}
48
49
/**
50
* Function called when index already exists
51
*
52
* Can be used by child object
53
*
54
* @param V2UnitContainer $newUnit
55
* @param int $snId
56
*
57
* @throws \Exception
58
*/
59
protected function onObjectIndexDuplicated($newUnit, $snId) {
supernova-ws /
SuperNova
Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly.
For example, imagine you have a variable
$accountIdthat can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to theidproperty of an instance of theAccountclass. This class holds a proper account, so the id value must no longer be false.Either this assignment is in error or a type check should be added for that assignment.