Issues in artifacts.php - Fixed Issues - Inspection of "CODE-feat-41a6.91: Reducing code smell" - supernova-ws/SuperNova - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — work-fleets ( c97fe0...81e6e5 )

by SuperNova.WS

created 2016-04-12 20:00 UTC

artifacts.php (1 issue)

Labels

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
* artifacts.php
* Artifact actions
*
* @package roleplay
* @version 1.0
*
* Revision History
* ================
* 1.0 copyright (c) 2011 by Gorlum for http://supernova.ws
*
*/

include('common.' . substr(strrchr(__FILE__, '.'), 1));

lng_include('infos');
lng_include('artifacts');

include('includes/includes/art_artifact.php');

$sn_group_artifacts = sn_get_groups('artifacts');

if(($action = sys_get_param_int('action')) && in_array($unit_id = sys_get_param_int('unit_id'), $sn_group_artifacts))
{
  switch($action)
  {
    case ACTION_BUY:
      sn_db_transaction_start();

      $user = db_user_by_id($user['id'], true);
      $artifact_level = mrc_get_level($user, null, $unit_id, true);
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}

      $build_data = eco_get_build_data($user, $planetrow, $unit_id, $artifact_level, true);
      $darkmater_cost = $build_data[BUILD_CREATE][RES_DARK_MATTER];

      // TODO: more correct check - with "FOR UPDATE"
      if(mrc_get_level($user, null, RES_DARK_MATTER) >= $darkmater_cost)
      {
        $unit_max_stack = get_unit_param($unit_id, P_MAX_STACK);
        if(!isset($unit_max_stack) || $unit_max_stack > mrc_get_level($user, $planetrow, $unit_id))
        {
          $db_changeset['unit'][] = sn_db_unit_changeset_prepare($unit_id, 1, $user);
          db_changeset_apply($db_changeset);
          rpg_points_change($user['id'], RPG_ARTIFACT, -($darkmater_cost),
            sprintf('Spent for artifact %1$s ID %2$d', classLocale::$lang['tech'][$unit_id], $unit_id)
          );
          sn_db_transaction_commit();
          header("Location: artifacts.php#{$unit_id}");
          ob_end_flush();
          die();
        }
        else
        {
          $Message = classLocale::$lang['off_maxed_out'];
        }
      }
      else
      {
        $Message = classLocale::$lang['sys_no_points'];
      }
      sn_db_transaction_rollback();
    break;

    case ACTION_USE:
      art_use($user, $planetrow, $unit_id);
      header("Location: artifacts.php#{$unit_id}");
      ob_end_flush();
      die();
    break;
  }
  message($Message, classLocale::$lang['tech'][UNIT_ARTIFACTS], 'artifacts.' . PHP_EX, 5);
}

$template = gettemplate('artifacts', true);

foreach($sn_group_artifacts as $artifact_id)
{
  $artifact_level = mrc_get_level($user, null, $artifact_id, true);
  $build_data = eco_get_build_data($user, $planetrow, $artifact_id, $artifact_level);
  {
    $artifact_data = get_unit_param($artifact_id);
    $artifact_data_bonus = $artifact_data['bonus'];
    $artifact_data_bonus = $artifact_data_bonus >= 0 ? "+{$artifact_data_bonus}" : "{$artifact_data_bonus}";
    switch($artifact_data['bonus_type'])
    {
      case BONUS_PERCENT:
        $artifact_data_bonus = "{$artifact_data_bonus}% ";
      break;

      case BONUS_ADD:
      break;

      case BONUS_ABILITY:
        $artifact_data_bonus = '';
      break;

      default:
      break;
    }

    $template->assign_block_vars('artifact', array(
      'ID'          => $artifact_id,
      'NAME'        => classLocale::$lang['tech'][$artifact_id],
      'DESCRIPTION' => classLocale::$lang['info'][$artifact_id]['description'],
      'EFFECT'      => classLocale::$lang['info'][$artifact_id]['effect'],
      'COST'        => $build_data[BUILD_CREATE][RES_DARK_MATTER],
      'COST_TEXT'   => pretty_number($build_data[BUILD_CREATE][RES_DARK_MATTER]),
      'LEVEL'       => intval($artifact_level),
      'LEVEL_MAX'   => intval($artifact_data['max']),
      'BONUS'       => $artifact_data_bonus,
      'BONUS_TYPE'  => $artifact_data['bonus_type'],
      'CAN_BUY'     => $build_data['CAN'][BUILD_CREATE],
    ));
  }
}

$template->assign_vars(array(
  'PAGE_HEADER' => classLocale::$lang['tech'][UNIT_ARTIFACTS],
  'PAGE_HINT' => classLocale::$lang['art_page_hint'],
));

display(parsetemplate($template), classLocale::$lang['tech'][UNIT_ARTIFACTS]);


1		<?php
2
3		/**
4		* artifacts.php
5		* Artifact actions
6		*
7		* @package roleplay
8		* @version 1.0
9		*
10		* Revision History
11		* ================
12		* 1.0 copyright (c) 2011 by Gorlum for http://supernova.ws
13		*
14		*/
15
16		include('common.' . substr(strrchr(__FILE__, '.'), 1));
17
18		lng_include('infos');
19		lng_include('artifacts');
20
21		include('includes/includes/art_artifact.php');
22
23		$sn_group_artifacts = sn_get_groups('artifacts');
24
25		if(($action = sys_get_param_int('action')) && in_array($unit_id = sys_get_param_int('unit_id'), $sn_group_artifacts))
26		{
27		switch($action)
28		{
29		case ACTION_BUY:
30		sn_db_transaction_start();
31
32		$user = db_user_by_id($user['id'], true);
33		$artifact_level = mrc_get_level($user, null, $unit_id, true);
		0 ignored issues – show Security Bug introduced 2016-03-26 19:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$user` defined by `db_user_by_id($user['id'], true)` on line `32` can also be of type `false`; however, `mrc_get_level()` does only seem to accept `array`, did you maybe forget to handle an error condition? This check looks for type mismatches where the missing type is `false`. This is usually indicative of an error condtion. Consider the follow example <?php function getDate($date) { if ($date !== null) { return new DateTime($date); } return false; } This function either returns a new `DateTime` object or false, if there was an error. This is a typical pattern in PHP programming to show that an error has occurred without raising an exception. The calling code should check for this returned `false` before passing on the value to another function or method that may not be able to handle a `false`. Loading history...
34
35		$build_data = eco_get_build_data($user, $planetrow, $unit_id, $artifact_level, true);
36		$darkmater_cost = $build_data[BUILD_CREATE][RES_DARK_MATTER];
37
38		// TODO: more correct check - with "FOR UPDATE"
39		if(mrc_get_level($user, null, RES_DARK_MATTER) >= $darkmater_cost)
40		{
41		$unit_max_stack = get_unit_param($unit_id, P_MAX_STACK);
42		if(!isset($unit_max_stack) \|\| $unit_max_stack > mrc_get_level($user, $planetrow, $unit_id))
43		{
44		$db_changeset['unit'][] = sn_db_unit_changeset_prepare($unit_id, 1, $user);
45		db_changeset_apply($db_changeset);
46		rpg_points_change($user['id'], RPG_ARTIFACT, -($darkmater_cost),
47		sprintf('Spent for artifact %1$s ID %2$d', classLocale::$lang['tech'][$unit_id], $unit_id)
48		);
49		sn_db_transaction_commit();
50		header("Location: artifacts.php#{$unit_id}");
51		ob_end_flush();
52		die();
53		}
54		else
55		{
56		$Message = classLocale::$lang['off_maxed_out'];
57		}
58		}
59		else
60		{
61		$Message = classLocale::$lang['sys_no_points'];
62		}
63		sn_db_transaction_rollback();
64		break;
65
66		case ACTION_USE:
67		art_use($user, $planetrow, $unit_id);
68		header("Location: artifacts.php#{$unit_id}");
69		ob_end_flush();
70		die();
71		break;
72		}
73		message($Message, classLocale::$lang['tech'][UNIT_ARTIFACTS], 'artifacts.' . PHP_EX, 5);
74		}
75
76		$template = gettemplate('artifacts', true);
77
78		foreach($sn_group_artifacts as $artifact_id)
79		{
80		$artifact_level = mrc_get_level($user, null, $artifact_id, true);
81		$build_data = eco_get_build_data($user, $planetrow, $artifact_id, $artifact_level);
82		{
83		$artifact_data = get_unit_param($artifact_id);
84		$artifact_data_bonus = $artifact_data['bonus'];
85		$artifact_data_bonus = $artifact_data_bonus >= 0 ? "+{$artifact_data_bonus}" : "{$artifact_data_bonus}";
86	View Code Duplication	switch($artifact_data['bonus_type'])
87		{
88		case BONUS_PERCENT:
89		$artifact_data_bonus = "{$artifact_data_bonus}% ";
90		break;
91
92		case BONUS_ADD:
93		break;
94
95		case BONUS_ABILITY:
96		$artifact_data_bonus = '';
97		break;
98
99		default:
100		break;
101		}
102
103		$template->assign_block_vars('artifact', array(
104		'ID' => $artifact_id,
105		'NAME' => classLocale::$lang['tech'][$artifact_id],
106		'DESCRIPTION' => classLocale::$lang['info'][$artifact_id]['description'],
107		'EFFECT' => classLocale::$lang['info'][$artifact_id]['effect'],
108		'COST' => $build_data[BUILD_CREATE][RES_DARK_MATTER],
109		'COST_TEXT' => pretty_number($build_data[BUILD_CREATE][RES_DARK_MATTER]),
110		'LEVEL' => intval($artifact_level),
111		'LEVEL_MAX' => intval($artifact_data['max']),
112		'BONUS' => $artifact_data_bonus,
113		'BONUS_TYPE' => $artifact_data['bonus_type'],
114		'CAN_BUY' => $build_data['CAN'][BUILD_CREATE],
115		));
116		}
117		}
118
119		$template->assign_vars(array(
120		'PAGE_HEADER' => classLocale::$lang['tech'][UNIT_ARTIFACTS],
121		'PAGE_HINT' => classLocale::$lang['art_page_hint'],
122		));
123
124		display(parsetemplate($template), classLocale::$lang['tech'][UNIT_ARTIFACTS]);
125

supernova-ws / SuperNova

Push — work-fleets ( c97fe0...81e6e5 )

artifacts.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like