AccessLogged - Code Metrics - Inspection of "CI-misc-43a1.9: CI-related changes" - supernova-ws/SuperNova - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — trunk ( db071f...8d464a )

by SuperNova.WS

created 2017-06-19 04:34 UTC

AccessLogged A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	88
Duplicated Lines	15.91 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
dl	14
loc	88
rs	10
c	0
b	0
f	0
wmc	11
lcom	1
cbo	1

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__set()	0	13	3
A	inc()	7	7	2
A	dec()	7	7	2
A	getChanges()	0	3	1
A	getDeltas()	0	3	1
A	flush()	0	5	1
A	clear()	0	4	1

How to fix Duplicated Code

<?php
/**
 * Created by Gorlum 16.06.2017 14:32
 */

namespace Common;


/**
 * Class AccessLogged
 * @package Common
 */
class AccessLogged extends AccessMagic {

  /**
   * Starting values of properties
   *
   * @var array $_startValues
   */
  protected $_startValues = [];
  /**
   * Changed values
   *
   * @var array $_changes
   */
  protected $_changes = [];
  /**
   * Increment/Decrement results AKA deltas
   *
   * @var array $_deltas
   */
  protected $_deltas = [];

  public function __set($name, $value) {
    if (array_key_exists($name, $this->values)) {
      if(array_key_exists($name, $this->_deltas)) {
        throw new \Exception(get_called_class() . '::' . $name . ' already INCREMENTED/DECREMENTED - can not CHANGE', ERR_ERROR);
      }

      $this->_changes[$name] = $value;
    } else {
      $this->_startValues[$name] = $value;
    }

    parent::__set($name, $value);
  }

  /**
   * Increments field by value
   *
   * @param string    $name
   * @param int|float $value Default: 1
   */
  public function inc($name, $value = 1) {

    if(array_key_exists($name, $this->_changes)) {
      throw new \Exception(get_called_class() . '::' . $name . ' already changed - can not use INCREMENT', ERR_ERROR);
    }
    $this->_deltas[$name] += $value;
    parent::__set($name, parent::__get($name) + $value);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
  }

  /**
   * Decrements field by value
   *
   * @param string    $name
   * @param int|float $value Default: 1
   */
  public function dec($name, $value = 1) {

    if(array_key_exists($name, $this->_changes)) {
      throw new \Exception(get_called_class() . '::' . $name . ' already changed - can not use DECREMENT', ERR_ERROR);
    }
    $this->_deltas[$name] -= $value;
    parent::__set($name, parent::__get($name) - $value);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
  }

  public function getChanges() {
    return $this->_changes;
  }

  public function getDeltas() {
    return $this->_deltas;
  }

  /**
   * Flushes changes
   *
   * Makes current values a start one and resets changes/deltas
   */
  public function flush() {
    $this->_startValues = $this->values;
    $this->_changes = [];
    $this->_deltas = [];
  }

  public function clear() {
    parent::clear();
    $this->flush();
  }

}


1		<?php
2		/**
3		* Created by Gorlum 16.06.2017 14:32
4		*/
5
6		namespace Common;
7
8
9		/**
10		* Class AccessLogged
11		* @package Common
12		*/
13		class AccessLogged extends AccessMagic {
14
15		/**
16		* Starting values of properties
17		*
18		* @var array $_startValues
19		*/
20		protected $_startValues = [];
21		/**
22		* Changed values
23		*
24		* @var array $_changes
25		*/
26		protected $_changes = [];
27		/**
28		* Increment/Decrement results AKA deltas
29		*
30		* @var array $_deltas
31		*/
32		protected $_deltas = [];
33
34		public function __set($name, $value) {
35		if (array_key_exists($name, $this->values)) {
36		if(array_key_exists($name, $this->_deltas)) {
37		throw new \Exception(get_called_class() . '::' . $name . ' already INCREMENTED/DECREMENTED - can not CHANGE', ERR_ERROR);
38		}
39
40		$this->_changes[$name] = $value;
41		} else {
42		$this->_startValues[$name] = $value;
43		}
44
45		parent::__set($name, $value);
46		}
47
48		/**
49		* Increments field by value
50		*
51		* @param string $name
52		* @param int\|float $value Default: 1
53		*/
54	View Code Duplication	public function inc($name, $value = 1) {
		0 ignored issues – show Duplication introduced 2017-06-19 04:40 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
55		if(array_key_exists($name, $this->_changes)) {
56		throw new \Exception(get_called_class() . '::' . $name . ' already changed - can not use INCREMENT', ERR_ERROR);
57		}
58		$this->_deltas[$name] += $value;
59		parent::__set($name, parent::__get($name) + $value);
		0 ignored issues – show Comprehensibility Bug introduced 2017-06-19 04:40 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`__get()` instead of `inc()`). Are you sure this is correct? If so, you might want to change this to `$this->__get()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history... Comprehensibility Bug introduced 2017-06-19 04:40 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`__set()` instead of `inc()`). Are you sure this is correct? If so, you might want to change this to `$this->__set()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
60		}
61
62		/**
63		* Decrements field by value
64		*
65		* @param string $name
66		* @param int\|float $value Default: 1
67		*/
68	View Code Duplication	public function dec($name, $value = 1) {
		0 ignored issues – show Duplication introduced 2017-06-19 04:40 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
69		if(array_key_exists($name, $this->_changes)) {
70		throw new \Exception(get_called_class() . '::' . $name . ' already changed - can not use DECREMENT', ERR_ERROR);
71		}
72		$this->_deltas[$name] -= $value;
73		parent::__set($name, parent::__get($name) - $value);
		0 ignored issues – show Comprehensibility Bug introduced 2017-06-19 04:40 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`__get()` instead of `dec()`). Are you sure this is correct? If so, you might want to change this to `$this->__get()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history... Comprehensibility Bug introduced 2017-06-19 04:40 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`__set()` instead of `dec()`). Are you sure this is correct? If so, you might want to change this to `$this->__set()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
74		}
75
76		public function getChanges() {
77		return $this->_changes;
78		}
79
80		public function getDeltas() {
81		return $this->_deltas;
82		}
83
84		/**
85		* Flushes changes
86		*
87		* Makes current values a start one and resets changes/deltas
88		*/
89		public function flush() {
90		$this->_startValues = $this->values;
91		$this->_changes = [];
92		$this->_deltas = [];
93		}
94
95		public function clear() {
96		parent::clear();
97		$this->flush();
98		}
99
100		}
101

supernova-ws / SuperNova

Push — trunk ( db071f...8d464a )

AccessLogged A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like