classPersistent

Complexity

Total Complexity

26

Size/Duplication

Total Lines	130
Duplicated Lines	5.38 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	11	2
A	getInstance()	7	7	2
A	db_loadItem()	0	12	4
A	db_loadAll()	0	10	2
A	loadDefaults()	0	5	2
A	db_saveAll()	0	9	1
C	db_saveItem()	0	25	8
A	pass()	0	4	1
A	__get()	0	8	2
A	__set()	0	8	2

<?php
/**
 * Created by Gorlum 29.10.2016 10:16
 */

/**
 *
 * Persistent is extension of class cacher and can save itself to DB
 * It's most usefull to hold basic structures as configuration, variables etc
 * Persistent pretty smart to handle one-level tables structures a-la "variable_name"+"variable_value"
 * Look supernova.sql to learn more
 * Also this class can holds default values for variables
 *
 * @package supernova
 *
 */
class classPersistent extends classCache {
  protected $table_name;
  protected $sql_index_field;
  protected $sql_value_field;

  protected $defaults = array();

  /**
   * @var bool $force
   */
  protected $force = false;

  public function __construct($gamePrefix = 'sn_', $table_name = 'table') {
    parent::__construct("{$gamePrefix}{$table_name}_");
    $this->table_name = $table_name;

    $this->sql_index_field = "{$table_name}_name";
    $this->sql_value_field = "{$table_name}_value";

    if(!$this->_DB_LOADED) {

The property _DB_LOADED does not exist on object<classPersistent>. Since you implemented __get, maybe consider adding a @property annotation.

      $this->db_loadAll();
    }
  }

  public static function getInstance($gamePrefix = 'sn_', $table_name = '') {

This method seems to be duplicated in your project.

    if (!isset(self::$cacheObject)) {
      $className = get_class();
      self::$cacheObject = new $className($gamePrefix, $table_name);
    }
    return self::$cacheObject;
  }

  /**
   * @param string $index
   *
   * @return string|null
   */
  public function db_loadItem($index) {
    $result = null;
    if($index) {
      $index_safe = db_escape($index);
      $queryResult = doquery("SELECT `{$this->sql_value_field}` FROM `{{{$this->table_name}}}` WHERE `{$this->sql_index_field}` = '{$index_safe}' FOR UPDATE", true);

true is of type boolean, but the function expects a string.

      if(is_array($queryResult) && !empty($queryResult)) {
        $this->$index = $result = $queryResult[$this->sql_value_field];
      }
    }

    return $result;
  }

  public function db_loadAll() {
    $this->loadDefaults();

    $query = doquery("SELECT * FROM {{{$this->table_name}}} FOR UPDATE;");
    while($row = db_fetch($query)) {
      $this->$row[$this->sql_index_field] = $row[$this->sql_value_field];
    }

    $this->_DB_LOADED = true;

The property _DB_LOADED does not exist on object<classPersistent>. Since you implemented __set, maybe consider adding a @property annotation.

  }

  public function loadDefaults() {
    foreach($this->defaults as $defName => $defValue) {
      $this->$defName = $defValue;
    }
  }

  public function db_saveAll() {
//    $toSave = array();

57% of this comment could be valid code. Did you maybe forget this after debugging?

//    foreach($this->defaults as $field => $value) {
//      $toSave[$field] = NULL;
//    }
//    $this->db_saveItem($toSave);
    // Для того, что бы не лезть в кэш за каждым айтемом, а сразу все известные переменные сохранить
    $this->db_saveItem(array_combine(array_keys($this->defaults), array_fill(0, count($this->defaults), null)));
  }

  public function db_saveItem($item_list, $value = NULL) {
    if(empty($item_list)) {
      return;
    }

    !is_array($item_list) ? $item_list = array($item_list => $value) : false;

    // Сначала записываем данные в базу - что бы поймать все блокировки
    $qry = array();
    foreach($item_list as $item_name => $item_value) {
      if($item_name) {
        $item_value = db_escape($item_value === NULL ? $this->$item_name : $item_value);
        $item_name = db_escape($item_name);
        $qry[] = "('{$item_name}', '{$item_value}')";
      }
    }
    doquery("REPLACE INTO `{{" . $this->table_name . "}}` (`{$this->sql_index_field}`, `{$this->sql_value_field}`) VALUES " . implode(',', $qry) . ";");

    // И только после взятия блокировок - меняем значения в кэше
    foreach($item_list as $item_name => $item_value) {
      if($item_name) {
        $this->__set($item_name, $item_value);
      }
    }
  }

  /**
   * Makes cache to pass next operation to DB - whether it read or write
   */
  public function pass() {
    $this->force = true;
    return $this;
  }

  public function __get($name) {
    if($this->force) {
      $this->force = false;
      $this->db_loadItem($name);
    }

    return parent::__get($name);
  }

  public function __set($name, $value) {
    if($this->force) {
      $this->force = false;
      $this->db_saveItem($name, $value);
    }

    parent::__set($name, $value);
  }

}