Issues in jumpgate.php - Fixed Issues - Inspection of "CODE-misc-41a6.61: Changed signature of db_planet_..." - supernova-ws/SuperNova - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — work-fleets ( 79b501...f5fbda )

by SuperNova.WS

created 2016-03-26 19:54 UTC

jumpgate.php (2 issues)

Labels

Severity

Major 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * jumpgate.php
 *
 * Jump Gate interface, I presume
 *
 * @version 1.0st Security checks & tests by Gorlum for http://supernova.ws
 * @version 1
 * @copyright 2008 By Chlorel for XNova
 */

include('common.' . substr(strrchr(__FILE__, '.'), 1));

lng_include('fleet');

if($TargetPlanet = sys_get_param_id('jmpto'))
{
  sn_db_transaction_start();
  db_user_by_id($user['id'], true, 'id');
  $planetrow = db_planet_by_id($planetrow['id'], true);
  if(!($NextJumpTime = uni_get_time_to_jump($planetrow)))
  {
    $TargetGate = db_planet_by_id($TargetPlanet, true, '`id`, `last_jump_time`');
    if(mrc_get_level($user, $TargetGate, STRUC_MOON_GATE) > 0)
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
    {
      $NextDestTime = uni_get_time_to_jump ( $TargetGate );
      if(!$NextDestTime)
      {
        // $SubQueryOri = "";
        // $SubQueryDes = "";
        $ship_list = sys_get_param('ships');
        $db_changeset = array();
        foreach($ship_list as $ship_id => $ship_count)
        {
          if(!in_array($ship_id, sn_get_groups('fleet')))
          {
            continue;
          }

          $ship_count = max(0, min(floor($ship_count), mrc_get_level($user, $planetrow, $ship_id)));
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
          if($ship_count)
          {
            $db_changeset['unit'][] = sn_db_unit_changeset_prepare($ship_id, -$ship_count, $user, $planetrow['id']);
            $db_changeset['unit'][] = sn_db_unit_changeset_prepare($ship_id, $ship_count, $user, $TargetGate['id']);
          }
        }
        // Dit monsieur, y avait quelque chose a envoyer ???
        if(!empty($db_changeset))
        {
          db_planet_set_by_id($TargetGate['id'], "`last_jump_time` = " . SN_TIME_NOW . "");
          db_planet_set_by_id($planetrow['id'], "`last_jump_time` = " . SN_TIME_NOW . "");
          db_changeset_apply($db_changeset);

          db_user_set_by_id($user['id'], "`current_planet` = '{$TargetGate['id']}'");

          $planetrow['last_jump_time'] = SN_TIME_NOW;
          $RetMessage = classLocale::$lang['gate_jump_done'] ." - ". pretty_time(uni_get_time_to_jump($planetrow));
        } else {
          $RetMessage = classLocale::$lang['gate_wait_data'];
        }
      } else {
        $RetMessage = classLocale::$lang['gate_wait_dest'] ." - ". pretty_time($NextDestTime);
      }
    } else {
      $RetMessage = classLocale::$lang['gate_no_dest_g'];
    }
  } else {
    $RetMessage = classLocale::$lang['gate_wait_star'] ." - ". pretty_time($NextJumpTime);
  }
  sn_db_transaction_commit();
  message($RetMessage, classLocale::$lang['tech'][STRUC_MOON_GATE], "jumpgate.php", 10);
} else {
  $template = gettemplate('jumpgate', true);
  if(mrc_get_level($user, $planetrow, STRUC_MOON_GATE) > 0)
  {
    $Combo = '';
    $MoonList = db_planet_list_moon_other($user['id'], $planetrow['id']);
    // while($CurMoon = db_fetch($MoonList))
    foreach($MoonList as $CurMoon)
    {
      if(mrc_get_level($user, $CurMoon, STRUC_MOON_GATE) >= 1)
      {
        $NextJumpTime = uni_get_time_to_jump($CurMoon);
        $template->assign_block_vars('moon', array(
          'ID'             => $CurMoon['id'],
          'GALAXY'         => $CurMoon['galaxy'],
          'SYSTEM'         => $CurMoon['system'],
          'PLANET'         => $CurMoon['planet'],
          'NAME'           => $CurMoon['name'],
          'NEXT_JUMP_TIME' => $NextJumpTime ? pretty_time($NextJumpTime) : '',
        ));
      }
    }

    foreach(sn_get_groups('fleet') as $Ship)
    {
      if(($ship_count = mrc_get_level($user, $planetrow, $Ship)) <= 0)
      {
        continue;
      }

      $template->assign_block_vars('fleet', array(
        'SHIP_ID'         => $Ship,
        'SHIP_NAME'       => classLocale::$lang['tech'][$Ship],
        'SHIP_COUNT'      => $ship_count,
        'SHIP_COUNT_TEXT' => pretty_number($ship_count),
      ));
    }

    $template->assign_vars(array(
      'GATE_JUMP_REST_TIME' => uni_get_time_to_jump($planetrow),
      'gate_start_name' => $planetrow['name'],
      'gate_start_link' => uni_render_coordinates_href($planetrow, '', 3),
    ));

    display($template, classLocale::$lang['tech'][STRUC_MOON_GATE]);
  }
  else
  {
    message(classLocale::$lang['gate_no_src_ga'], classLocale::$lang['tech'][STRUC_MOON_GATE], "overview.php", 10);
  }
}

// -----------------------------------------------------------------------------------------------------------
// History version
// 1.0 - Version from scrap .. y avait pas ... bin maintenant y a !!


1			<?php
2
3			/**
4			* jumpgate.php
5			*
6			* Jump Gate interface, I presume
7			*
8			* @version 1.0st Security checks & tests by Gorlum for http://supernova.ws
9			* @version 1
10			* @copyright 2008 By Chlorel for XNova
11			*/
12
13			include('common.' . substr(strrchr(__FILE__, '.'), 1));
14
15			lng_include('fleet');
16
17			if($TargetPlanet = sys_get_param_id('jmpto'))
18			{
19			sn_db_transaction_start();
20			db_user_by_id($user['id'], true, 'id');
21			$planetrow = db_planet_by_id($planetrow['id'], true);
22			if(!($NextJumpTime = uni_get_time_to_jump($planetrow)))
23			{
24			$TargetGate = db_planet_by_id($TargetPlanet, true, '`id`, `last_jump_time`');
25			if(mrc_get_level($user, $TargetGate, STRUC_MOON_GATE) > 0)
			0 ignored issues – show Security Bug introduced 2016-03-26 19:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$TargetGate` defined by db_planet_by_id($TargetP...id`, `last_jump_time`') on line `24` can also be of type `false`; however, `mrc_get_level()` does only seem to accept `array\|null`, did you maybe forget to handle an error condition? This check looks for type mismatches where the missing type is `false`. This is usually indicative of an error condtion. Consider the follow example <?php function getDate($date) { if ($date !== null) { return new DateTime($date); } return false; } This function either returns a new `DateTime` object or false, if there was an error. This is a typical pattern in PHP programming to show that an error has occurred without raising an exception. The calling code should check for this returned `false` before passing on the value to another function or method that may not be able to handle a `false`. Loading history...
26			{
27			$NextDestTime = uni_get_time_to_jump ( $TargetGate );
28			if(!$NextDestTime)
29			{
30			// $SubQueryOri = "";
31			// $SubQueryDes = "";
32			$ship_list = sys_get_param('ships');
33			$db_changeset = array();
34			foreach($ship_list as $ship_id => $ship_count)
35			{
36			if(!in_array($ship_id, sn_get_groups('fleet')))
37			{
38			continue;
39			}
40
41			$ship_count = max(0, min(floor($ship_count), mrc_get_level($user, $planetrow, $ship_id)));
			0 ignored issues – show Security Bug introduced 2016-03-26 19:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$planetrow` defined by `db_planet_by_id($planetrow['id'], true)` on line `21` can also be of type `false`; however, `mrc_get_level()` does only seem to accept `array\|null`, did you maybe forget to handle an error condition? This check looks for type mismatches where the missing type is `false`. This is usually indicative of an error condtion. Consider the follow example <?php function getDate($date) { if ($date !== null) { return new DateTime($date); } return false; } This function either returns a new `DateTime` object or false, if there was an error. This is a typical pattern in PHP programming to show that an error has occurred without raising an exception. The calling code should check for this returned `false` before passing on the value to another function or method that may not be able to handle a `false`. Loading history...
42			if($ship_count)
43			{
44			$db_changeset['unit'][] = sn_db_unit_changeset_prepare($ship_id, -$ship_count, $user, $planetrow['id']);
45			$db_changeset['unit'][] = sn_db_unit_changeset_prepare($ship_id, $ship_count, $user, $TargetGate['id']);
46			}
47			}
48			// Dit monsieur, y avait quelque chose a envoyer ???
49			if(!empty($db_changeset))
50			{
51			db_planet_set_by_id($TargetGate['id'], "`last_jump_time` = " . SN_TIME_NOW . "");
52			db_planet_set_by_id($planetrow['id'], "`last_jump_time` = " . SN_TIME_NOW . "");
53			db_changeset_apply($db_changeset);
54
55			db_user_set_by_id($user['id'], "`current_planet` = '{$TargetGate['id']}'");
56
57			$planetrow['last_jump_time'] = SN_TIME_NOW;
58			$RetMessage = classLocale::$lang['gate_jump_done'] ." - ". pretty_time(uni_get_time_to_jump($planetrow));
59			} else {
60			$RetMessage = classLocale::$lang['gate_wait_data'];
61			}
62			} else {
63			$RetMessage = classLocale::$lang['gate_wait_dest'] ." - ". pretty_time($NextDestTime);
64			}
65			} else {
66			$RetMessage = classLocale::$lang['gate_no_dest_g'];
67			}
68			} else {
69			$RetMessage = classLocale::$lang['gate_wait_star'] ." - ". pretty_time($NextJumpTime);
70			}
71			sn_db_transaction_commit();
72			message($RetMessage, classLocale::$lang['tech'][STRUC_MOON_GATE], "jumpgate.php", 10);
73			} else {
74			$template = gettemplate('jumpgate', true);
75			if(mrc_get_level($user, $planetrow, STRUC_MOON_GATE) > 0)
76			{
77			$Combo = '';
78			$MoonList = db_planet_list_moon_other($user['id'], $planetrow['id']);
79			// while($CurMoon = db_fetch($MoonList))
80			foreach($MoonList as $CurMoon)
81			{
82			if(mrc_get_level($user, $CurMoon, STRUC_MOON_GATE) >= 1)
83			{
84			$NextJumpTime = uni_get_time_to_jump($CurMoon);
85			$template->assign_block_vars('moon', array(
86			'ID' => $CurMoon['id'],
87			'GALAXY' => $CurMoon['galaxy'],
88			'SYSTEM' => $CurMoon['system'],
89			'PLANET' => $CurMoon['planet'],
90			'NAME' => $CurMoon['name'],
91			'NEXT_JUMP_TIME' => $NextJumpTime ? pretty_time($NextJumpTime) : '',
92			));
93			}
94			}
95
96			foreach(sn_get_groups('fleet') as $Ship)
97			{
98			if(($ship_count = mrc_get_level($user, $planetrow, $Ship)) <= 0)
99			{
100			continue;
101			}
102
103			$template->assign_block_vars('fleet', array(
104			'SHIP_ID' => $Ship,
105			'SHIP_NAME' => classLocale::$lang['tech'][$Ship],
106			'SHIP_COUNT' => $ship_count,
107			'SHIP_COUNT_TEXT' => pretty_number($ship_count),
108			));
109			}
110
111			$template->assign_vars(array(
112			'GATE_JUMP_REST_TIME' => uni_get_time_to_jump($planetrow),
113			'gate_start_name' => $planetrow['name'],
114			'gate_start_link' => uni_render_coordinates_href($planetrow, '', 3),
115			));
116
117			display($template, classLocale::$lang['tech'][STRUC_MOON_GATE]);
118			}
119			else
120			{
121			message(classLocale::$lang['gate_no_src_ga'], classLocale::$lang['tech'][STRUC_MOON_GATE], "overview.php", 10);
122			}
123			}
124
125			// -----------------------------------------------------------------------------------------------------------
126			// History version
127			// 1.0 - Version from scrap .. y avait pas ... bin maintenant y a !!
128

supernova-ws / SuperNova

Push — work-fleets ( 79b501...f5fbda )

jumpgate.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like