supernova-ws / SuperNova

includes/db.php

Doc Comments +5 added lines, -5 removed lines

@@ -11,6 +11,9 @@ 
 
 require_once('db/db_queries.php');
 
+/**
+ * @param string $tablename
+ */
 function db_change_units_perform($query, $tablename, $object_id) {
   $query = implode(',', $query);
   if($query && $object_id) {
@@ -67,11 +70,8 @@ 
 /**
  * Функция проверяет статус транзакции
  *
- * @param null|true|false $status Должна ли быть запущена транзакция в момент проверки
- *   <p>null - транзакция НЕ должна быть запущена</p>
- *   <p>true - транзакция должна быть запущена - для совместимости с $for_update</p>
- *   <p>false - всё равно - для совместимости с $for_update</p>
- * @return bool Текущий статус транзакции
+ * @param boolean $transaction_should_be_started
+ * @return null|boolean Текущий статус транзакции
  */
 function sn_db_transaction_check($transaction_should_be_started = null) {
   return classSupernova::db_transaction_check($transaction_should_be_started);

Spacing +6 added lines, -6 removed lines

@@ -5,7 +5,7 @@ 
  * @copyright 2008-2015 Gorlum for Project "SuperNova.WS"
  */
 
-if(!defined('INSIDE')) {
+if (!defined('INSIDE')) {
   die();
 }
 
@@ -13,7 +13,7 @@ 
 
 function db_change_units_perform($query, $tablename, $object_id) {
   $query = implode(',', $query);
-  if($query && $object_id) {
+  if ($query && $object_id) {
     return classSupernova::db_upd_record_by_id($tablename == 'users' ? LOC_USER : LOC_PLANET, $object_id, $query);
   }
 }
@@ -29,15 +29,15 @@ 
 
   $group = sn_get_groups('resources_loot');
 
-  foreach($unit_list as $unit_id => $unit_amount) {
-    if(!in_array($unit_id, $group)) {
+  foreach ($unit_list as $unit_id => $unit_amount) {
+    if (!in_array($unit_id, $group)) {
       // TODO - remove later
       print('<h1>СООБЩИТЕ ЭТО АДМИНУ: db_change_units() вызван для не-ресурсов!</h1>');
       pdump(debug_backtrace());
       die('db_change_units() вызван для не-ресурсов!');
     }
 
-    if(!$unit_amount) {
+    if (!$unit_amount) {
       continue;
     }
 
@@ -46,7 +46,7 @@ 
     $unit_location = sys_get_unit_location($user, $planet, $unit_id);
 
     // Changing value in object
-    switch($unit_location) {
+    switch ($unit_location) {
       case LOC_USER:
         $user[$unit_db_name] += $unit_amount;
         break;

artifacts.php

Spacing +6 added lines, -6 removed lines

@@ -22,9 +22,9 @@ 
 
 $sn_group_artifacts = sn_get_groups('artifacts');
 
-if(($action = sys_get_param_int('action')) && in_array($unit_id = sys_get_param_int('unit_id'), $sn_group_artifacts))
+if (($action = sys_get_param_int('action')) && in_array($unit_id = sys_get_param_int('unit_id'), $sn_group_artifacts))
 {
-  switch($action)
+  switch ($action)
   {
     case ACTION_BUY:
       sn_db_transaction_start();
@@ -36,10 +36,10 @@ 
       $darkmater_cost = $build_data[BUILD_CREATE][RES_DARK_MATTER];
 
       // TODO: more correct check - with "FOR UPDATE"
-      if(mrc_get_level($user, null, RES_DARK_MATTER) >= $darkmater_cost)
+      if (mrc_get_level($user, null, RES_DARK_MATTER) >= $darkmater_cost)
       {
         $unit_max_stack = get_unit_param($unit_id, P_MAX_STACK);
-        if(!isset($unit_max_stack) || $unit_max_stack > mrc_get_level($user, $planetrow, $unit_id))
+        if (!isset($unit_max_stack) || $unit_max_stack > mrc_get_level($user, $planetrow, $unit_id))
         {
           $db_changeset['unit'][] = OldDbChangeSet::db_changeset_prepare_unit($unit_id, 1, $user);
           OldDbChangeSet::db_changeset_apply($db_changeset);
@@ -73,7 +73,7 @@ 
 
 $template = gettemplate('artifacts', true);
 
-foreach($sn_group_artifacts as $artifact_id)
+foreach ($sn_group_artifacts as $artifact_id)
 {
   $artifact_level = mrc_get_level($user, array(), $artifact_id, true);
   $build_data = eco_get_build_data($user, $planetrow, $artifact_id, $artifact_level);
@@ -81,7 +81,7 @@ 
     $artifact_data = get_unit_param($artifact_id);
     $artifact_data_bonus = $artifact_data['bonus'];
     $artifact_data_bonus = $artifact_data_bonus >= 0 ? "+{$artifact_data_bonus}" : "{$artifact_data_bonus}";
-    switch($artifact_data['bonus_type'])
+    switch ($artifact_data['bonus_type'])
     {
       case BONUS_PERCENT:
         $artifact_data_bonus = "{$artifact_data_bonus}% ";

Braces +2 added lines, -4 removed lines

@@ -46,13 +46,11 @@
           rpg_points_change($user['id'], RPG_ARTIFACT, -($darkmater_cost), "Spent for artifact {$lang['tech'][$unit_id]} ID {$unit_id}");
           sn_db_transaction_commit();
           sys_redirect("artifacts.php#{$unit_id}");
-        }
-        else
+        } else
         {
           $Message = $lang['off_maxed_out'];
         }
-      }
-      else
+      } else
       {
         $Message = $lang['sys_no_points'];
       }

index.php

Spacing +3 added lines, -3 removed lines

@@ -5,14 +5,14 @@
  */
 global $template;
 
-if(isset($sn_page_name) || ($sn_page_name = isset($_GET['page']) ? trim(strip_tags($_GET['page'])) : '')) {
+if (isset($sn_page_name) || ($sn_page_name = isset($_GET['page']) ? trim(strip_tags($_GET['page'])) : '')) {
   require_once('common.' . substr(strrchr(__FILE__, '.'), 1));
-  if($sn_page_name) {
+  if ($sn_page_name) {
     // Loading page-specific language files
 
     !empty($sn_mvc['model'][$sn_page_name]) and execute_hooks($sn_mvc['model'][$sn_page_name], $template, 'model', $sn_page_name);
     !empty($sn_mvc['view'][$sn_page_name]) and execute_hooks($sn_mvc['view'][$sn_page_name], $template, 'view', $sn_page_name);
-    if(!empty($template_result) && is_object($template)) {
+    if (!empty($template_result) && is_object($template)) {
       $template->assign_recursive($template_result);
     }
 

classes/sn_module.php

Spacing +34 added lines, -34 removed lines

@@ -104,13 +104,13 @@ 
     // Trying to load configuration from file
     $config_exists = false;
     // Конфигурация может лежать в config_path в манифеста или в корне модуля
-    if(isset($this->manifest['config_path']) && file_exists($config_filename = $this->manifest['config_path'] . '/config.php')) {
+    if (isset($this->manifest['config_path']) && file_exists($config_filename = $this->manifest['config_path'] . '/config.php')) {
       $config_exists = true;
-    } elseif(file_exists($config_filename = dirname($filename) . '/config.php')) {
+    } elseif (file_exists($config_filename = dirname($filename) . '/config.php')) {
       $config_exists = true;
     }
 
-    if($config_exists) {
+    if ($config_exists) {
       include($config_filename);
       $module_config_array = $class_module_name . '_config';
       $this->config = $$module_config_array;
@@ -121,8 +121,8 @@ 
   }
 
   protected function __patch_menu(&$sn_menu_extra, &$menu_patch) {
-    if(isset($menu_patch) && is_array($menu_patch) && !empty($menu_patch)) {
-      foreach($menu_patch as $menu_item_name => $menu_item_data) {
+    if (isset($menu_patch) && is_array($menu_patch) && !empty($menu_patch)) {
+      foreach ($menu_patch as $menu_item_name => $menu_item_data) {
         $sn_menu_extra[$menu_item_name] = $menu_item_data;
       }
     }
@@ -132,13 +132,13 @@ 
   public function initialize() {
     // Checking module status - is it installed and active
     $this->check_status();
-    if(!$this->manifest['active']) {
+    if (!$this->manifest['active']) {
       return;
     }
 
     // Setting constants - if any
-    if(isset($this->manifest['constants']) && is_array($this->manifest['constants']) && !empty($this->manifest['constants'])) {
-      foreach($this->manifest['constants'] as $constant_name => $constant_value) {
+    if (isset($this->manifest['constants']) && is_array($this->manifest['constants']) && !empty($this->manifest['constants'])) {
+      foreach ($this->manifest['constants'] as $constant_name => $constant_value) {
         defined($constant_name) or define($constant_name, $constant_value);
       }
     }
@@ -149,34 +149,34 @@ 
     // New values from module variables will overwrite previous values (for root variables) and array elements with corresponding indexes (for arrays)
     // Constants as array indexes are honored - it's make valid such declarations as 'sn_data[ques][QUE_STRUCTURES]'
     $this->manifest['vars'] = $this->__assign_vars();
-    if(!empty($this->manifest['vars'])) {
+    if (!empty($this->manifest['vars'])) {
       $vars_assigned = array();
-      foreach($this->manifest['vars'] as $var_name => $var_value) {
+      foreach ($this->manifest['vars'] as $var_name => $var_value) {
         $sub_vars = explode('[', str_replace(']', '', $var_name));
         $var_name = $sub_vars[0];
 
-        if(!isset($vars_assigned[$var_name])) {
+        if (!isset($vars_assigned[$var_name])) {
           $vars_assigned[$var_name] = true;
           global $$var_name;
         }
 
         $pointer = &$$var_name;
-        if(($n = count($sub_vars)) > 1) {
-          for($i = 1; $i < $n; $i++) {
-            if(defined($sub_vars[$i])) {
+        if (($n = count($sub_vars)) > 1) {
+          for ($i = 1; $i < $n; $i++) {
+            if (defined($sub_vars[$i])) {
               $sub_vars[$i] = constant($sub_vars[$i]);
             }
 
-            if(!isset($pointer[$sub_vars[$i]]) && $i != $n) {
+            if (!isset($pointer[$sub_vars[$i]]) && $i != $n) {
               $pointer[$sub_vars[$i]] = array();
             }
             $pointer = &$pointer[$sub_vars[$i]];
           }
         }
 
-        if(!isset($pointer) || !is_array($pointer)) {
+        if (!isset($pointer) || !is_array($pointer)) {
           $pointer = $var_value;
-        } elseif(is_array($$var_name)) {
+        } elseif (is_array($$var_name)) {
           $pointer = array_merge_recursive_numeric($pointer, $var_value);
         }
       }
@@ -192,50 +192,50 @@ 
     isset($this->manifest['menu_admin']) and $this->__patch_menu($sn_menu_admin_extra, $this->manifest['menu_admin']);
 
     global $sn_mvc;
-    foreach($sn_mvc as $handler_type => &$handler_data) {
+    foreach ($sn_mvc as $handler_type => &$handler_data) {
       sn_sys_handler_add($handler_data, $this->manifest['mvc'][$handler_type], $this, $handler_type);
     }
 
-    if(isset($this->manifest['i18n']) && is_array($this->manifest['i18n']) && !empty($this->manifest['i18n'])) {
-      foreach($this->manifest['i18n'] as $i18n_page_name => &$i18n_file_list) {
-        foreach($i18n_file_list as &$i18n_file_data) {
-          if(is_array($i18n_file_data) && !$i18n_file_data['path']) {
+    if (isset($this->manifest['i18n']) && is_array($this->manifest['i18n']) && !empty($this->manifest['i18n'])) {
+      foreach ($this->manifest['i18n'] as $i18n_page_name => &$i18n_file_list) {
+        foreach ($i18n_file_list as &$i18n_file_data) {
+          if (is_array($i18n_file_data) && !$i18n_file_data['path']) {
             $i18n_file_data['path'] = $this->manifest['root_relative'];
           }
         }
-        if(!isset($sn_mvc['i18n'][$i18n_page_name])) {
+        if (!isset($sn_mvc['i18n'][$i18n_page_name])) {
           $sn_mvc['i18n'][$i18n_page_name] = array();
         }
         $sn_mvc['i18n'][$i18n_page_name] += $i18n_file_list;
       }
     }
 
-    if(!empty($this->manifest['javascript']) && is_array($this->manifest['javascript'])) {
-      foreach($this->manifest['javascript'] as $javascript_page_name => &$javascript_list) {
+    if (!empty($this->manifest['javascript']) && is_array($this->manifest['javascript'])) {
+      foreach ($this->manifest['javascript'] as $javascript_page_name => &$javascript_list) {
         !isset($sn_mvc['javascript'][$javascript_page_name]) ? $sn_mvc['javascript'][$javascript_page_name] = array() : false;
-        foreach($javascript_list as $script_name => &$script_content) {
+        foreach ($javascript_list as $script_name => &$script_content) {
           $sn_mvc['javascript'][$javascript_page_name][$script_name] = $script_content;
         }
       }
     }
 
-    if(!empty($this->manifest['css']) && is_array($this->manifest['css'])) {
-      foreach($this->manifest['css'] as $javascript_page_name => &$javascript_list) {
+    if (!empty($this->manifest['css']) && is_array($this->manifest['css'])) {
+      foreach ($this->manifest['css'] as $javascript_page_name => &$javascript_list) {
         !isset($sn_mvc['css'][$javascript_page_name]) ? $sn_mvc['css'][$javascript_page_name] = array() : false;
-        foreach($javascript_list as $script_name => &$script_content) {
+        foreach ($javascript_list as $script_name => &$script_content) {
           $sn_mvc['css'][$javascript_page_name][$script_name] = $script_content;
         }
       }
     }
 
-    if(!empty($this->manifest['navbar_prefix_button']) && is_array($this->manifest['navbar_prefix_button'])) {
-      foreach($this->manifest['navbar_prefix_button'] as $button_image => $button_url_relative) {
+    if (!empty($this->manifest['navbar_prefix_button']) && is_array($this->manifest['navbar_prefix_button'])) {
+      foreach ($this->manifest['navbar_prefix_button'] as $button_image => $button_url_relative) {
         $sn_mvc['navbar_prefix_button'][$button_image] = $button_url_relative;
       }
     }
 
-    if(!empty($this->manifest['navbar_main_button']) && is_array($this->manifest['navbar_main_button'])) {
-      foreach($this->manifest['navbar_main_button'] as $button_image => $button_url_relative) {
+    if (!empty($this->manifest['navbar_main_button']) && is_array($this->manifest['navbar_main_button'])) {
+      foreach ($this->manifest['navbar_main_button'] as $button_image => $button_url_relative) {
         $sn_mvc['navbar_main_button'][$button_image] = $button_url_relative;
       }
     }
@@ -251,7 +251,7 @@ 
    */
   protected function __mvcRegisterPagesOld($pages) {
     !is_array($this->manifest['mvc']['pages']) ? $this->manifest['mvc']['pages'] = array() : false;
-    if(is_array($pages) && !empty($pages)) {
+    if (is_array($pages) && !empty($pages)) {
       $this->manifest['mvc']['pages'] = array_merge($this->manifest['mvc']['pages'], $pages);
     }
   }

classes/AjaxController.php

Spacing +4 added lines, -4 removed lines

@@ -21,7 +21,7 @@ 
 
     define('IN_AJAX', true);
 
-    if(!is_object($template)) {
+    if (!is_object($template)) {
       $template = gettemplate('_ajax', true);
     }
 
@@ -37,16 +37,16 @@ 
 
     $mode = sys_get_param_str('mode');
 
-    if(class_exists($className = 'Pages\\Page' . ucfirst($mode))) {
+    if (class_exists($className = 'Pages\\Page' . ucfirst($mode))) {
       /**
        * @var \Pages\IPage $page
        */
       $page = new $className();
-      if(method_exists($page, 'loadParams')) {
+      if (method_exists($page, 'loadParams')) {
         $page->loadParams();
       }
 
-      if(method_exists($page, $action = sys_get_param('action')) && $page->checkAction($action)) {
+      if (method_exists($page, $action = sys_get_param('action')) && $page->checkAction($action)) {
         $result = $page->$action();
         is_array($result) ? HelperArray::merge($template_result['AJAX'], $result) : false;
       }

classes/PTLTag.php

Spacing +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
     $this->raw = $stringTag;
 
     // Separating params - so there are will be no false-positives for template's variable names
-    if(strpos($this->raw, '|') !== false) {
+    if (strpos($this->raw, '|') !== false) {
       $this->params = explode('|', $this->raw);
       $this->resolved = $this->params[0];
       unset($this->params[0]);

classes/Pages/PageQuest.php

Spacing +1 added lines, -1 removed lines

@@ -31,7 +31,7 @@
       QUEST_STATUS_COMPLETE => '',
     );
 
-    if(!isset($statuses[$this->filterQuestStatus])) {
+    if (!isset($statuses[$this->filterQuestStatus])) {
       $this->filterQuestStatus = QUEST_STATUS_ALL;
     }
   }

classes/TextModel.php

Spacing +2 added lines, -2 removed lines

@@ -101,7 +101,7 @@ 
       }
     }
 
-    if(!isset($next)) {
+    if (!isset($next)) {
       $next = new TextEntity();
     }
 
@@ -119,7 +119,7 @@ 
       $prev = $this->getById($currentText->prev);
     }
 
-    if(!isset($prev)) {
+    if (!isset($prev)) {
       $prev = new TextEntity();
     }
 

infos.php

Spacing +12 added lines, -12 removed lines

@@ -7,16 +7,16 @@ 
 include('common.' . substr(strrchr(__FILE__, '.'), 1));
 
 $unit_id = sys_get_param_id('gid');
-if($unit_id == RES_DARK_MATTER) {
+if ($unit_id == RES_DARK_MATTER) {
   sys_redirect('dark_matter.php');
 }
 
-if($unit_id == RES_METAMATTER) {
+if ($unit_id == RES_METAMATTER) {
   sys_redirect('metamatter.php');
 }
 
 lng_include('infos');
-if(!$unit_id || (!get_unit_param($unit_id) && !isset($lang['info'][$unit_id]))) {
+if (!$unit_id || (!get_unit_param($unit_id) && !isset($lang['info'][$unit_id]))) {
   sys_redirect('index.php?page=techtree');
 }
 
@@ -25,7 +25,7 @@ 
 $unit_data = get_unit_param($unit_id);
 $unit_type = $unit_data['type'];
 
-if($unit_type == UNIT_SHIPS) {
+if ($unit_type == UNIT_SHIPS) {
   $template_result['UNIT_IS_SHIP'] = true;
 
   $ship_data = get_ship_data($unit_id, $user);
@@ -41,7 +41,7 @@ 
   );
 
   $engine_template_info = array();
-  foreach($unit_data['engine'] as $unit_engine_data) {
+  foreach ($unit_data['engine'] as $unit_engine_data) {
     $unit_engine_data = get_engine_data($user, $unit_engine_data);
 
     $engine_template_info[] = array(
@@ -60,7 +60,7 @@ 
 
 
 $sn_data_group_combat = sn_get_groups('combat');
-if(in_array($unit_id, $sn_data_group_combat)) {
+if (in_array($unit_id, $sn_data_group_combat)) {
   $template_result['UNIT_IS_COMBAT'] = true;
 
   $unit_durability = $unit_data['shield'] + $unit_data['armor'];
@@ -68,21 +68,21 @@ 
   $volley_arr = $rapid_to = $rapid_from = array();
   $str_rapid_from = '';
   $str_rapid_to = '';
-  foreach($sn_data_group_combat as $enemy_id) {
+  foreach ($sn_data_group_combat as $enemy_id) {
     $enemy_data = get_unit_param($enemy_id);
     $enemy_durability = $enemy_data['shield'] + $enemy_data['armor'];
 
     $rapid = $unit_data['attack'] * (isset($unit_data['amplify'][$enemy_id]) ? $unit_data['amplify'][$enemy_id] : 1) / $enemy_durability;
-    if($rapid >= 1) {
+    if ($rapid >= 1) {
       $volley_arr[$enemy_id]['TO'] = floor($rapid);
     }
 
     $rapid = $enemy_data['attack'] * (isset($enemy_data['amplify'][$unit_id]) ? $enemy_data['amplify'][$unit_id] : 1) / $unit_durability;
-    if($rapid >= 1) {
+    if ($rapid >= 1) {
       $volley_arr[$enemy_id]['FROM'] = floor($rapid);
     }
   }
-  foreach($volley_arr as $enemy_id => &$rapid) {
+  foreach ($volley_arr as $enemy_id => &$rapid) {
     $rapid['ENEMY_ID'] = $enemy_id;
     $rapid['ENEMY_NAME'] = $lang['tech'][$enemy_id];
   }
@@ -100,11 +100,11 @@ 
 
 }
 
-if($lang['info'][$unit_id]['effect']) {
+if ($lang['info'][$unit_id]['effect']) {
   $template_result['UNIT_EFFECT'] = $lang['info'][$unit_id]['effect'];
 }
 
-if($unit_data['bonus']) {
+if ($unit_data['bonus']) {
   $unit_bonus = !$unit_data['bonus'] || $unit_data['bonus_type'] == BONUS_ABILITY ? '' : (
     ($unit_data['bonus'] >= 0 ? '+' : '') . $unit_data['bonus'] . ($unit_data['bonus_type'] == BONUS_PERCENT ? '%' : '')
   );