sn_module_payment

Complexity

Total Complexity

93

Size/Duplication

Total Lines	937
Duplicated Lines	2.77 %

Coupling/Cohesion

Components	1
Dependencies	9

Test Coverage

Coverage

0%

Importance

Changes	6
Bugs	0	Features	0

14 Methods

Rating	Name	Duplication	Size	Complexity
B	payment_request_response()	0	28	6
A	currency_convert()	0	14	3
D	bonus_calculate()	12	28	9
A	retranslate_error()	0	3	2
C	compile_request()	0	45	7
F	payment_request_process()	14	121	36
B	db_insert()	0	54	7
A	payment_adjust_mm_new()	0	11	3
C	payment_cancel()	0	25	7
A	db_get_by_id()	0	14	1
B	db_complete_payment()	0	13	6
B	payment_reset()	0	32	1
B	db_assign_payment()	0	41	3
A	generate_description()	0	11	2

<?php
/**
 * Created by Gorlum 21.04.2015 3:49
 */

abstract class sn_module_payment extends sn_module {
  public static $bonus_table = array(
    2000 => 0,
    // 5000 => 0,

58% of this comment could be valid code. Did you maybe forget this after debugging?

    10000 => 0,
    20000 => 0,

    50000 => 0.02,
    100000 => 0.05,
    200000 => 0.07,
    300000 => 0.10,
    400000 => 0.15,
    500000 => 0.20,
    800000 => 0.25,
    1000000 => 0.30,
    1500000 => 0.40,
    2000000 => 0.50,
    3000000 => 0.60,
    5000000 => 0.70,
  );

  public static $payment_methods = array(
    PAYMENT_METHOD_BANK_CARD => array(
      /*

43% of this comment could be valid code. Did you maybe forget this after debugging?

      PAYMENT_METHOD_id => array(
        'currency' => 'WMR', // Currency code 3 letter
        'image' => 'design/images/payments/emoney/webmoney.png', // Optional - image location from root. Setting image disables buttoning and name printing
        'name' => true, // Optional. Forces method name printing with 'image' set
        'button' => true, // Optional. Forces method buttoning with 'image' set
      ),
      */
      PAYMENT_METHOD_BANK_CARD_STANDARD => array(
        'currency' => 'RUB',
        'image' => 'design/images/payments/card/generic.png',
        'button' => true,
      ),
      PAYMENT_METHOD_BANK_CARD_LIQPAY => array(
        'currency' => 'UAH',
        'image' => 'design/images/payments/card/liqpay.png',
        'button' => true,
      ),
      PAYMENT_METHOD_BANK_CARD_EASYPAY => array(
        'currency' => 'UAH',
        'image' => 'design/images/payments/card/easypay.png',
        'button' => true,
      ),
      PAYMENT_METHOD_BANK_CARD_AMERICAN_EXPRESS => array(
        'currency' => 'USD',
        'image' => 'design/images/payments/card/american_express.png',
        'button' => true,
      ),
      PAYMENT_METHOD_BANK_CARD_JCB => array(
        'currency' => 'USD',
        'image' => 'design/images/payments/card/jcb.png',
        'button' => true,
      ),
      PAYMENT_METHOD_BANK_CARD_UNIONPAY => array(
        'currency' => 'USD',
        'image' => 'design/images/payments/card/unionpay.png',
        'button' => true,
      ),
    ),

    PAYMENT_METHOD_EMONEY => array(
      PAYMENT_METHOD_EMONEY_YANDEX => array(
        'currency' => 'RUB',
        'image' => 'design/images/payments/emoney/yandexmoney.png',
        'button' => true,
      ),
      PAYMENT_METHOD_EMONEY_QIWI => array(
        'currency' => 'RUB',
        'image' => 'design/images/payments/emoney/qiwi.png',
        'button' => true,
      ),
      PAYMENT_METHOD_EMONEY_PAYPAL => array(
        'currency' => 'RUB',
        'image' => 'design/images/payments/emoney/paypal.png',
        'button' => true,
      ),
      PAYMENT_METHOD_EMONEY_WEBMONEY_WMR => array(
        'currency' => 'WMR',
        'image' => 'design/images/payments/emoney/webmoney_wmr.gif',
        'button' => true,
      ),
      PAYMENT_METHOD_EMONEY_WEBMONEY_WMZ => array(
        'currency' => 'WMZ',
        'image' => 'design/images/payments/emoney/webmoney_wmz.gif',
        'button' => true,
      ),
      PAYMENT_METHOD_EMONEY_WEBMONEY_WMU => array(
        'currency' => 'WMU',
        'image' => 'design/images/payments/emoney/webmoney_wmu.gif',
        'button' => true,
      ),
      PAYMENT_METHOD_EMONEY_WEBMONEY_WME => array(
        'currency' => 'WME',
        'image' => 'design/images/payments/emoney/webmoney_wme.gif',
        'button' => true,
      ),
      PAYMENT_METHOD_EMONEY_WEBMONEY_WMB => array(
        'currency' => 'WMB',
        'image' => 'design/images/payments/emoney/webmoney_wmb.gif',
        'button' => true,
      ),
      PAYMENT_METHOD_EMONEY_TELEMONEY => array(
        'currency' => 'RUB',
        'image' => 'design/images/payments/emoney/telemoney.gif',
        'button' => true,
      ),
      PAYMENT_METHOD_EMONEY_ELECSNET => array(
        'currency' => 'RUB',
        'image' => 'design/images/payments/emoney/elecsnet.png',
        'button' => true,
      ),
      PAYMENT_METHOD_EMONEY_EASYPAY => array(
        'currency' => 'RUB',
        'image' => 'design/images/payments/emoney/easypay.png',
        'button' => true,
      ),
      PAYMENT_METHOD_EMONEY_RUR_W1R => array(
        'currency' => 'RUB',
        'image' => 'design/images/payments/emoney/walletone.png',
        'button' => true,
      ),
      PAYMENT_METHOD_EMONEY_MAILRU => array(
        'currency' => 'RUB',
        'image' => 'design/images/payments/emoney/mailru.gif',
      ),
    ),

    PAYMENT_METHOD_MOBILE => array(
      PAYMENT_METHOD_MOBILE_SMS => array(
        'currency' => 'RUB',
        'image' => 'design/images/payments/mobile/sms.png',
        'name' => true,
        'button' => true,
      ),
      PAYMENT_METHOD_MOBILE_PAYPAL_ZONG => array(
        'currency' => 'USD',
        'image' => 'design/images/payments/mobile/paypal_zong.png',
        'name' => true,
        'button' => true,
      ),
      PAYMENT_METHOD_MOBILE_XSOLLA => array(
        'currency' => 'RUB',
        'image' => 'design/images/payments/mobile/xsolla.png',
        'name' => true,
        'button' => true,
      ),


      PAYMENT_METHOD_MOBILE_MEGAPHONE => array(
        'currency' => 'RUB',
        'image' => 'design/images/payments/mobile/megafon.png',
        'button' => true,
      ),
      PAYMENT_METHOD_MOBILE_MTS => array(
        'currency' => 'RUB',
        'image' => 'design/images/payments/mobile/mts.png',
        'button' => true,
      ),
      PAYMENT_METHOD_MOBILE_KYIVSTAR => array(
        'currency' => 'UAH',
        'image' => 'design/images/payments/mobile/kyivstar.png',
        'button' => true,
      ),
    ),

    PAYMENT_METHOD_BANK_INTERNET => array(
      PAYMENT_METHOD_BANK_INTERNET_PRIVAT24 => array(
        'currency' => 'UAH',
        'image' => 'design/images/payments/bank_internet/privat24.png',
        'button' => true,
      ),
      PAYMENT_METHOD_BANK_INTERNET_BANK24 => array(
        'currency' => 'UAH',
        'image' => 'design/images/payments/bank_internet/bank24.png',
        'button' => true,
      ),
      PAYMENT_METHOD_BANK_INTERNET_ALFA_BANK => array(
        'currency' => 'RUB',
        'image' => 'design/images/payments/bank_internet/alfa_bank.png',
        'button' => true,
      ),
      PAYMENT_METHOD_BANK_INTERNET_SBERBANK => array(
        'currency' => 'RUB',
        'image' => 'design/images/payments/bank_internet/sberbank.png',
        'button' => true,
      ),
      PAYMENT_METHOD_BANK_INTERNET_PROSMVYAZBANK => array(
        'currency' => 'RUB',
        'image' => 'design/images/payments/bank_internet/prosmvyazbank.png',
        'button' => true,
      ),
      PAYMENT_METHOD_BANK_INTERNET_HANDY_BANK => array(
        'currency' => 'RUB',
        'image' => 'design/images/payments/bank_internet/handy_bank.png',
        'button' => true,
      ),
      PAYMENT_METHOD_BANK_INTERNET_RUSSKIY_STANDART => array(
        'currency' => 'RUB',
        'image' => 'design/images/payments/bank_internet/russkiy_standart.gif',
      ),
      PAYMENT_METHOD_BANK_INTERNET_VTB24 => array(
        'currency' => 'RUB',
        'image' => 'design/images/payments/bank_internet/vtb24.gif',
      ),
      PAYMENT_METHOD_BANK_INTERNET_OCEAN_BANK => array(
        'currency' => 'RUB',
        'image' => 'design/images/payments/bank_internet/ocean_bank.gif',
      ),
      PAYMENT_METHOD_BANK_INTERNET_007 => array(
        'currency' => 'RUB',
      ),
      PAYMENT_METHOD_BANK_INTERNET_008 => array(
        'currency' => 'RUB',
      ),
      PAYMENT_METHOD_BANK_INTERNET_009 => array(
        'currency' => 'RUB',
      ),
      PAYMENT_METHOD_BANK_INTERNET_010 => array(
        'currency' => 'RUB',
      ),
      PAYMENT_METHOD_BANK_INTERNET_011 => array(
        'currency' => 'RUB',
      ),
      PAYMENT_METHOD_BANK_INTERNET_012 => array(
        'currency' => 'RUB',
      ),
      PAYMENT_METHOD_BANK_INTERNET_013 => array(
        'currency' => 'RUB',
      ),
      PAYMENT_METHOD_BANK_INTERNET_014 => array(
        'currency' => 'RUB',
      ),
      PAYMENT_METHOD_BANK_INTERNET_015 => array(
        'currency' => 'RUB',
      ),
      PAYMENT_METHOD_BANK_INTERNET_016 => array(
        'currency' => 'RUB',
      ),
      PAYMENT_METHOD_BANK_INTERNET_017 => array(
        'currency' => 'RUB',
      ),
      PAYMENT_METHOD_BANK_INTERNET_018 => array(
        'currency' => 'RUB',
      ),
      PAYMENT_METHOD_BANK_INTERNET_019 => array(
        'currency' => 'RUB',
      ),
      PAYMENT_METHOD_BANK_INTERNET_020 => array(
        'currency' => 'RUB',
      ),
      PAYMENT_METHOD_BANK_INTERNET_021 => array(
        'currency' => 'RUB',
      ),
    ),

    PAYMENT_METHOD_BANK_TRANSFER => array(
    ),

    PAYMENT_METHOD_TERMINAL => array(
      PAYMENT_METHOD_TERMINAL_UKRAINE => array(
        'currency' => 'UAH',
        'image' => 'design/images/payments/terminal/ukraine.png',
        'button' => true,
        'name' => true,
      ),
      PAYMENT_METHOD_TERMINAL_IBOX => array(
        'currency' => 'UAH',
        'image' => 'design/images/payments/terminal/ibox.png',
        'button' => true,
      ),
      PAYMENT_METHOD_TERMINAL_EASYPAY => array(
        'currency' => 'UAH',
        'image' => 'design/images/payments/terminal/easypay.png',
        'button' => true,
      ),
      PAYMENT_METHOD_TERMINAL_RUSSIA => array(
        'currency' => 'RUB',
        'image' => 'design/images/payments/terminal/russia.png',
        'button' => true,
        'name' => true,
      ),
      PAYMENT_METHOD_TERMINAL_QIWI => array(
        'currency' => 'RUB',
        'image' => 'design/images/payments/terminal/qiwi.png',
        'button' => true,
      ),
      PAYMENT_METHOD_TERMINAL_ELECSNET => array(
        'currency' => 'RUB',
        'image' => 'design/images/payments/terminal/elecsnet.png',
        'button' => true,
      ),
      PAYMENT_METHOD_TERMINAL_TELEPAY => array(
        'currency' => 'RUB',
        'image' => 'design/images/payments/terminal/telepay.png',
        'button' => true,
      ),
      PAYMENT_METHOD_TERMINAL_ELEMENT => array(
        'currency' => 'RUB',
        'image' => 'design/images/payments/terminal/element.gif',
      ),
      PAYMENT_METHOD_TERMINAL_KASSIRANET => array(
        'currency' => 'RUB',
        'image' => 'design/images/payments/terminal/kassira_net.gif',
        'button' => true,
      ),
    ),

    PAYMENT_METHOD_OTHER => array(
      PAYMENT_METHOD_OTHER_EVROSET => array(
        'currency' => 'RUB',
        'image' => 'design/images/payments/other/evroset.gif',
      ),
      PAYMENT_METHOD_OTHER_SVYAZNOY => array(
        'currency' => 'RUB',
        'image' => 'design/images/payments/other/svyaznoy.gif',
      ),
      PAYMENT_METHOD_OTHER_ROBOKASSA_MOBILE => array(
        'currency' => 'RUB',
        'image' => 'design/images/payments/other/robokassa_mobile.gif',
        'name' => true,
      ),
    ),

    PAYMENT_METHOD_GENERIC => array(
      PAYMENT_METHOD_GENERIC_XSOLLA => array(
        'currency' => 'UAH',
        'image' => 'design/images/payments/generic/xsolla.png',
        'name' => true,
        'button' => true,
      ),

      PAYMENT_METHOD_GENERIC_ROBOKASSA => array(
        'currency' => 'RUB',
        'image' => 'design/images/payments/generic/robokassa.jpg',
        // 'name' => true,

43% of this comment could be valid code. Did you maybe forget this after debugging?

        'button' => true,
      ),
    ),
  );

  /**
   * @var Account $account
   */
  public $account = null;

  /**
   * @var db_mysql $db
   */
  public $db = null;

  /**
   * @var int
   */
  public $request_payment_id = 0;
  /**
   * Идентификатор сервера, на который производится оплата
   *
   * @var string $request_server_id
   */
  public $request_server_id = '';
  /**
   * Идентификатор платящего пользователя
   *
   * @var int
   */
  public $request_account_id = 0;
  /**
   * @var int
   */
  // public $request_mm_amount = 0;

45% of this comment could be valid code. Did you maybe forget this after debugging?

  /**
   * @var float
   */
  // public $request_money_out = 0.0;

45% of this comment could be valid code. Did you maybe forget this after debugging?

  /**
   * Внутренний идентификатор платежа
   *
   * @var int
   */
  public $payment_id = 0;
  public $payment_status = PAYMENT_STATUS_NONE;
  public $payment_provider_id = ACCOUNT_PROVIDER_NONE;
  public $payment_account_id = 0;
  public $payment_account_name = '';
  public $payment_user_id = 0;
  public $payment_user_name = '';
  public $payment_amount = 0;
  public $payment_currency = '';
  public $payment_dark_matter_paid = 0;
  public $payment_dark_matter_gained = 0;
  public $payment_date = SN_TIME_SQL;
  public $payment_comment = '';
  public $payment_module_name = '';

  public $payment_external_id = '';
  public $payment_external_date = '';
  public $payment_external_lots = 0;
  public $payment_external_amount = 0;
  public $payment_external_currency = '';

  public $payment_test = 0;

  public $is_exists = false;
  public $is_loaded = false;

  protected $description_generated = array();

  protected $debug = false;

  protected $payment_params = array(
//    'server_id' => 'shp_server', // Должен быть server_id

46% of this comment could be valid code. Did you maybe forget this after debugging?

//    'account_id' => 'shp_id', // Должен быть user_id
//    'payment_id' => 'InvId', // Должен быть внутренний payment_id
//    'payment_dark_matter_gained' => 'shp_dm', // TODO - Реально - dark_matter_gained! Что бы учитывались акции!
//    'payment_external_money' => 'OutSum', // Количество денег "к оплате" от СН
//    'test' => 'shp_z_test', // Тестовый статус аккаунта
//    'payment_external_id' => '', // ИД платежа в платёжной системе
//    'payment_external_currency' => 'payment_currency', // Валюта платежа в платёжной системе
  );

  protected $result_translations = array(
    // Универсальный ответ на неизвестную ошибку
    SN_PAYMENT_REQUEST_UNDEFINED_ERROR => SN_PAYMENT_REQUEST_UNDEFINED_ERROR,
    // Утвердительный ответ
    SN_PAYMENT_REQUEST_OK => SN_PAYMENT_REQUEST_OK,
  );

//  public function __construct($filename = __FILE__) {

52% of this comment could be valid code. Did you maybe forget this after debugging?

//    parent::__construct($filename);
//  }

  /**
   * Компилирует запрос к платёжной системе
   *
   * @param $request
   *
   * @throws Exception
   */
  public function compile_request($request) {
    global $user;

    if(!(classSupernova::$auth->account instanceof Account)) {

This if statement is empty and can be removed.

      // TODO - throw new Exception(lang['pay_msg_mm_request_amount_invalid'], SN_PAYMENT_REQUEST_ERROR_UNIT_AMOUNT);

45% of this comment could be valid code. Did you maybe forget this after debugging?

    }
    $this->account = classSupernova::$auth->account;

    $this->db = $this->account->db;
    // pdump($this->db);

63% of this comment could be valid code. Did you maybe forget this after debugging?

    $this->payment_provider_id = core_auth::$main_provider->provider_id;
    $this->payment_account_id = $this->account->account_id;
    $this->payment_account_name = $this->account->account_name;
    $this->payment_user_id = $user['id'];
    $this->payment_user_name = $user['username'];

    // TODO - минимальное количество ММ к оплате
    $this->payment_dark_matter_paid = $request['metamatter'];
    $this->payment_dark_matter_gained = self::bonus_calculate($this->payment_dark_matter_paid, true);

It seems like self::bonus_calculate($this->payment_dark_matter_paid, true) can also be of type double. However, the property $payment_dark_matter_gained is declared as type integer. Maybe add an additional type check?

    $this->payment_currency = classSupernova::$config->payment_currency_default;
    $this->payment_amount = self::currency_convert($this->payment_dark_matter_paid, 'MM_', $this->payment_currency);

It seems like self::currency_convert($this->payment_dark_matter_paid, 'MM_', $this->payment_currency) can also be of type double. However, the property $payment_amount is declared as type integer. Maybe add an additional type check?

    if(empty($this->payment_external_currency) && !empty($this->config['currency'])) {
      $this->payment_external_currency = $this->config['currency'];
    }
    if(empty($this->payment_external_currency)) {
      throw new Exception(classLocale::$lang['pay_error_internal_no_external_currency_set'], SN_PAYMENT_ERROR_INTERNAL_NO_EXTERNAL_CURRENCY_SET);
    }

    $this->payment_external_amount = self::currency_convert($this->payment_dark_matter_paid, 'MM_', $this->payment_external_currency);

It seems like self::currency_convert($this->payment_dark_matter_paid, 'MM_', $this->payment_external_currency) can also be of type double. However, the property $payment_external_amount is declared as type integer. Maybe add an additional type check?

    if($this->payment_external_amount < 0.01) {
      throw new Exception(classLocale::$lang['pay_msg_mm_request_amount_invalid'], SN_PAYMENT_REQUEST_ERROR_UNIT_AMOUNT);
    }

    $this->payment_test = !empty($this->config['test']);

The property $payment_test was declared of type integer, but !empty($this->config['test']) is of type boolean. Maybe add a type cast?

    $this->generate_description();

    $this->db_insert();
    if(!$this->is_exists) {
      throw new Exception(classLocale::$lang['pay_msg_request_error_db_payment_create'], SN_PAYMENT_REQUEST_DB_ERROR_PAYMENT_CREATE);
    }
  }

  /**
   * @param array $options
   *
   * @return array
   * @throws Exception
   */
  protected function payment_request_process($options = array()) {
    if(!$this->manifest['active']) {
      throw new Exception(classLocale::$lang['pay_msg_module_disabled'], SN_MODULE_DISABLED);
    }

    // Если есть payment_id - загружаем под него данные
    if(!empty($this->payment_params['payment_id'])) {
      $this->request_payment_id = sys_get_param_id($this->payment_params['payment_id']);

It seems like sys_get_param_id($this->payment_params['payment_id']) can also be of type string or array. However, the property $request_payment_id is declared as type integer. Maybe add an additional type check?

      if(!$this->request_payment_id) {
        throw new Exception(classLocale::$lang['pay_msg_request_payment_id_invalid'], SN_PAYMENT_REQUEST_INTERNAL_ID_WRONG);
      }

      if(!$this->db_get_by_id($this->request_payment_id)) {
        throw new Exception(classLocale::$lang['pay_msg_request_payment_id_invalid'], SN_PAYMENT_REQUEST_INTERNAL_ID_WRONG);
      }

      // Проверяем - был ли этот платеж обработан?
      // TODO - Статусы бывают разные. Нужен спецфлаг payment_processed
      if($this->payment_status != PAYMENT_STATUS_NONE) {
        sn_db_transaction_rollback();
        sys_redirect(SN_ROOT_VIRTUAL . 'metamatter.php?payment_id=' . $this->payment_id);
        die();
      }
    }

    // Пытаемся получить из запроса ИД аккаунта
    $request_account_id = !empty($this->payment_params['account_id']) ? sys_get_param_id($this->payment_params['account_id']) : 0;
    // Если в запросе нет ИД аккаунта - пытаемся использовать payment_account_id
    if(empty($request_account_id) && !empty($this->payment_account_id)) {
      $request_account_id = $this->payment_account_id;
    }
    // Если теперь у нас нету ИД аккаунта ни в запросе, ни в записи таблицы - можно паниковать
    if(empty($request_account_id)) {
      // TODO - аккаунт
      throw new Exception(classLocale::$lang['pay_msg_request_user_invalid'], $this->retranslate_error(SN_PAYMENT_REQUEST_USER_NOT_FOUND, $options));
    }
    // Если нет записи в таблице - тогда берем payment_account_id из запроса
    if(empty($this->payment_account_id)) {
      $this->payment_account_id = $request_account_id;

It seems like $request_account_id can also be of type string or array. However, the property $payment_account_id is declared as type integer. Maybe add an additional type check?

    }
    // Если у нас отличаются ИД аккаунта в запросе и ИД аккаунта в записи - тоже можно паниковать
    if($this->payment_account_id != $request_account_id) {
      // TODO - Поменять сообщение об ошибке
      throw new Exception(classLocale::$lang['pay_msg_request_user_invalid'], $this->retranslate_error(SN_PAYMENT_REQUEST_USER_NOT_FOUND, $options));
    }
    // Проверяем существование аккаунта с данным ИД
    if(!$this->account->db_get_by_id($this->payment_account_id)) {
      throw new Exception(classLocale::$lang['pay_msg_request_user_invalid'] . ' ID ' . $this->payment_account_id, $this->retranslate_error(SN_PAYMENT_REQUEST_USER_NOT_FOUND, $options));
    }

    // TODO Проверка на сервер_ид - как бы и не нужна, наверное?
    if(!empty($this->payment_params['server_id'])) {
      $this->request_server_id = sys_get_param_str($this->payment_params['server_id']);
      if(SN_ROOT_VIRTUAL != $this->request_server_id) {
        throw new Exception(classLocale::$lang['pay_msg_request_server_wrong'] . " {$this->request_server_id} вместо " . SN_ROOT_VIRTUAL, SN_PAYMENT_REQUEST_SERVER_WRONG);
      }
    }

    // Сверка количества оплаченной ММ с учётом бонусов
    if(!empty($this->payment_params['payment_dark_matter_gained'])) {

This code seems to be duplicated across your project.

      $request_mm_amount = sys_get_param_id($this->payment_params['payment_dark_matter_gained']);
      if($request_mm_amount != $this->payment_dark_matter_gained && $this->is_loaded) {
        throw new Exception(classLocale::$lang['pay_msg_mm_request_amount_invalid'] . " пришло {$request_mm_amount} ММ вместо {$this->payment_dark_matter_gained} ММ", SN_PAYMENT_REQUEST_MM_AMOUNT_INVALID);
      }
      empty($this->payment_dark_matter_gained) ? $this->payment_dark_matter_gained = $request_mm_amount : false;

It seems like $request_mm_amount can also be of type string or array. However, the property $payment_dark_matter_gained is declared as type integer. Maybe add an additional type check?

    }
    if(empty($this->payment_dark_matter_paid)) {

This if statement is empty and can be removed.

      // TODO - обратный расчёт из gained
    }

    // Проверка наличия внешнего ИД платежа
    if(!empty($this->payment_params['payment_external_id'])) {
      $request_payment_external_id = sys_get_param_id($this->payment_params['payment_external_id']);
      if(empty($request_payment_external_id)) {
        throw new exception(classLocale::$lang['pay_msg_request_payment_id_invalid'], SN_PAYMENT_REQUEST_EXTERNAL_ID_WRONG);
      } elseif(!empty($this->payment_external_id) && $this->payment_external_id != $request_payment_external_id) {
        // TODO - Может быть поменять сообщение
        throw new exception(classLocale::$lang['pay_msg_request_payment_id_invalid'], SN_PAYMENT_REQUEST_EXTERNAL_ID_WRONG);
      }
      $this->payment_external_id = $request_payment_external_id;

It seems like $request_payment_external_id can also be of type array or integer. However, the property $payment_external_id is declared as type string. Maybe add an additional type check?

    }
    // Сверка суммы, запрошенной СН к оплате
    if(!empty($this->payment_params['payment_external_money'])) {

This code seems to be duplicated across your project.

      $request_money_out = sys_get_param_float($this->payment_params['payment_external_money']);
      if($request_money_out != $this->payment_external_amount && $this->is_loaded) {
        throw new Exception(classLocale::$lang['pay_msg_request_payment_amount_invalid'] . " пришло {$request_money_out} денег вместо {$this->payment_external_amount} денег", SN_PAYMENT_REQUEST_CURRENCY_AMOUNT_INVALID);
      }
      empty($this->payment_external_amount) ? $this->payment_external_amount = $request_money_out : false;

The property $payment_external_amount was declared of type integer, but $request_money_out is of type double. Maybe add a type cast?

    }
    // Заполняем поле валюты платёжной системы
    if(!empty($this->payment_params['payment_external_currency'])) {
      $this->payment_external_currency = sys_get_param_str($this->payment_params['payment_external_currency']);
      if(empty($this->payment_external_currency)) {
        // TODO - поменять сообщение
        throw new Exception(classLocale::$lang['pay_msg_request_payment_amount_invalid'] . " {$this->payment_external_currency}", SN_PAYMENT_REQUEST_CURRENCY_AMOUNT_INVALID);
      }
    }
    if(empty($this->payment_external_currency)) {
      $this->payment_external_currency = $this->config['currency'];
    }

    // Заполнение внутренней суммы и валюты из внешних данных
    if(empty($this->payment_currency)) {
      $this->payment_currency = classSupernova::$config->payment_currency_default;
    }
    if(empty($this->payment_amount) && !empty($this->payment_external_currency)) {
      $this->payment_amount = self::currency_convert($this->payment_external_amount, $this->payment_external_currency, $this->payment_currency);

It seems like self::currency_convert($this->payment_external_amount, $this->payment_external_currency, $this->payment_currency) can also be of type double. However, the property $payment_amount is declared as type integer. Maybe add an additional type check?

    }

    // TODO - Тестовый режим
    if(!empty($this->payment_params['test'])) {
      $this->payment_test = $this->config['test'] || sys_get_param_int($this->payment_params['test']);

The property $payment_test was declared of type integer, but $this->config['test'] || sys_get_param_int($this->payment_params['test']) is of type boolean. Maybe add a type cast?

    }

    $this->generate_description();

//    // TODO - REMOVE

48% of this comment could be valid code. Did you maybe forget this after debugging?

//    return array(
//      'payer' => $this->account,
//    );
  }

  /**
   * Точка входа для коллбэка системы платежей - вызывается из <class_name>_response.php
   *
   * @return array
   */
  // OK 4.8
  // TODO - Здесь должно происходить разделение на resultURL, successURL, failURL
  public function payment_request_response() {
    $this->db = core_auth::$main_provider->db;
    $this->account = new Account($this->db);

    // TODO - REPLACE WITH INNATE CALL!
    sn_db_transaction_start();
    try {
      $response = $this->payment_request_process();
    } catch(Exception $e) {
      $response['result'] = $e->getCode();
      $response['message'] = $e->getMessage();
    }

    if($response['result'] == SN_PAYMENT_REQUEST_OK) {
      sn_db_transaction_commit();
      classSupernova::$debug->warning('Результат операции: код ' . $response['result'] . ' сообщение "' . $response['message'] . '"', 'Успешный платёж', LOG_INFO_PAYMENT);
    } else {
      sn_db_transaction_rollback();
      classSupernova::$debug->warning('Результат операции: код ' . $response['result'] . ' сообщение "' . $response['message'] . '"', 'Ошибка платежа', LOG_INFO_PAYMENT, true);
    }

    // Переводим код результата из СН в код платежной системы
    if(is_array($this->result_translations) && !empty($this->result_translations)) {
      $response['result'] = isset($this->result_translations[$response['result']]) ? $this->result_translations[$response['result']] : $this->result_translations[SN_PAYMENT_REQUEST_UNDEFINED_ERROR];
    }

    return $response;
  }


  // Function converts money values between currencies
  /**
   * Внутриигровая конвертация валют
   *
   * @param        $value
   * @param string $currency_from
   * @param string $currency_to
   * @param int    $round
   *
   * @return float|int
   */
  public static function currency_convert($value, $currency_from = '', $currency_to = '', $round = 2) {
    $currency_from = strtolower($currency_from);
    $currency_to = strtolower($currency_to);

    if($currency_from != $currency_to) {
      $exchange_from = get_exchange_rate($currency_from);
      $exchange_to = get_exchange_rate($currency_to);

      $value = $exchange_from ? $value / $exchange_from * $exchange_to * pow(10, $round) : 0;
      $value = ceil($value) / pow(10, $round);
    }

    return $value;
  }

  // Function calculates bonused DM amount for bulk purchase and ($direct = false) vice versa
  /**
   * Рассчёт бонуса ММ
   *
   * @param            $dark_matter
   * @param bool|true  $direct
   * @param bool|false $return_bonus
   *
   * @return float|int
   */
  public static function bonus_calculate($dark_matter, $direct = true, $return_bonus = false) {
    $bonus = 0;
    $dark_matter_new = $dark_matter;
    if(!empty(self::$bonus_table) && $dark_matter >= self::$bonus_table[0]) {
      if($direct) {
        foreach(self::$bonus_table as $dm_for_bonus => $multiplier) {
          if($dm_for_bonus <= $dark_matter) {

This code seems to be duplicated across your project.

            $dark_matter_new = $dark_matter * (1 + $multiplier);
            $bonus = $multiplier;
          } else {
            break;
          }
        }
      } else {
        foreach(self::$bonus_table as $dm_for_bonus => $multiplier) {
          $temp = $dm_for_bonus * (1 + $multiplier);
          if($dark_matter >= $temp) {

This code seems to be duplicated across your project.

            $dark_matter_new = round($dark_matter / (1 + $multiplier));
            $bonus = $multiplier;
          } else {
            break;
          }
        }
      }
    }

    return $return_bonus ? $bonus : $dark_matter_new;
  }

  // Дополнительная ре-трансляция адреса, если в каком-то случае платежная система ожидает нелогичный ответ
  // Пример: иксолла при неправильно заданном пользователе в ордере ожидает НЕПРАВИЛЬНЫЙ_ОРДЕР, а не НЕПРАВИЛЬНЫЙ_ПОЛЬЗОВАТЕЛЬ
  public function retranslate_error($error_code, $options = array()) {
    return isset($options['retranslate_error'][$error_code]) ? $options['retranslate_error'][$error_code] : $error_code;
  }


  public function db_insert() {
    $this->payment_test = !empty($this->config['test']) || $this->payment_test;

The property $payment_test was declared of type integer, but !empty($this->config['test']) || $this->payment_test is of type boolean. Maybe add a type cast?

    $payment = array(
      'payment_module_name' => $this->manifest['name'],

      'payment_status' => $this->payment_status,
      // 'payment_date' => $this->payment_date, // Не нужно

50% of this comment could be valid code. Did you maybe forget this after debugging?

      'payment_provider_id' => $this->payment_provider_id,
      'payment_account_id' => $this->payment_account_id,
      'payment_account_name' => $this->payment_account_name,
      'payment_user_id' => $this->payment_user_id,
      'payment_user_name' => $this->payment_user_name,

      'payment_dark_matter_paid' => $this->payment_dark_matter_paid,
      'payment_dark_matter_gained' => $this->payment_dark_matter_gained,

      'payment_amount' => $this->payment_amount,
      'payment_currency' => $this->payment_currency,

      'payment_external_id' => $this->payment_external_id, // TODO
      'payment_external_amount' => $this->payment_external_amount,
      'payment_external_currency' => $this->payment_external_currency,
      'payment_external_date' => $this->payment_external_date, // TODO

      'payment_test' => $this->payment_test ? 1 : 0, // Boolean -> int

      'payment_comment' => $this->description_generated[PAYMENT_DESCRIPTION_MAX],

      'payment_external_lots' => $this->payment_dark_matter_paid / get_mm_cost(),
    );

    $replace = false;
    if($this->payment_id) {
      $payment['payment_id'] = $this->payment_id;
      $replace = true;
    }

    $query = array();
    foreach($payment as $key => $value) {
      $value = is_string($value) ? '"' . db_escape($value) . '"' : $value;
      $query[] = "`{$key}` = {$value}";
    }

    $longQuery = ' INTO `{{payment}}` SET ' . implode(',', $query) . ';';
    if($replace) {
      $this->db->doReplace('REPLACE' . $longQuery);
    } else {
      $this->db->doInsert('INSERT' . $longQuery);
    }

    return $this->db_get_by_id($this->db->db_insert_id());
  }


  public function payment_adjust_mm_new() {
    if(!$this->payment_test) {
      // Not a test payment. Adding DM to account
      $this->account = new Account($this->db);
      $this->account->db_get_by_id($this->payment_account_id);
      $result = $this->account->metamatter_change(RPG_PURCHASE, $this->payment_dark_matter_gained, $this->payment_comment);
      if(!$result) {

The expression $result of type false|integer is loosely compared to false; this is ambiguous if the integer can be zero. You might want to explicitly use === null instead.

        throw new Exception('Ошибка начисления ММ', SN_METAMATTER_ERROR_ADJUST);
      }
    }
  }

  public function payment_cancel(&$payment) {

The parameter $payment is not used and could be removed.

    die('{НЕ РАБОТАЕТ! СООБЩИТЕ АДМИНИСТРАЦИИ!}');

    if(!isset($payment['payment_status'])) {

if (!isset($payment['payment_status'])) { throw new \exception(\classLocale::$lang['pay_msg_request_payment_not_found'], SN_PAYMENT_REQUEST_ORDER_NOT_FOUND); } does not seem to be reachable.

      throw new exception(classLocale::$lang['pay_msg_request_payment_not_found'], SN_PAYMENT_REQUEST_ORDER_NOT_FOUND);
    }

    if($payment['payment_status'] == PAYMENT_STATUS_COMPLETE) {
      $safe_comment = db_escape($payment['payment_comment'] = classLocale::$lang['pay_msg_request_payment_cancelled'] .' ' . $payment['payment_comment']);

      if(!$payment['payment_test']) {
        $result = $this->account->metamatter_change(RPG_PURCHASE_CANCEL, -$payment['payment_dark_matter_gained'], $payment['payment_comment']);
        if(!$result) {
          throw new exception('Ошибка начисления ММ', SN_METAMATTER_ERROR_ADJUST);
        }
      }
      $payment['payment_status'] = PAYMENT_STATUS_CANCELED;
      db_payment_update($payment, $safe_comment);
      throw new exception(classLocale::$lang['pay_msg_request_payment_cancel_complete'], SN_PAYMENT_REQUEST_OK);
    } elseif($payment['payment_status'] == PAYMENT_STATUS_CANCELED) {
      throw new exception(classLocale::$lang['pay_msg_request_payment_cancelled_already'], SN_PAYMENT_REQUEST_OK);
    } elseif($payment['payment_status'] == PAYMENT_STATUS_NONE) {
      throw new exception(classLocale::$lang['pay_msg_request_payment_cancel_not_complete'], SN_PAYMENT_REQUEST_PAYMENT_NOT_COMPLETE);
    }
  }


  protected function db_get_by_id($payment_id_unsafe) {
    $payment_id_internal_safe = $this->db->db_escape($payment_id_unsafe);
    $payment = $this->db->doSelectFetch(
      "SELECT * 
      FROM {{payment}} 
      WHERE 
        `payment_module_name` = '{$this->manifest['name']}' 
        AND 
        `payment_id` = '{$payment_id_internal_safe}' 
      LIMIT 1 
      FOR UPDATE;"
    );
    return $this->db_assign_payment($payment);
  }

  protected function db_complete_payment() {
    // TODO - поле payment_processed
    if($this->payment_status == PAYMENT_STATUS_NONE) {
      if(!defined('PAYMENT_EXPIRE_TIME') || PAYMENT_EXPIRE_TIME == 0 || empty($this->payment_date) || strtotime($this->payment_date) + PAYMENT_EXPIRE_TIME <= SN_TIME_NOW) {
        $this->payment_adjust_mm_new();
        $this->payment_status = PAYMENT_STATUS_COMPLETE;
      } else {
        $this->payment_status = PAYMENT_STATUS_EXPIRED;
      }

      $this->db_insert();
    }
  }

  protected function payment_reset() {
    $this->payment_id = 0;
    $this->payment_status = PAYMENT_STATUS_NONE;

    $this->payment_provider_id = ACCOUNT_PROVIDER_NONE;
    $this->payment_account_id = 0;
    $this->payment_account_name = '';
    $this->payment_user_id = 0;
    $this->payment_user_name = '';

    $this->payment_amount = 0;
    $this->payment_currency = '';

    $this->payment_dark_matter_paid = 0;
    $this->payment_dark_matter_gained = 0;
    $this->payment_date = SN_TIME_SQL;
    $this->payment_comment = '';
    $this->payment_module_name = '';

    $this->payment_external_id = '';
    $this->payment_external_date = '';
    $this->payment_external_lots = 0;
    $this->payment_external_amount = 0;
    $this->payment_external_currency = '';

    $this->payment_test = 0;

    $this->is_exists = false;
    $this->is_loaded = false;

    $this->description_generated = array();
  }

  protected function db_assign_payment($payment = null) {
    $this->payment_reset();

    if(is_array($payment) && isset($payment['payment_id'])) {
      $this->payment_id = $payment['payment_id'];
      $this->payment_status = $payment['payment_status'];
      $this->payment_date = $payment['payment_date'];

      $this->payment_provider_id = $payment['payment_provider_id'];
      $this->payment_account_id = $payment['payment_account_id'];
      $this->payment_account_name = $payment['payment_account_name'];
      $this->payment_user_id = $payment['payment_user_id'];
      $this->payment_user_name = $payment['payment_user_name'];

      $this->payment_amount = $payment['payment_amount'];
      $this->payment_currency = $payment['payment_currency'];

      $this->payment_dark_matter_paid = $payment['payment_dark_matter_paid'];
      $this->payment_dark_matter_gained = $payment['payment_dark_matter_gained'];

      $this->payment_comment = $payment['payment_comment'];
      $this->payment_module_name = $payment['payment_module_name'];

      $this->payment_external_id = $payment['payment_external_id'];
      $this->payment_external_date = $payment['payment_external_date'];
      $this->payment_external_lots = $payment['payment_external_lots'];
      $this->payment_external_amount = $payment['payment_external_amount'];
      $this->payment_external_currency = $payment['payment_external_currency'];

      $this->payment_test = $payment['payment_test'];

      $this->is_exists = true;
      $this->is_loaded = true;

      $this->generate_description();

      return true;
    } else {
      return false;
    }
  }

  protected function generate_description() {
    // TODO - системная локализация
    $this->description_generated = array(
      PAYMENT_DESCRIPTION_100 => substr("{$this->payment_dark_matter_gained} ММ аккаунт [{$this->account->account_name}] ID {$this->account->account_id} на " . SN_ROOT_VIRTUAL, 0, 100),
      PAYMENT_DESCRIPTION_250 => substr("Оплата {$this->payment_dark_matter_gained} ММ для аккаунта [{$this->payment_user_name}] ID {$this->payment_user_id} на сервере " . SN_ROOT_VIRTUAL, 0, 250),
      PAYMENT_DESCRIPTION_MAX => ($this->payment_test ? "ТЕСТОВЫЙ ПЛАТЕЖ! " : '') .
        "Платеж от аккаунта '{$this->payment_account_name}' ID {$this->payment_account_id} игрока '{$this->payment_user_name}' ID {$this->payment_user_id} на сервере " . SN_ROOT_VIRTUAL .
        " сумма {$this->payment_amount} {$this->payment_currency} за {$this->payment_dark_matter_paid} ММ (начислено {$this->payment_dark_matter_gained} ММ)" .
        " через '{$this->manifest['name']}' сумма {$this->payment_external_amount} {$this->payment_external_currency}",
    );
  }

}