sn_options_change_birthday()

Complexity

Conditions	9
Paths	18

Size

Total Lines	43
Code Lines	27

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
function sn_options_change_birthday($user) {
  $user_birthday = sys_get_param_str_unsafe('user_birthday');
  $FMT_DATE = preg_replace(array('/d/', '/m/', '/Y/'), array('DD', 'MM', 'YYYY'), FMT_DATE);

  if ($user['birthday'] || empty($user_birthday) || $user_birthday == $FMT_DATE) {
    return $user;
  }

  try {
    // Some black magic to parse any valid date format - those that contains all three "d", "m" and "Y" and any of the delimeters "\", "/", ".", "-"
    $pos['d'] = strpos(FMT_DATE, 'd');

$pos was never initialized. Although not strictly required by PHP, it is generally a good practice to add $pos = array(); before regardless.

    $pos['m'] = strpos(FMT_DATE, 'm');
    $pos['Y'] = strpos(FMT_DATE, 'Y');
    asort($pos);
    $i = 0;
    foreach ($pos as &$position) {
      $position = ++$i;
    }

    $regexp = "/" . preg_replace(array('/\\\\/', '/\//', '/\./', '/\-/', '/d/', '/m/', '/Y/'), array('\\\\\\', '\/', '\.', '\-', '(\d?\d)', '(\d?\d)', '(\d{4})'), FMT_DATE) . "/";
    if (!preg_match($regexp, $user_birthday, $match)) {
      throw new Exception();
    }

    if (!checkdate($match[$pos['m']], $match[$pos['d']], $match[$pos['Y']])) {
      throw new Exception();
    }

    $user_birthday_new_unescaped = "{$match[$pos['Y']]}-{$match[$pos['m']]}-{$match[$pos['d']]}";
    $user['user_birthday'] = $user_birthday_new_unescaped;
    // EOF black magic! Now we have valid SQL date in $user['user_birthday'] - independent of date format

    $year = date('Y', SN_TIME_NOW);
    if (mktime(0, 0, 0, $match[$pos['m']], $match[$pos['d']], $year) > SN_TIME_NOW) {

$year of type string is incompatible with the type integer expected by parameter $year of mktime().

      $year--;
    }
    $user['user_birthday_celebrated'] = "{$year}-{$match[$pos['m']]}-{$match[$pos['d']]}";
  } catch (exception $e) {
    $user['user_birthday'] = null;
    $user['user_birthday_celebrated'] = null;
  }

  return $user;
}