Pages\Deprecated\PageAdminUserView::viewStatic()

Complexity

Conditions	10
Paths	192

Size

Total Lines	63
Code Lines	40

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	110

Importance

Changes

0

<?php
  public static function viewStatic($template = null) {

The parameter $template is not used and could be removed.

    global $user;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

    define('IN_ADMIN', true);

    messageBoxAdminAccessDenied(AUTH_LEVEL_ADMINISTRATOR);

    $user_id = sys_get_param_id('uid');
    if (!($user_row = db_user_by_id($user_id))) {

It seems like $user_id can also be of type string; however, parameter $user_id_unsafe of db_user_by_id() does only seem to accept integer|array, maybe add an additional type check?

The function db_user_by_id() has been deprecated.

      messageBoxAdmin(sprintf(SN::$lang['adm_dm_user_none'], $user_id));
    }

    if (empty($user['authlevel']) || $user['authlevel'] <= $user_row['authlevel']) {
      messageBoxAdmin(SN::$lang['admin_title_access_denied']);
    }

    $account = new \Account();
    $account->dbGetByPlayerId($user_id);
    foreach ([
      'account_id',
      'account_name',
      'account_password',
      'account_salt',
      'account_email',
      'account_email_verified',
      'account_register_time',
      'account_language',
      'account_metamatter',
      'account_metamatter_total',
    ] as $accountField) {
      $user_row[$accountField] = $account->$accountField;
    }

    if (!empty($user_row['user_last_browser_id'])) {
      $temp = doquery("SELECT `browser_user_agent` FROM `{{security_browser}}` WHERE `browser_id` = {$user_row['user_last_browser_id']}", true);
      $user_row['browser_user_agent'] = $temp['browser_user_agent'];
    }

    foreach (self::$formats as $callable => $field_list) {
      foreach ($field_list as $field_name) {
        $user_row[$field_name] = call_user_func($callable, $user_row[$field_name]);
      }
    }

    $template = gettemplate('admin/admin_user', true);

true of type true is incompatible with the type null|template expected by parameter $template of gettemplate().

    $result = [
      'PAGE_HEADER' => "[{$user_row['id']}] {$user_row['username']}",
      'USER_ID'     => $user_row['id'],
    ];
    $exclude = $user_row;
    foreach (self::$blocks as $title => $fields) {
//      $template->assign_recursive(['.' => ['block' => [self::userBlockAssign($exclude, $title, $fields)]]]);

73% of this comment could be valid code. Did you maybe forget this after debugging?

      $result['.']['block'][] = self::userBlockAssign($exclude, $title, $fields);
    }

    if (!empty($exclude)) {
      $result['.']['block'][] = self::userBlockAssign($exclude, '!!! НЕИЗВЕСТНЫЕ ПАРАМЕТРЫ !!!', array_keys($exclude));
    }

    $template->assign_recursive($result);

    return $template;
  }