@@ -79,8 +79,7 @@ |
||
79 | 79 | |
80 | 80 | SN::db_transaction_commit(); |
81 | 81 | throw new Exception($info_action, ERR_NONE); |
82 | - } |
|
83 | - catch (Exception $e) |
|
82 | + } catch (Exception $e) |
|
84 | 83 | { |
85 | 84 | SN::db_transaction_rollback(); |
86 | 85 |
@@ -1,7 +1,6 @@ |
||
1 | 1 | <?php |
2 | 2 | |
3 | -function sn_user_birthday_celebrate() |
|
4 | -{ |
|
3 | +function sn_user_birthday_celebrate() { |
|
5 | 4 | global $config, $lang; |
6 | 5 | |
7 | 6 | SN::db_transaction_start(); |
@@ -74,14 +74,12 @@ discard block |
||
74 | 74 | doquery("UPDATE {{alliance}} SET " . implode(',', $ally_changeset) . " WHERE `id`='{$ally['id']}' LIMIT 1;"); |
75 | 75 | sys_redirect('alliance.php?mode=admin&edit=ally'); |
76 | 76 | } |
77 | -} |
|
78 | -elseif(sys_get_param_str('isSaveText')) |
|
77 | +} elseif(sys_get_param_str('isSaveText')) |
|
79 | 78 | { |
80 | 79 | $text = sys_get_param_str_both('text'); |
81 | 80 | doquery("UPDATE {{alliance}} SET `{$text_list[$allyTextID]['db_field']}`='{$text['safe']}' WHERE `id`='{$ally['id']}';"); |
82 | 81 | $ally[$text_list[$allyTextID]['db_field']] = $text['unsafe']; |
83 | -} |
|
84 | -elseif(sys_get_param_str('isTransfer') && $idNewLeader = sys_get_param_id('idNewLeader')) |
|
82 | +} elseif(sys_get_param_str('isTransfer') && $idNewLeader = sys_get_param_id('idNewLeader')) |
|
85 | 83 | { |
86 | 84 | if(!$isAllyOwner) |
87 | 85 | { |
@@ -98,8 +96,7 @@ discard block |
||
98 | 96 | SN::db_transaction_commit(); |
99 | 97 | sys_redirect('alliance.php'); |
100 | 98 | } |
101 | -} |
|
102 | -elseif(sys_get_param_str('isDisband') && sys_get_param_str('isConfirmDisband')) |
|
99 | +} elseif(sys_get_param_str('isDisband') && sys_get_param_str('isConfirmDisband')) |
|
103 | 100 | { |
104 | 101 | if(!$isAllyOwner) |
105 | 102 | { |
@@ -56,8 +56,7 @@ discard block |
||
56 | 56 | sprintf($lang['buddy_msg_accept_text'], $user['username'])); |
57 | 57 | SN::db_transaction_commit(); |
58 | 58 | throw new exception('buddy_err_accept_none', ERR_NONE); |
59 | - } |
|
60 | - else |
|
59 | + } else |
|
61 | 60 | { |
62 | 61 | throw new exception('buddy_err_accept_internal', ERR_ERROR); |
63 | 62 | } |
@@ -69,9 +68,11 @@ discard block |
||
69 | 68 | throw new exception('buddy_err_delete_alien', ERR_ERROR); |
70 | 69 | } |
71 | 70 | |
72 | - if($buddy_row['BUDDY_STATUS'] == BUDDY_REQUEST_ACTIVE) // Existing friendship |
|
71 | + if($buddy_row['BUDDY_STATUS'] == BUDDY_REQUEST_ACTIVE) { |
|
72 | + // Existing friendship |
|
73 | 73 | { |
74 | 74 | $ex_friend_id = $buddy_row['BUDDY_SENDER_ID'] == $user['id'] ? $buddy_row['BUDDY_OWNER_ID'] : $buddy_row['BUDDY_SENDER_ID']; |
75 | + } |
|
75 | 76 | |
76 | 77 | msg_send_simple_message($ex_friend_id, $user['id'], SN_TIME_NOW, MSG_TYPE_PLAYER, $user['username'], $lang['buddy_msg_unfriend_title'], |
77 | 78 | sprintf($lang['buddy_msg_unfriend_text'], $user['username'])); |
@@ -79,17 +80,19 @@ discard block |
||
79 | 80 | doquery("DELETE FROM {{buddy}} WHERE `BUDDY_ID` = {$buddy_id} LIMIT 1;"); |
80 | 81 | SN::db_transaction_commit(); |
81 | 82 | throw new exception('buddy_err_unfriend_none', ERR_NONE); |
82 | - } |
|
83 | - elseif($buddy_row['BUDDY_SENDER_ID'] == $user['id']) // Player's outcoming request - either denied or waiting |
|
83 | + } elseif($buddy_row['BUDDY_SENDER_ID'] == $user['id']) { |
|
84 | + // Player's outcoming request - either denied or waiting |
|
84 | 85 | { |
85 | 86 | doquery("DELETE FROM {{buddy}} WHERE `BUDDY_ID` = {$buddy_id} LIMIT 1;"); |
87 | + } |
|
86 | 88 | SN::db_transaction_commit(); |
87 | 89 | throw new exception('buddy_err_delete_own', ERR_NONE); |
88 | - } |
|
89 | - elseif($buddy_row['BUDDY_STATUS'] == BUDDY_REQUEST_WAITING) // Deny incoming request |
|
90 | + } elseif($buddy_row['BUDDY_STATUS'] == BUDDY_REQUEST_WAITING) { |
|
91 | + // Deny incoming request |
|
90 | 92 | { |
91 | 93 | msg_send_simple_message($buddy_row['BUDDY_SENDER_ID'], $user['id'], SN_TIME_NOW, MSG_TYPE_PLAYER, $user['username'], $lang['buddy_msg_deny_title'], |
92 | 94 | sprintf($lang['buddy_msg_deny_text'], $user['username'])); |
95 | + } |
|
93 | 96 | |
94 | 97 | doquery("UPDATE {{buddy}} SET `BUDDY_STATUS` = " . BUDDY_REQUEST_DENIED . " WHERE `BUDDY_ID` = {$buddy_id} LIMIT 1;"); |
95 | 98 | SN::db_transaction_commit(); |
@@ -104,8 +107,7 @@ discard block |
||
104 | 107 | if($new_friend_id = sys_get_param_id('request_user_id')) |
105 | 108 | { |
106 | 109 | $new_friend_row = db_user_by_id($new_friend_id, true, '`id`, `username`'); |
107 | - } |
|
108 | - elseif($new_friend_name = sys_get_param_str_unsafe('request_user_name')) |
|
110 | + } elseif($new_friend_name = sys_get_param_str_unsafe('request_user_name')) |
|
109 | 111 | { |
110 | 112 | $new_friend_row = db_user_by_username($new_friend_name); |
111 | 113 | $new_friend_name = SN::$db->db_escape($new_friend_name); |
@@ -138,8 +140,7 @@ discard block |
||
138 | 140 | SN::db_transaction_commit(); |
139 | 141 | throw new exception('buddy_err_adding_none', ERR_NONE); |
140 | 142 | } |
141 | -} |
|
142 | -catch(exception $e) |
|
143 | +} catch(exception $e) |
|
143 | 144 | { |
144 | 145 | $result[] = array( |
145 | 146 | 'STATUS' => in_array($e->getCode(), array(ERR_NONE, ERR_WARNING, ERR_ERROR)) ? $e->getCode() : ERR_ERROR, |
@@ -452,11 +452,13 @@ discard block |
||
452 | 452 | $location_info = &static::$location_info[$location_type]; |
453 | 453 | $id_field = $location_info[P_ID]; |
454 | 454 | $table_name = $location_info[P_TABLE_NAME]; |
455 | - if ($result = static::db_query_update("UPDATE {{{$table_name}}} SET {$set} WHERE `{$id_field}` = {$record_id}")) // TODO Как-то вернуть может быть LIMIT 1 ? |
|
455 | + if ($result = static::db_query_update("UPDATE {{{$table_name}}} SET {$set} WHERE `{$id_field}` = {$record_id}")) { |
|
456 | + // TODO Как-то вернуть может быть LIMIT 1 ? |
|
456 | 457 | { |
457 | 458 | if (static::$db->db_affected_rows()) { |
458 | 459 | // Обновляем данные только если ряд был затронут |
459 | 460 | DBStaticUnit::cache_clear(); |
461 | + } |
|
460 | 462 | } |
461 | 463 | } |
462 | 464 | |
@@ -486,9 +488,11 @@ discard block |
||
486 | 488 | $set = trim($set); |
487 | 489 | $table_name = static::$location_info[$location_type][P_TABLE_NAME]; |
488 | 490 | if ($result = static::db_query_insert("INSERT INTO `{{{$table_name}}}` SET {$set}")) { |
489 | - if (static::$db->db_affected_rows()) // Обновляем данные только если ряд был затронут |
|
491 | + if (static::$db->db_affected_rows()) { |
|
492 | + // Обновляем данные только если ряд был затронут |
|
490 | 493 | { |
491 | 494 | $record_id = SN::$db->db_insert_id(); |
495 | + } |
|
492 | 496 | // Вытаскиваем запись целиком, потому что в $set могли быть "данные по умолчанию" |
493 | 497 | $result = static::db_get_record_by_id($location_type, $record_id); |
494 | 498 | // Очищаем второстепенные кэши - потому что вставленная запись могла повлиять на результаты запросов или локация или еще чего |
@@ -508,10 +512,12 @@ discard block |
||
508 | 512 | $id_field = $location_info[P_ID]; |
509 | 513 | $table_name = $location_info[P_TABLE_NAME]; |
510 | 514 | if ($result = static::db_query_delete("DELETE FROM `{{{$table_name}}}` WHERE `{$id_field}` = {$safe_record_id}")) { |
511 | - if (static::$db->db_affected_rows()) // Обновляем данные только если ряд был затронут |
|
515 | + if (static::$db->db_affected_rows()) { |
|
516 | + // Обновляем данные только если ряд был затронут |
|
512 | 517 | { |
513 | 518 | DBStaticUnit::cache_clear(); |
514 | 519 | } |
520 | + } |
|
515 | 521 | } |
516 | 522 | |
517 | 523 | return $result; |
@@ -525,11 +531,13 @@ discard block |
||
525 | 531 | $table_name = static::$location_info[$location_type][P_TABLE_NAME]; |
526 | 532 | |
527 | 533 | if ($result = static::db_query_delete("DELETE FROM `{{{$table_name}}}` WHERE {$condition}")) { |
528 | - if (static::$db->db_affected_rows()) // Обновляем данные только если ряд был затронут |
|
534 | + if (static::$db->db_affected_rows()) { |
|
535 | + // Обновляем данные только если ряд был затронут |
|
529 | 536 | { |
530 | 537 | // Обнуление кэша, потому что непонятно, что поменялось |
531 | 538 | DBStaticUnit::cache_clear(); |
532 | 539 | } |
540 | + } |
|
533 | 541 | } |
534 | 542 | |
535 | 543 | return $result; |
@@ -141,11 +141,13 @@ discard block |
||
141 | 141 | if($deadlock && ($q = SN::$db->mysql_get_innodb_status())) { |
142 | 142 | $error_backtrace['deadlock'] = explode("\n", $q['Status']); |
143 | 143 | foreach($error_backtrace['cSN_data'] as &$location) { |
144 | - foreach($location as $location_id => &$location_data) // $location_data = $location_id; |
|
144 | + foreach($location as $location_id => &$location_data) { |
|
145 | + // $location_data = $location_id; |
|
145 | 146 | { |
146 | 147 | $location_data = isset($location_data['username']) ? $location_data['username'] : |
147 | 148 | (isset($location_data['name']) ? $location_data['name'] : $location_id); |
148 | 149 | } |
150 | + } |
|
149 | 151 | } |
150 | 152 | } |
151 | 153 | |
@@ -276,8 +278,7 @@ discard block |
||
276 | 278 | * |
277 | 279 | * @return void |
278 | 280 | */ |
279 | - function _writeLogMessage($httpCode, $user, $title, $message, array $error_backtrace, $fatal_error) |
|
280 | - { |
|
281 | + function _writeLogMessage($httpCode, $user, $title, $message, array $error_backtrace, $fatal_error) { |
|
281 | 282 | /** @noinspection SqlResolve */ |
282 | 283 | $query = "INSERT INTO `{{logs}}` SET |
283 | 284 | `log_time` = '" . time() . "', `log_code` = '" . SN::$db->db_escape($httpCode) . "', " . |