Test Failed
Push — trunk ( 769658...cc4c01 )
by SuperNova.WS
15:09
created
classes/SN.php 1 patch
Braces   +12 added lines, -4 removed lines patch added patch discarded remove patch
@@ -457,7 +457,8 @@  discard block
 block discarded – undo
457 457
     $location_info = &static::$location_info[$location_type];
458 458
     $id_field = $location_info[P_ID];
459 459
     $table_name = $location_info[P_TABLE_NAME];
460
-    if ($result = static::db_query_update("UPDATE {{{$table_name}}} SET {$set} WHERE `{$id_field}` = {$record_id}")) // TODO Как-то вернуть может быть LIMIT 1 ?
460
+    if ($result = static::db_query_update("UPDATE {{{$table_name}}} SET {$set} WHERE `{$id_field}` = {$record_id}")) {
461
+      // TODO Как-то вернуть может быть LIMIT 1 ?
461 462
     {
462 463
       if (static::$db->db_affected_rows()) {
463 464
         // Обновляем данные только если ряд был затронут
@@ -465,6 +466,7 @@  discard block
 block discarded – undo
465 466
 
466 467
         // Тут именно так, а не cache_unset - что бы в кэшах автоматически обновилась запись. Будет нужно на будущее
467 468
         _SnCacheInternal::$data[$location_type][$record_id] = null;
469
+    }
468 470
         // Вытаскиваем обновленную запись
469 471
         static::db_get_record_by_id($location_type, $record_id);
470 472
         _SnCacheInternal::cache_clear($location_type, false); // Мягкий сброс - только $queries
@@ -498,9 +500,11 @@  discard block
 block discarded – undo
498 500
     $set = trim($set);
499 501
     $table_name = static::$location_info[$location_type][P_TABLE_NAME];
500 502
     if ($result = static::db_query_insert("INSERT INTO `{{{$table_name}}}` SET {$set}")) {
501
-      if (static::$db->db_affected_rows()) // Обновляем данные только если ряд был затронут
503
+      if (static::$db->db_affected_rows()) {
504
+        // Обновляем данные только если ряд был затронут
502 505
       {
503 506
         $record_id = SN::$db->db_insert_id();
507
+      }
504 508
         // Вытаскиваем запись целиком, потому что в $set могли быть "данные по умолчанию"
505 509
         $result = static::db_get_record_by_id($location_type, $record_id);
506 510
         // Очищаем второстепенные кэши - потому что вставленная запись могла повлиять на результаты запросов или локация или еще чего
@@ -521,10 +525,12 @@  discard block
 block discarded – undo
521 525
     $id_field = $location_info[P_ID];
522 526
     $table_name = $location_info[P_TABLE_NAME];
523 527
     if ($result = static::db_query_delete("DELETE FROM `{{{$table_name}}}` WHERE `{$id_field}` = {$safe_record_id}")) {
524
-      if (static::$db->db_affected_rows()) // Обновляем данные только если ряд был затронут
528
+      if (static::$db->db_affected_rows()) {
529
+        // Обновляем данные только если ряд был затронут
525 530
       {
526 531
         _SnCacheInternal::cache_unset($location_type, $safe_record_id);
527 532
       }
533
+      }
528 534
     }
529 535
 
530 536
     return $result;
@@ -538,11 +544,13 @@  discard block
 block discarded – undo
538 544
     $table_name = static::$location_info[$location_type][P_TABLE_NAME];
539 545
 
540 546
     if ($result = static::db_query_delete("DELETE FROM `{{{$table_name}}}` WHERE {$condition}")) {
541
-      if (static::$db->db_affected_rows()) // Обновляем данные только если ряд был затронут
547
+      if (static::$db->db_affected_rows()) {
548
+        // Обновляем данные только если ряд был затронут
542 549
       {
543 550
         // Обнуление кэша, потому что непонятно, что поменялось
544 551
         _SnCacheInternal::cache_clear($location_type);
545 552
       }
553
+      }
546 554
     }
547 555
 
548 556
     return $result;
Please login to merge, or discard this patch.
classes/debug.php 1 patch
Braces   +4 added lines, -3 removed lines patch added patch discarded remove patch
@@ -143,11 +143,13 @@  discard block
 block discarded – undo
143 143
       $error_backtrace['locks'] = _SnCacheInternal::$locks;
144 144
       $error_backtrace['cSN_data'] = _SnCacheInternal::$data;
145 145
       foreach($error_backtrace['cSN_data'] as &$location) {
146
-        foreach($location as $location_id => &$location_data) //          $location_data = $location_id;
146
+        foreach($location as $location_id => &$location_data) {
147
+          //          $location_data = $location_id;
147 148
         {
148 149
           $location_data = isset($location_data['username']) ? $location_data['username'] :
149 150
             (isset($location_data['name']) ? $location_data['name'] : $location_id);
150 151
         }
152
+        }
151 153
       }
152 154
     }
153 155
 
@@ -278,8 +280,7 @@  discard block
 block discarded – undo
278 280
    *
279 281
    * @return void
280 282
    */
281
-  function _writeLogMessage($httpCode, $user, $title, $message, array $error_backtrace, $fatal_error)
282
-  {
283
+  function _writeLogMessage($httpCode, $user, $title, $message, array $error_backtrace, $fatal_error) {
283 284
     /** @noinspection SqlResolve */
284 285
     $query = "INSERT INTO `{{logs}}` SET
285 286
         `log_time` = '" . time() . "', `log_code` = '" . SN::$db->db_escape($httpCode) . "', " .
Please login to merge, or discard this patch.
includes/includes/uni_rename.php 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -49,8 +49,7 @@
 block discarded – undo
49 49
       SN::db_transaction_commit();
50 50
       sys_redirect("galaxy.php?mode=name&galaxy={$uni_galaxy}&system={$uni_system}");
51 51
     }
52
-  }
53
-  catch (exception $e)
52
+  } catch (exception $e)
54 53
   {
55 54
     SN::db_transaction_rollback();
56 55
     $template->assign_block_vars('result', array(
Please login to merge, or discard this patch.
includes/includes/market_info.inc 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -79,8 +79,7 @@
 block discarded – undo
79 79
 
80 80
     SN::db_transaction_commit();
81 81
     throw new Exception($info_action, ERR_NONE);
82
-  }
83
-  catch (Exception $e)
82
+  } catch (Exception $e)
84 83
   {
85 84
     SN::db_transaction_rollback();
86 85
 
Please login to merge, or discard this patch.
includes/includes/user_birthday_celebrate.php 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,7 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-function sn_user_birthday_celebrate()
4
-{
3
+function sn_user_birthday_celebrate() {
5 4
   global $config, $lang;
6 5
 
7 6
   SN::db_transaction_start();
Please login to merge, or discard this patch.
includes/alliance/ali_internal_admin.inc 1 patch
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -74,14 +74,12 @@  discard block
 block discarded – undo
74 74
     doquery("UPDATE {{alliance}} SET " . implode(',', $ally_changeset) . " WHERE `id`='{$ally['id']}' LIMIT 1;");
75 75
     sys_redirect('alliance.php?mode=admin&edit=ally');
76 76
   }
77
-}
78
-elseif(sys_get_param_str('isSaveText'))
77
+} elseif(sys_get_param_str('isSaveText'))
79 78
 {
80 79
   $text = sys_get_param_str_both('text');
81 80
   doquery("UPDATE {{alliance}} SET `{$text_list[$allyTextID]['db_field']}`='{$text['safe']}' WHERE `id`='{$ally['id']}';");
82 81
   $ally[$text_list[$allyTextID]['db_field']] = $text['unsafe'];
83
-}
84
-elseif(sys_get_param_str('isTransfer') && $idNewLeader = sys_get_param_id('idNewLeader'))
82
+} elseif(sys_get_param_str('isTransfer') && $idNewLeader = sys_get_param_id('idNewLeader'))
85 83
 {
86 84
   if(!$isAllyOwner)
87 85
   {
@@ -98,8 +96,7 @@  discard block
 block discarded – undo
98 96
     SN::db_transaction_commit();
99 97
     sys_redirect('alliance.php');
100 98
   }
101
-}
102
-elseif(sys_get_param_str('isDisband') && sys_get_param_str('isConfirmDisband'))
99
+} elseif(sys_get_param_str('isDisband') && sys_get_param_str('isConfirmDisband'))
103 100
 {
104 101
   if(!$isAllyOwner)
105 102
   {
Please login to merge, or discard this patch.
buddy.php 1 patch
Braces   +12 added lines, -11 removed lines patch added patch discarded remove patch
@@ -56,8 +56,7 @@  discard block
 block discarded – undo
56 56
             sprintf($lang['buddy_msg_accept_text'], $user['username']));
57 57
           SN::db_transaction_commit();
58 58
           throw new exception('buddy_err_accept_none', ERR_NONE);
59
-        }
60
-        else
59
+        } else
61 60
         {
62 61
           throw new exception('buddy_err_accept_internal', ERR_ERROR);
63 62
         }
@@ -69,9 +68,11 @@  discard block
 block discarded – undo
69 68
           throw new exception('buddy_err_delete_alien', ERR_ERROR);
70 69
         }
71 70
 
72
-        if($buddy_row['BUDDY_STATUS'] == BUDDY_REQUEST_ACTIVE) // Existing friendship
71
+        if($buddy_row['BUDDY_STATUS'] == BUDDY_REQUEST_ACTIVE) {
72
+          // Existing friendship
73 73
         {
74 74
           $ex_friend_id = $buddy_row['BUDDY_SENDER_ID'] == $user['id'] ? $buddy_row['BUDDY_OWNER_ID'] : $buddy_row['BUDDY_SENDER_ID'];
75
+        }
75 76
 
76 77
           msg_send_simple_message($ex_friend_id, $user['id'], SN_TIME_NOW, MSG_TYPE_PLAYER, $user['username'], $lang['buddy_msg_unfriend_title'],
77 78
             sprintf($lang['buddy_msg_unfriend_text'], $user['username']));
@@ -79,17 +80,19 @@  discard block
 block discarded – undo
79 80
           doquery("DELETE FROM {{buddy}} WHERE `BUDDY_ID` = {$buddy_id} LIMIT 1;");
80 81
           SN::db_transaction_commit();
81 82
           throw new exception('buddy_err_unfriend_none', ERR_NONE);
82
-        }
83
-        elseif($buddy_row['BUDDY_SENDER_ID'] == $user['id']) // Player's outcoming request - either denied or waiting
83
+        } elseif($buddy_row['BUDDY_SENDER_ID'] == $user['id']) {
84
+          // Player's outcoming request - either denied or waiting
84 85
         {
85 86
           doquery("DELETE FROM {{buddy}} WHERE `BUDDY_ID` = {$buddy_id} LIMIT 1;");
87
+        }
86 88
           SN::db_transaction_commit();
87 89
           throw new exception('buddy_err_delete_own', ERR_NONE);
88
-        }
89
-        elseif($buddy_row['BUDDY_STATUS'] == BUDDY_REQUEST_WAITING) // Deny incoming request
90
+        } elseif($buddy_row['BUDDY_STATUS'] == BUDDY_REQUEST_WAITING) {
91
+          // Deny incoming request
90 92
         {
91 93
           msg_send_simple_message($buddy_row['BUDDY_SENDER_ID'], $user['id'], SN_TIME_NOW, MSG_TYPE_PLAYER, $user['username'], $lang['buddy_msg_deny_title'],
92 94
             sprintf($lang['buddy_msg_deny_text'], $user['username']));
95
+        }
93 96
 
94 97
           doquery("UPDATE {{buddy}} SET `BUDDY_STATUS` = " . BUDDY_REQUEST_DENIED . " WHERE `BUDDY_ID` = {$buddy_id} LIMIT 1;");
95 98
           SN::db_transaction_commit();
@@ -104,8 +107,7 @@  discard block
 block discarded – undo
104 107
   if($new_friend_id = sys_get_param_id('request_user_id'))
105 108
   {
106 109
     $new_friend_row = db_user_by_id($new_friend_id, true, '`id`, `username`');
107
-  }
108
-  elseif($new_friend_name = sys_get_param_str_unsafe('request_user_name'))
110
+  } elseif($new_friend_name = sys_get_param_str_unsafe('request_user_name'))
109 111
   {
110 112
     $new_friend_row = db_user_by_username($new_friend_name);
111 113
     $new_friend_name = SN::$db->db_escape($new_friend_name);
@@ -138,8 +140,7 @@  discard block
 block discarded – undo
138 140
     SN::db_transaction_commit();
139 141
     throw new exception('buddy_err_adding_none', ERR_NONE);
140 142
   }
141
-}
142
-catch(exception $e)
143
+} catch(exception $e)
143 144
 {
144 145
   $result[] = array(
145 146
     'STATUS'  => in_array($e->getCode(), array(ERR_NONE, ERR_WARNING, ERR_ERROR)) ? $e->getCode() : ERR_ERROR,
Please login to merge, or discard this patch.