supernova-ws / SuperNova

classes/debug.php

Spacing +39 added lines, -40 removed lines

@@ -25,7 +25,7 @@ 
  * que esperabas!!! soy newbie!!! D':<
 */
 
-if(!defined('INSIDE')) {
+if (!defined('INSIDE')) {
   die("attemp hacking");
 }
 
@@ -84,8 +84,8 @@ 
     $result = array();
     $transaction_id = SN::db_transaction_check(false) ? SN::$transaction_id : SN::$transaction_id++;
     $result[] = "tID {$transaction_id}";
-    foreach($backtrace as $a_trace) {
-      if(in_array($a_trace['function'], $exclude_functions)) {
+    foreach ($backtrace as $a_trace) {
+      if (in_array($a_trace['function'], $exclude_functions)) {
         continue;
       }
       $function =
@@ -102,7 +102,7 @@ 
       $line = !empty($a_trace['line']) ? $a_trace['line'] : '_UNDEFINED_';
       $result[] = "{$function} - '{$file}' Line {$line}";
 
-      if(!$long_comment) {
+      if (!$long_comment) {
         break;
       }
     }
@@ -111,26 +111,26 @@ 
   }
 
   function dump($dump = false, $force_base = false, $deadlock = false) {
-    if($dump === false) {
+    if ($dump === false) {
       return [];
     }
 
     $error_backtrace = array();
     $base_dump = false;
 
-    if($force_base === true) {
+    if ($force_base === true) {
       $base_dump = true;
     }
 
-    if($dump === true) {
+    if ($dump === true) {
       $base_dump = true;
     } else {
-      if(!is_array($dump)) {
+      if (!is_array($dump)) {
         $dump = array('var' => $dump);
       }
 
-      foreach($dump as $dump_var_name => $dump_var) {
-        if($dump_var_name == 'base_dump') {
+      foreach ($dump as $dump_var_name => $dump_var) {
+        if ($dump_var_name == 'base_dump') {
           $base_dump = $dump_var;
         } else {
           $error_backtrace[$dump_var_name] = $dump_var;
@@ -138,24 +138,23 @@ 
       }
     }
 
-    if($deadlock && ($q = SN::$db->mysql_get_innodb_status())) {
+    if ($deadlock && ($q = SN::$db->mysql_get_innodb_status())) {
       $error_backtrace['deadlock'] = explode("\n", $q['Status']);
       $error_backtrace['locks'] = _SnCacheInternal::$locks;
       $error_backtrace['cSN_data'] = _SnCacheInternal::$data;
-      foreach($error_backtrace['cSN_data'] as &$location) {
-        foreach($location as $location_id => &$location_data) //          $location_data = $location_id;
+      foreach ($error_backtrace['cSN_data'] as &$location) {
+        foreach ($location as $location_id => &$location_data) //          $location_data = $location_id;
         {
-          $location_data = isset($location_data['username']) ? $location_data['username'] :
-            (isset($location_data['name']) ? $location_data['name'] : $location_id);
+          $location_data = isset($location_data['username']) ? $location_data['username'] : (isset($location_data['name']) ? $location_data['name'] : $location_id);
         }
       }
     }
 
-    if($base_dump) {
-      if(!is_array($this->log_array) || empty($this->log_array)) {
+    if ($base_dump) {
+      if (!is_array($this->log_array) || empty($this->log_array)) {
         $this->log_array = [];
       } else {
-        foreach($this->log_array as $log) {
+        foreach ($this->log_array as $log) {
           $error_backtrace['queries'][] = $log;
         }
       }
@@ -167,17 +166,17 @@ 
       // Converting object instances to object names
 
       foreach ($error_backtrace['backtrace'] as &$backtrace) {
-        if(is_object($backtrace['object'])) {
+        if (is_object($backtrace['object'])) {
           $backtrace['object'] = get_class($backtrace['object']);
         }
 
-        if(empty($backtrace['args'])) {
+        if (empty($backtrace['args'])) {
           continue;
         }
 
         // Doing same conversion for backtrace params
-        foreach($backtrace['args'] as &$arg) {
-          if(is_object($arg)) {
+        foreach ($backtrace['args'] as &$arg) {
+          if (is_object($arg)) {
             $arg = 'object::' . get_class($arg);
           }
         }
@@ -206,14 +205,14 @@ 
   function error($message = 'There is a error on page', $title = 'Internal Error', $httpCode = 500, $dump = true) {
     global $config, $sys_stop_log_hit, $lang, $sys_log_disabled, $user;
 
-    if(empty(SN::$db->connected)) {
+    if (empty(SN::$db->connected)) {
       // TODO - писать ошибку в файл
       die('SQL server currently unavailable. Please contact Administration...');
     }
 
     SN::db_transaction_rollback();
 
-    if(SN::$config->debug == 1) {
+    if (SN::$config->debug == 1) {
       /** @noinspection HtmlDeprecatedTag */
       /** @noinspection XmlDeprecatedElement */
       /** @noinspection HtmlDeprecatedAttribute */
@@ -226,7 +225,7 @@ 
     $error_text = SN::$db->db_escape($message);
     $error_backtrace = $this->dump($dump, true, strpos($message, 'Deadlock') !== false);
 
-    if(!$sys_log_disabled) {
+    if (!$sys_log_disabled) {
       $this->_writeLogMessage($httpCode, $user, $title, $message, $error_backtrace, $fatal_error);
 
       $message = "Пожалуйста, свяжитесь с админом, если ошибка повторится. Ошибка №: <b>" . SN::$db->db_insert_id() . "</b>";
@@ -239,7 +238,7 @@ 
       ob_start();
       print("<hr>User ID {$user['id']} raised error code {$httpCode} titled '{$title}' with text '{$error_text}' on page {$_SERVER['SCRIPT_NAME']}");
 
-      foreach($error_backtrace as $name => $value) {
+      foreach ($error_backtrace as $name => $value) {
         print('<hr>');
         pdump($value, $name);
       }
@@ -251,7 +250,7 @@ 
   function warning($message, $title = 'System Message', $httpCode = 300, $dump = false) {
     global $user, $lang, $sys_log_disabled;
 
-    if(empty(SN::$db->connected)) {
+    if (empty(SN::$db->connected)) {
       // TODO - писать ошибку в файл
       die('SQL server currently unavailable. Please contact Administration...');
     }
@@ -260,7 +259,7 @@ 
 
     $error_backtrace = $this->dump($dump, false);
 
-    if(empty($sys_log_disabled)) {
+    if (empty($sys_log_disabled)) {
       $this->_writeLogMessage($httpCode, $user, $title, $message, $error_backtrace, $fatal_error);
     } else {
 //        // TODO Здесь надо писать в файло
@@ -297,11 +296,11 @@ 
 // Dump variables nicer then var_dump()
 
 function dump($value, $varname = null, $level = 0, $dumper = '') {
-  if(isset($varname)) {
+  if (isset($varname)) {
     $varname .= " = ";
   }
 
-  if($level == -1) {
+  if ($level == -1) {
     $trans[' '] = '&there4;';
     $trans["\t"] = '&rArr;';
     $trans["\n"] = '&para;;';
@@ -310,7 +309,7 @@ 
 
     return strtr(htmlspecialchars($value), $trans);
   }
-  if($level == 0) {
+  if ($level == 0) {
 //    $dumper = '<pre>' . mt_rand(10, 99) . '|' . $varname;
     $dumper = mt_rand(10, 99) . '|' . $varname;
   }
@@ -318,22 +317,22 @@ 
   $type = gettype($value);
   $dumper .= $type;
 
-  if($type == 'string') {
+  if ($type == 'string') {
     $dumper .= '(' . strlen($value) . ')';
     $value = dump($value, '', -1);
-  } elseif($type == 'boolean') {
+  } elseif ($type == 'boolean') {
     $value = ($value ? 'true' : 'false');
-  } elseif($type == 'object') {
+  } elseif ($type == 'object') {
     $props = get_class_vars(get_class($value));
     $dumper .= '(' . count($props) . ') <u>' . get_class($value) . '</u>';
-    foreach($props as $key => $val) {
+    foreach ($props as $key => $val) {
       $dumper .= "\n" . str_repeat("\t", $level + 1) . $key . ' => ';
       $dumper .= dump($value->$key, '', $level + 1);
     }
     $value = '';
-  } elseif($type == 'array') {
+  } elseif ($type == 'array') {
     $dumper .= '(' . count($value) . ')';
-    foreach($value as $key => $val) {
+    foreach ($value as $key => $val) {
       $dumper .= "\n" . str_repeat("\t", $level + 1) . dump($key, '', -1) . ' => ';
       $dumper .= dump($val, '', $level + 1);
     }
@@ -353,7 +352,7 @@ 
 //  $backtrace = $backtrace[1];
 
   $caller = '';
-  if(defined('SN_DEBUG_PDUMP_CALLER') && SN_DEBUG_PDUMP_CALLER) {
+  if (defined('SN_DEBUG_PDUMP_CALLER') && SN_DEBUG_PDUMP_CALLER) {
     $caller = (!empty($backtrace[1]['class']) ? $backtrace[1]['class'] : '') .
       (!empty($backtrace[1]['type']) ? $backtrace[1]['type'] : '') .
       $backtrace[1]['function'] .
@@ -380,7 +379,7 @@ 
 }
 
 function pr($prePrint = false) {
-  if($prePrint) {
+  if ($prePrint) {
     print("<br>");
   }
   print(mt_rand() . "<br>");
@@ -390,7 +389,7 @@ 
   global $_PRINT_COUNT_VALUE;
   $_PRINT_COUNT_VALUE++;
 
-  if($prePrint) {
+  if ($prePrint) {
     print("<br>");
   }
   print($_PRINT_COUNT_VALUE . "<br>");

Braces +4 added lines, -3 removed lines

@@ -143,11 +143,13 @@ 
       $error_backtrace['locks'] = _SnCacheInternal::$locks;
       $error_backtrace['cSN_data'] = _SnCacheInternal::$data;
       foreach($error_backtrace['cSN_data'] as &$location) {
-        foreach($location as $location_id => &$location_data) //          $location_data = $location_id;
+        foreach($location as $location_id => &$location_data) {
+          //          $location_data = $location_id;
         {
           $location_data = isset($location_data['username']) ? $location_data['username'] :
             (isset($location_data['name']) ? $location_data['name'] : $location_id);
         }
+        }
       }
     }
 
@@ -278,8 +280,7 @@ 
    *
    * @return void
    */
-  function _writeLogMessage($httpCode, $user, $title, $message, array $error_backtrace, $fatal_error)
-  {
+  function _writeLogMessage($httpCode, $user, $title, $message, array $error_backtrace, $fatal_error) {
     /** @noinspection SqlResolve */
     $query = "INSERT INTO `{{logs}}` SET
         `log_time` = '" . time() . "', `log_code` = '" . SN::$db->db_escape($httpCode) . "', " .

classes/Template/TemplateMeta.php

Spacing +1 added lines, -1 removed lines

@@ -136,7 +136,7 @@
 //    var_dump($fallBackPath);
 //    var_dump($template);
 
-    if(empty($fallBackPath)) {
+    if (empty($fallBackPath)) {
       if (!$this->parent || empty($fallbackName = $this->parent->getName()) || !$this->isTemplateExists()) {
         // If no parent template - then using default template as fallback one
         $fallbackName = SnTemplate::SN_TEMPLATE_NAME_DEFAULT;

classes/classPersistent.php

Spacing +13 added lines, -13 removed lines

@@ -40,7 +40,7 @@ 
     $this->sql_index_field = "{$table_name}_name";
     $this->sql_value_field = "{$table_name}_value";
 
-    if(!$this->_DB_LOADED) {
+    if (!$this->_DB_LOADED) {
       $this->db_loadAll();
     }
   }
@@ -60,10 +60,10 @@ 
    */
   public function db_loadItem($index) {
     $result = null;
-    if($index) {
+    if ($index) {
       $index_safe = SN::$db->db_escape($index);
       $queryResult = doquery("SELECT `{$this->sql_value_field}` FROM `{{{$this->table_name}}}` WHERE `{$this->sql_index_field}` = '{$index_safe}' FOR UPDATE", true);
-      if(is_array($queryResult) && !empty($queryResult)) {
+      if (is_array($queryResult) && !empty($queryResult)) {
         $this->$index = $result = $queryResult[$this->sql_value_field];
       }
     }
@@ -75,7 +75,7 @@ 
     $this->loadDefaults();
 
     $query = doquery("SELECT * FROM {{{$this->table_name}}} FOR UPDATE;");
-    while($row = db_fetch($query)) {
+    while ($row = db_fetch($query)) {
       $this[$row[$this->sql_index_field]] = $row[$this->sql_value_field];
     }
 
@@ -83,7 +83,7 @@ 
   }
 
   public function loadDefaults() {
-    foreach($this->defaults as $defName => $defValue) {
+    foreach ($this->defaults as $defName => $defValue) {
       $this->$defName = $defValue;
     }
   }
@@ -93,7 +93,7 @@ 
   }
 
   public function db_saveItem($item_list, $value = NULL) {
-    if(empty($item_list)) {
+    if (empty($item_list)) {
       return;
     }
 
@@ -101,8 +101,8 @@ 
 
     // Сначала записываем данные в базу - что бы поймать все блокировки
     $qry = array();
-    foreach($item_list as $item_name => $item_value) {
-      if($item_name) {
+    foreach ($item_list as $item_name => $item_value) {
+      if ($item_name) {
         $item_value = SN::$db->db_escape($item_value === NULL ? $this->$item_name : $item_value);
         $item_name = SN::$db->db_escape($item_name);
         $qry[] = "('{$item_name}', '{$item_value}')";
@@ -111,8 +111,8 @@ 
     doquery("REPLACE INTO `{{" . $this->table_name . "}}` (`{$this->sql_index_field}`, `{$this->sql_value_field}`) VALUES " . implode(',', $qry) . ";");
 
     // И только после взятия блокировок - меняем значения в кэше
-    foreach($item_list as $item_name => $item_value) {
-      if($item_name && $item_value !== null) {
+    foreach ($item_list as $item_name => $item_value) {
+      if ($item_name && $item_value !== null) {
         $this->__set($item_name, $item_value);
       }
     }
@@ -140,14 +140,14 @@ 
   }
 
   public function __get($name) {
-    if($this->force) {
+    if ($this->force) {
       $this->force = false;
       $value = $this->db_loadItem($name);
     } else {
       $value = parent::__get($name);
     }
 
-    if(isset($this->notEmptyFields[$name]) && empty($value) && isset($this->defaults[$name])) {
+    if (isset($this->notEmptyFields[$name]) && empty($value) && isset($this->defaults[$name])) {
       $value = $this->defaults[$name];
     }
 
@@ -155,7 +155,7 @@ 
   }
 
   public function __set($name, $value) {
-    if($this->force) {
+    if ($this->force) {
       $this->force = false;
       $this->db_saveItem($name, $value);
     }

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -92,7 +92,7 @@ 
     $this->db_saveItem(array_combine(array_keys($this->defaults), array_fill(0, count($this->defaults), null)));
   }
 
-  public function db_saveItem($item_list, $value = NULL) {
+  public function db_saveItem($item_list, $value = null) {
     if(empty($item_list)) {
       return;
     }
@@ -103,7 +103,7 @@ 
     $qry = array();
     foreach($item_list as $item_name => $item_value) {
       if($item_name) {
-        $item_value = SN::$db->db_escape($item_value === NULL ? $this->$item_name : $item_value);
+        $item_value = SN::$db->db_escape($item_value === null ? $this->$item_name : $item_value);
         $item_name = SN::$db->db_escape($item_name);
         $qry[] = "('{$item_name}', '{$item_value}')";
       }

classes/DBAL/OldDbChangeSet.php

Spacing +1 added lines, -3 removed lines

@@ -142,9 +142,7 @@
           // Простое условие - $field_id = $field_value
           if (is_string($field_id)) {
             $field_value =
-              $field_value === null ? 'NULL' :
-                (is_string($field_value) ? "'" . SN::$db->db_escape($field_value) . "'" :
-                  (is_bool($field_value) ? intval($field_value) : $field_value));
+              $field_value === null ? 'NULL' : (is_string($field_value) ? "'" . SN::$db->db_escape($field_value) . "'" : (is_bool($field_value) ? intval($field_value) : $field_value));
             $the_conditions[] = "`{$field_id}` = {$field_value}";
           } else {
             die('Неподдерживаемый тип условия');

classes/DBAL/db_mysql.php

Spacing +2 added lines, -2 removed lines

@@ -224,7 +224,7 @@ 
 
     set_error_handler([$this, 'handlerQueryWarning']);
     $sqlquery = $this->db_sql_query($sql);
-    if(!$sqlquery) {
+    if (!$sqlquery) {
       $debug->error(SN::$db->db_error() . "<br />$sql<br />", 'SQL Error');
     }
     restore_error_handler();
@@ -396,7 +396,7 @@ 
     $q1 = $this->db_sql_query("SHOW INDEX FROM {$prefixedTableName_safe};");
     while ($r1 = db_fetch($q1)) {
       $indexName = $r1['Key_name'];
-      if(empty($result[$indexName])) {
+      if (empty($result[$indexName])) {
         $result[$indexName] = new DbIndexDescription();
       }
       $result[$indexName]->addField($r1);

classes/StatUpdateLauncher.php

Spacing +1 added lines, -1 removed lines

@@ -56,7 +56,7 @@
         $config->pass()->game_disable = GAME_DISABLE_STAT;
 
         $statMinimalInterval = intval($config->pass()->stats_minimal_interval);
-        $config->pass()->var_stat_update_end= date(FMT_DATE_TIME_SQL, SN_TIME_NOW + ($statMinimalInterval ? $statMinimalInterval : STATS_RUN_INTERVAL_MINIMUM));
+        $config->pass()->var_stat_update_end = date(FMT_DATE_TIME_SQL, SN_TIME_NOW + ($statMinimalInterval ? $statMinimalInterval : STATS_RUN_INTERVAL_MINIMUM));
         $config->pass()->var_stat_update_msg = 'Update started';
         SN::db_transaction_commit();
 

classes/SnTemplate.php

Spacing +5 added lines, -5 removed lines

@@ -128,7 +128,7 @@ 
         $insert_position = $is_positioned == '-' ? 0 : count($menu);
       }
 
-      $insert_position     += $is_positioned == '+' ? 1 : 0;
+      $insert_position += $is_positioned == '+' ? 1 : 0;
       $spliced             = array_splice($menu, $insert_position, count($menu) - $insert_position);
       $menu[$menu_item_id] = $menu_item;
 
@@ -648,7 +648,7 @@ 
       'LANG'     => $language ? $language : '',
       'referral' => $id_ref ? '&id_ref=' . $id_ref : '',
 
-      'REQUEST_PARAMS' => !empty($url_params) ? '?' . implode('&', $url_params) : '',// "?lang={$language}" . ($id_ref ? "&id_ref={$id_ref}" : ''),
+      'REQUEST_PARAMS' => !empty($url_params) ? '?' . implode('&', $url_params) : '', // "?lang={$language}" . ($id_ref ? "&id_ref={$id_ref}" : ''),
       'FILENAME'       => basename($_SERVER['PHP_SELF']),
     ));
 
@@ -836,7 +836,7 @@ 
       }
 
       $fleet_listx = flt_get_fleets_to_planet($CurPlanet);
-      if($CurPlanet['planet_type'] == PT_MOON) {
+      if ($CurPlanet['planet_type'] == PT_MOON) {
         $parentPlanet = DBStaticPlanet::db_planet_by_id($CurPlanet['parent_planet']);
       } else {
         $parentPlanet = $CurPlanet;
@@ -881,7 +881,7 @@ 
       'QUE_ID'   => QUE_RESEARCH,
       'QUE_HTML' => 'topnav',
 
-      'RESEARCH_ONGOING' => (boolean)$user['que'],
+      'RESEARCH_ONGOING' => (boolean) $user['que'],
 
       'TIME_TEXT'       => sprintf($str_date_format, $time_now_parsed['year'], $lang['months'][$time_now_parsed['mon']], $time_now_parsed['mday'],
         $time_now_parsed['hours'], $time_now_parsed['minutes'], $time_now_parsed['seconds']
@@ -1171,7 +1171,7 @@ 
       SnTemplate::renderFooter($page, $template_result);
     }
 
-    $user['authlevel'] >= 3 && $config->debug ? $debug->echo_log() : false;;
+    $user['authlevel'] >= 3 && $config->debug ? $debug->echo_log() : false; ;
 
     SN::$db->db_disconnect();
 

galaxy.php

Spacing +4 added lines, -4 removed lines

@@ -65,8 +65,8 @@ 
   $planet = $planetrow['planet'];
 }
 
-$uni_galaxy = (int)$uni_galaxy;
-$uni_system = (int)$uni_system;
+$uni_galaxy = (int) $uni_galaxy;
+$uni_system = (int) $uni_system;
 
 $uni_galaxy = $uni_galaxy < 1 ? 1 : ($uni_galaxy > SN::$config->game_maxGalaxy ? SN::$config->game_maxGalaxy : $uni_galaxy);
 $uni_system = $uni_system < 1 ? 1 : ($uni_system > SN::$config->game_maxSystem ? SN::$config->game_maxSystem : $uni_system);
@@ -131,7 +131,7 @@ 
     ||
     (!empty($uni_galaxyRowPlanet['destruyed']) && CheckAbandonPlanetState($uni_galaxyRowPlanet))
   ) {
-    $template->assign_block_vars('galaxyrow', ['PLANET_NUM' => $Planet,]);
+    $template->assign_block_vars('galaxyrow', ['PLANET_NUM' => $Planet, ]);
     continue;
   }
 
@@ -249,7 +249,7 @@ 
     'IS_CAPITAL'      => $uni_galaxyRowUser['id_planet'] == $uni_galaxyRowPlanet['id'],
 
     'USER_ID'         => $uni_galaxyRowUser['id'],
-    'USER_NAME'       => $renderedNick = player_nick_render_to_html($uni_galaxyRowUser, ['icons' => true,]),
+    'USER_NAME'       => $renderedNick = player_nick_render_to_html($uni_galaxyRowUser, ['icons' => true, ]),
     'USER_NAME_JS'    => js_safe_string($renderedNick),
     'USER_RANK'       => in_array($uni_galaxyRowUser['id'], $user_skip_list) ? '-' : $uni_galaxyRowUser['total_rank'],
     'USER_BANNED'     => $uni_galaxyRowUser['banaday'],

includes/db/db_helpers.php

Spacing +7 added lines, -7 removed lines

@@ -29,19 +29,19 @@ 
  */
 function db_set_make_safe_string($set, $delta = false) {
   $set_safe = array();
-  foreach($set as $field => $value) {
-    if(empty($field)) {
+  foreach ($set as $field => $value) {
+    if (empty($field)) {
       continue;
     }
 
     $field = '`' . SN::$db->db_escape($field) . '`';
     $new_value = $value;
-    if($value === null) {
+    if ($value === null) {
       $new_value = 'NULL';
-    } elseif(is_string($value) && (string)($new_value = floatval($value)) != (string)$value) {
+    } elseif (is_string($value) && (string) ($new_value = floatval($value)) != (string) $value) {
       // non-float
       $new_value = '"' . SN::$db->db_escape($value) . '"';
-    } elseif($delta) {
+    } elseif ($delta) {
       // float and DELTA-set
       $new_value = "{$field} + ({$new_value})";
     }
@@ -61,8 +61,8 @@ 
  */
 function missile_list_convert_to_fleet(&$missile_db_list, &$fleet_db_list) {
   // Missile attack
-  foreach($missile_db_list as $irak) {
-    if($irak['fleet_end_time'] >= SN_TIME_NOW) {
+  foreach ($missile_db_list as $irak) {
+    if ($irak['fleet_end_time'] >= SN_TIME_NOW) {
       $irak['fleet_start_type'] = PT_PLANET;
       $planet_start = DBStaticPlanet::db_planet_by_vector($irak, 'fleet_start_', false, 'name');
       $irak['fleet_id'] = -$irak['id'];