Core\Singleton::singleton()

Complexity

Conditions	2
Paths	2

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

0

<?php
  public static function singleton() {

Please use __construct() instead of a PHP4-style constructor that is named after the class.

    if (empty(static::$_singleton)) {

Since $_singleton is declared private, accessing it with static will lead to errors in possible sub-classes; you can either use self, or increase the visibility of $_singleton to at least protected.

      static::$_singleton = new static();
    }

    return static::$_singleton;
  }