Issues in alliance.php - New Issues - Inspection of "CODE-feat-41a6.65: Finally moved $config to proper..." - supernova-ws/SuperNova - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — work-fleets ( f5fbda...1bdd41 )

by SuperNova.WS

created 2016-03-26 21:31 UTC

alliance.php (1 issue)

Labels

Documentation 1

Severity

Informational 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

include('common.' . substr(strrchr(__FILE__, '.'), 1));

if(classSupernova::$config->game_mode == GAME_BLITZ) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
  message(classLocale::$lang['sys_blitz_page_disabled'], classLocale::$lang['sys_error'], 'overview.php', 10);
  die();
}

define('SN_IN_ALLY', true);

// Main admin page save themes
lng_include('alliance');

$mode = sys_get_param_str('mode');

if($mode == 'ainfo') {
  include('includes/alliance/ali_info.inc');
}

if(!$user['ally_id']) {
  $user_request = db_ally_request_get_by_user_id($user['id']);
  if($user_request['id_user']) {
    require('includes/alliance/ali_external_request.inc');
  } else {
    switch($mode) {
      case 'search':
        require('includes/alliance/ali_external_search.inc');
      break;

      case 'apply':
        require('includes/alliance/ali_external_request.inc');
      break;

      case 'make':
        require('includes/alliance/ali_external_create_ally.inc');
      break;

      default:
        display(parsetemplate(gettemplate('ali_external', true)), classLocale::$lang['alliance']);
      break;
    }
  }
}

sn_ali_fill_user_ally($user);
if(!isset($user['ally'])) {
  db_user_set_by_id($user['id'], "`ally_id` = null, `ally_name` = null, `ally_register_time` = 0, `ally_rank_id` = 0");
  message(classLocale::$lang['ali_sys_notFound'], classLocale::$lang['your_alliance'], 'alliance.php');
}
$ally = &$user['ally'];
/*
$ally_rights = array(
  0 => 'name',
  1 => 'mail',
  2 => 'online',
  3 => 'invite',
  4 => 'kick',
  5 => 'admin',
  6 => 'forum',
  7 => 'diplomacy'
);
*/
$rights_old = array(
  0 => 'name',
  1 => 'mails',
  2 => 'onlinestatus',
  3 => 'bewerbungenbearbeiten',
  4 => 'kick',
  5 => 'rechtehand'
);

// This piece converting old ally data to new one
//  unset($ally['ranklist']);
if(!$ally['ranklist'] && $ally['ally_ranks']) {
  $ally_ranks = unserialize($ally['ally_ranks']);
  $i = 0;
  foreach($ally_ranks as $rank_id => $rank) {
    foreach($ally_rights as $key => $value) {
      $ranks[$i][$value] = $rank[$rights_old[$key]];
    }
    db_user_list_set_ally_deprecated_convert_ranks($user['ally_id'], $i, $rank_id);
    $i++;
  }

  if(!empty($ranks)) {
    ali_rank_list_save($ranks);
  }
}

$ranks = ally_get_ranks($ally);

$isAllyOwner = $ally['ally_owner'] == $user['id'];
$user_can_send_mails = $ranks[$user['ally_rank_id']]['mail'] || $isAllyOwner;
$userCanPostForum = $ranks[$user['ally_rank_id']]['forum'] || $isAllyOwner;
$user_onlinestatus = $ranks[$user['ally_rank_id']]['online'] || $isAllyOwner;
$user_admin_applications = $ranks[$user['ally_rank_id']]['invite'] || $isAllyOwner;
$user_can_kick = $ranks[$user['ally_rank_id']]['kick'] || $isAllyOwner;
$user_can_negotiate = $ranks[$user['ally_rank_id']]['diplomacy'] || $isAllyOwner;
$user_can_edit_rights = $user_admin = $ranks[$user['ally_rank_id']]['admin'] || $isAllyOwner;

$edit = sys_get_param_str('edit');
ally_pre_call();
switch($mode) {
  case 'admin':
    if(!array_key_exists($edit, $sn_ali_admin_internal)) {
      $edit = 'default';
    }
    if($sn_ali_admin_internal[$edit]['include']) {
      require("includes/{$sn_ali_admin_internal[$edit]['include']}");
    }
    if(isset($sn_ali_admin_internal[$edit]['function']) && is_callable($sn_ali_admin_internal[$edit]['function'])) {
      call_user_func($sn_ali_admin_internal[$edit]['function']);
    }
  break;

  case 'memberslist':
    require('includes/alliance/ali_internal_members.inc');
  break;
  case 'circular':
    require('includes/alliance/ali_internal_admin_mail.inc');
  break;
  default:
    require('includes/alliance/ali_info.inc');
  break;
}

function ally_pre_call() {
  $func_args = func_get_args();

  return sn_function_call(__FUNCTION__, $func_args);
}


1		<?php
2
3		include('common.' . substr(strrchr(__FILE__, '.'), 1));
4
5	View Code Duplication	if(classSupernova::$config->game_mode == GAME_BLITZ) {
		0 ignored issues – show Documentation introduced 2016-03-26 21:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `game_mode` does not exist on `object<classConfig>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
6		message(classLocale::$lang['sys_blitz_page_disabled'], classLocale::$lang['sys_error'], 'overview.php', 10);
7		die();
8		}
9
10		define('SN_IN_ALLY', true);
11
12		// Main admin page save themes
13		lng_include('alliance');
14
15		$mode = sys_get_param_str('mode');
16
17		if($mode == 'ainfo') {
18		include('includes/alliance/ali_info.inc');
19		}
20
21		if(!$user['ally_id']) {
22		$user_request = db_ally_request_get_by_user_id($user['id']);
23		if($user_request['id_user']) {
24		require('includes/alliance/ali_external_request.inc');
25		} else {
26		switch($mode) {
27		case 'search':
28		require('includes/alliance/ali_external_search.inc');
29		break;
30
31		case 'apply':
32		require('includes/alliance/ali_external_request.inc');
33		break;
34
35		case 'make':
36		require('includes/alliance/ali_external_create_ally.inc');
37		break;
38
39		default:
40		display(parsetemplate(gettemplate('ali_external', true)), classLocale::$lang['alliance']);
41		break;
42		}
43		}
44		}
45
46		sn_ali_fill_user_ally($user);
47		if(!isset($user['ally'])) {
48		db_user_set_by_id($user['id'], "`ally_id` = null, `ally_name` = null, `ally_register_time` = 0, `ally_rank_id` = 0");
49		message(classLocale::$lang['ali_sys_notFound'], classLocale::$lang['your_alliance'], 'alliance.php');
50		}
51		$ally = &$user['ally'];
52		/*
53		$ally_rights = array(
54		0 => 'name',
55		1 => 'mail',
56		2 => 'online',
57		3 => 'invite',
58		4 => 'kick',
59		5 => 'admin',
60		6 => 'forum',
61		7 => 'diplomacy'
62		);
63		*/
64		$rights_old = array(
65		0 => 'name',
66		1 => 'mails',
67		2 => 'onlinestatus',
68		3 => 'bewerbungenbearbeiten',
69		4 => 'kick',
70		5 => 'rechtehand'
71		);
72
73		// This piece converting old ally data to new one
74		// unset($ally['ranklist']);
75		if(!$ally['ranklist'] && $ally['ally_ranks']) {
76		$ally_ranks = unserialize($ally['ally_ranks']);
77		$i = 0;
78		foreach($ally_ranks as $rank_id => $rank) {
79		foreach($ally_rights as $key => $value) {
80		$ranks[$i][$value] = $rank[$rights_old[$key]];
81		}
82		db_user_list_set_ally_deprecated_convert_ranks($user['ally_id'], $i, $rank_id);
83		$i++;
84		}
85
86		if(!empty($ranks)) {
87		ali_rank_list_save($ranks);
88		}
89		}
90
91		$ranks = ally_get_ranks($ally);
92
93		$isAllyOwner = $ally['ally_owner'] == $user['id'];
94		$user_can_send_mails = $ranks[$user['ally_rank_id']]['mail'] \|\| $isAllyOwner;
95		$userCanPostForum = $ranks[$user['ally_rank_id']]['forum'] \|\| $isAllyOwner;
96		$user_onlinestatus = $ranks[$user['ally_rank_id']]['online'] \|\| $isAllyOwner;
97		$user_admin_applications = $ranks[$user['ally_rank_id']]['invite'] \|\| $isAllyOwner;
98		$user_can_kick = $ranks[$user['ally_rank_id']]['kick'] \|\| $isAllyOwner;
99		$user_can_negotiate = $ranks[$user['ally_rank_id']]['diplomacy'] \|\| $isAllyOwner;
100		$user_can_edit_rights = $user_admin = $ranks[$user['ally_rank_id']]['admin'] \|\| $isAllyOwner;
101
102		$edit = sys_get_param_str('edit');
103		ally_pre_call();
104		switch($mode) {
105		case 'admin':
106		if(!array_key_exists($edit, $sn_ali_admin_internal)) {
107		$edit = 'default';
108		}
109		if($sn_ali_admin_internal[$edit]['include']) {
110		require("includes/{$sn_ali_admin_internal[$edit]['include']}");
111		}
112		if(isset($sn_ali_admin_internal[$edit]['function']) && is_callable($sn_ali_admin_internal[$edit]['function'])) {
113		call_user_func($sn_ali_admin_internal[$edit]['function']);
114		}
115		break;
116
117		case 'memberslist':
118		require('includes/alliance/ali_internal_members.inc');
119		break;
120		case 'circular':
121		require('includes/alliance/ali_internal_admin_mail.inc');
122		break;
123		default:
124		require('includes/alliance/ali_info.inc');
125		break;
126		}
127
128		function ally_pre_call() {
129		$func_args = func_get_args();
130
131		return sn_function_call(__FUNCTION__, $func_args);
132		}
133

supernova-ws / SuperNova

Push — work-fleets ( f5fbda...1bdd41 )

alliance.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like