Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 13 | class ContainerArrayOfObject extends ArrayAccessV2 { |
||
| 14 | |||
| 15 | /** |
||
| 16 | * Automatically apply all non-exist function from static::$_call list to $_container content |
||
| 17 | * |
||
| 18 | * @param string $method_name |
||
| 19 | * @param array $arguments |
||
| 20 | */ |
||
| 21 | View Code Duplication | public function __call($method_name, array $arguments) { |
|
| 28 | |||
| 29 | /** |
||
| 30 | * Summarize property values of contained objects |
||
| 31 | * |
||
| 32 | * @param string $property_name |
||
| 33 | * |
||
| 34 | * @return float |
||
| 35 | */ |
||
| 36 | public function getSumProperty($property_name) { |
||
| 46 | |||
| 47 | /** |
||
| 48 | * Aggregate value of $property_name in containing object by $method_name |
||
| 49 | * |
||
| 50 | * @param string $method_name |
||
| 51 | * |
||
| 52 | * @return mixed |
||
| 53 | */ |
||
| 54 | View Code Duplication | public function aggregateByMethod($method_name, &$result) { |
|
| 61 | |||
| 62 | } |
||
| 63 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.