DbRowSimple - Code Metrics - Inspection of "CODE-misc-41a50.68: Testing different uses of DI C..." - supernova-ws/SuperNova - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — work-fleets ( dea33d...b19a67 )

by SuperNova.WS

created 2016-07-26 16:45 UTC

DbRowSimple A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	62
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
c	3
b	0
f	0
dl	0
loc	62
rs	10
wmc	6
lcom	0
cbo	3

3 Methods

Rating	Name	Size	Complexity
A	getById()	11	1
A	deleteById()	7	1
B	insert()	26	4

<?php

class DbRowSimple {

  /**
   * @param Entity $object
   * @param mixed  $rowId
   *
   * @return Entity
   */
  public function getById($object, $rowId) {
    $stmt = classSupernova::$gc->query

      ->setIdField($object::$idField)
      ->field('*')
      ->from($object::$tableName)
      ->where($object::$idField . ' = "' . $rowId . '"');

    $object->setRow($stmt->selectRow());

    return $object;
  }

  /**
   * @param Entity $object
   */
  public function deleteById($object) {
    $db = classSupernova::$gc->db;

    $db->doquery("DELETE FROM `{{" . $object::$tableName . "}}` WHERE `{$object::$idField}` = '{$object->getDbId()}' LIMIT 1;");
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

    return $db->db_affected_rows();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
  }

  /**
   * @param Entity $object
   */
  public function insert($object) {
    $db = classSupernova::$gc->db;

    $query = array();
    foreach ($object->getRow() as $fieldName => $fieldValue) {
      if($fieldName == $object::$idField) {
        continue;
      }
      $fieldValue = $db->db_escape($fieldValue);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
      $query[] = "`{$fieldName}` = '{$fieldValue}'";
    }

    $query = implode(',', $query);
    if (empty($query)) {
      // TODO Exceptiion
      return 0;
    }

    $db->doquery("INSERT INTO `{{" . $object::$tableName . "}}` SET " . $query);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

    // TODO Exceptiion if db_insert_id() is empty
    $dbId = $db->db_insert_id();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    $object->setDbId($dbId);

    return $dbId;
  }

}


Push — work-fleets ( dea33d...b19a67 )

DbRowSimple A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			class DbRowSimple {
4
5			/**
6			* @param Entity $object
7			* @param mixed $rowId
8			*
9			* @return Entity
10			*/
11			public function getById($object, $rowId) {
12			$stmt = classSupernova::$gc->query
			0 ignored issues – show Bug introduced 2016-07-25 19:14 UTC by Report Bug Copy Issue Report The method `setIdField` cannot be called on `\classSupernova::$gc->query` (of type `callable`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
13			->setIdField($object::$idField)
14			->field('*')
15			->from($object::$tableName)
16			->where($object::$idField . ' = "' . $rowId . '"');
17
18			$object->setRow($stmt->selectRow());
19
20			return $object;
21			}
22
23			/**
24			* @param Entity $object
25			*/
26			public function deleteById($object) {
27			$db = classSupernova::$gc->db;
28
29			$db->doquery("DELETE FROM `{{" . $object::$tableName . "}}` WHERE `{$object::$idField}` = '{$object->getDbId()}' LIMIT 1;");
			0 ignored issues – show Bug introduced 2016-07-26 16:51 UTC by Report Bug Copy Issue Report The method `doquery` does only exist in `db_mysql`, but not in `Closure`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
30
31			return $db->db_affected_rows();
			0 ignored issues – show Bug introduced 2016-07-26 16:51 UTC by Report Bug Copy Issue Report The method `db_affected_rows` does only exist in `db_mysql`, but not in `Closure`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
32			}
33
34			/**
35			* @param Entity $object
36			*/
37			public function insert($object) {
38			$db = classSupernova::$gc->db;
39
40			$query = array();
41			foreach ($object->getRow() as $fieldName => $fieldValue) {
42			if($fieldName == $object::$idField) {
43			continue;
44			}
45			$fieldValue = $db->db_escape($fieldValue);
			0 ignored issues – show Bug introduced 2016-07-26 16:51 UTC by Report Bug Copy Issue Report The method `db_escape` does only exist in `db_mysql`, but not in `Closure`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
46			$query[] = "`{$fieldName}` = '{$fieldValue}'";
47			}
48
49			$query = implode(',', $query);
50			if (empty($query)) {
51			// TODO Exceptiion
52			return 0;
53			}
54
55			$db->doquery("INSERT INTO `{{" . $object::$tableName . "}}` SET " . $query);
			0 ignored issues – show Bug introduced 2016-07-26 16:51 UTC by Report Bug Copy Issue Report The method `doquery` does only exist in `db_mysql`, but not in `Closure`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
56
57			// TODO Exceptiion if db_insert_id() is empty
58			$dbId = $db->db_insert_id();
			0 ignored issues – show Bug introduced 2016-07-26 16:51 UTC by Report Bug Copy Issue Report The method `db_insert_id` does only exist in `db_mysql`, but not in `Closure`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
59			$object->setDbId($dbId);
60
61			return $dbId;
62			}
63
64			}
65

supernova-ws / SuperNova

Push — work-fleets ( dea33d...b19a67 )

DbRowSimple A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like