sn_module - Code Metrics - Inspection of "CODE-feat-41a6.35: Module config now can be stored..." - supernova-ws/SuperNova - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — work-fleets ( 070fe2...d6c2ef )

by SuperNova.WS

created 2016-03-25 18:45 UTC

sn_module C

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	247
Duplicated Lines	6.48 %

Coupling/Cohesion

Components	2
Dependencies	0

Importance

Changes	4
Bugs	0	Features	0

Metric	Value
wmc	58
c	4
b	0
f	0
lcom	2
cbo	0
dl	16
loc	247
rs	6.3005

6 Methods

Rating	Name	Duplication	Size	Complexity
B	__assign_vars()	0	25	1
A	loadModuleRootConfig()	0	13	3
B	__construct()	0	29	6
B	__patch_menu()	0	7	5
F	initialize()	16	105	42
A	check_status()	0	2	1

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like sn_module often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use sn_module, and based on these observations, apply Extract Interface, too.

<?php

class sn_module {
  public $manifest = array(
    'package' => 'core',
    'name' => 'sn_module',
    'version' => '1c0',
    'copyright' => 'Project "SuperNova.WS" #41a6.35# copyright © 2009-2014 Gorlum',

//    'require' => null,

    'root_relative' => '',

    'installed' => true,
    'active' => true,

    // 'constants' array - contents of this array would be instaled into engine
    'constants' => array(
//      'UNIT_STRUCTURE_NEW' => 999999,

    ),

    'vars' => array(), // Just a placeholder. vars assigned via special method __assign_vars(). Need 'cause of new constants that can be defined within module. See below

    // 'functions' array - this functions would be installed as hooks
    // Key: overwritable function name to replace
    // Value: which method to use. Format: [*][<object_name>][.]<method>
    // '*' means that new function would replace old one
    // If object_name is ommited but "." is present - hook linked to global function
    // If only "method" present - overwritable linked to appropriate method of current object
    // Function/Method should be accessible on module init
    'functions' => array(
//      'test_object_test_method' => 'test_object.test_method',

//      'test_function' => '.my_test_function',
//      'this_object_test_method' => 'test_method',
    ),

    // 'menu' array - this menu items would be merged into main game menu
    // Array element almost identical to $sn_menu with additional param 'LOCATION'.
    // 'LOCATION' => '-news', // Special atrtribute for modules

    // [-|+][<menu_item_id>]

    // <menu_item_id> identifies menu item aginst new menu item would be placed. When ommited new item placed against whole menu
    // -/+ indicates that new item should be placed before/after identified menu item (or whole menu). If ommited and menu item exists - new item will replace previous one
    // Empty or non-existent LOCATION equivalent to '+' - place item at end of menu
    // Non-existent menu_item_id treated as ommited
    'menu' => array(),

    // 'page' array - defines pages which will handle this module and appropriate handlers
    'page' => array(),
  );

  protected $config = array();

  protected $module_full_class_path = __FILE__;

  /**
   * Динамическое назначение переменных
   *
   * Актуально, когда записываемые данные зависят от статуса игры
   * Например - назначаются константы внутри модуля
   *
   * @return array
   */
  function __assign_vars() {

    return array(
/*

      'sn_data' => array(
        UNIT_STRUCTURE_NEW => array( // Will honor new constants
          'name' => 'robot_factory',
          'type' => UNIT_STRUCTURE,
          'location' => LOC_PLANET,
          'cost' => array(
            RES_METAL     => 400,
            RES_CRYSTAL   => 120,
            RES_DEUTERIUM => 200,
            RES_ENERGY    => 0,
            'factor' => 2,
          ),
          'metal' => 400,
          'crystal' => 120,
          'deuterium' => 200,
          'energy' => 0,
          'factor' => 2,
        ),
      ),
*/
    );
  }

  function loadModuleRootConfig() {

    static $i;

    require SN_ROOT_PHYSICAL . 'config.php';

    $module_config_array = get_class($this) . '_config';
    if(!empty($$module_config_array) && is_array($$module_config_array)) {
      $this->config = $$module_config_array;
      return true;
    }

    return false;
  }

  function __construct($filename = __FILE__) {

    global $sn_module;

    // Getting module PHP class name
    $class_module_name = get_class($this);

    // Getting module root relative to SN
    $this->manifest['root_relative'] = str_replace(array(SN_ROOT_PHYSICAL, basename($filename)), '', str_replace('\\', '/', $filename));

    // TODO: Load configuration from DB. Manifest setting
    // Trying to load configuration from file
    if(!$config_exists = $this->loadModuleRootConfig()) {
      // Конфигурация может лежать в config_path в манифеста или в корне модуля
      if(isset($this->manifest['config_path']) && file_exists($config_filename = $this->manifest['config_path'] . '/config.php')) {
        $config_exists = true;
      } elseif(file_exists($config_filename = dirname($filename) . '/config.php')) {
        $config_exists = true;
      }

      if($config_exists) {
        include($config_filename);
        $module_config_array = $class_module_name . '_config';
        $this->config = $$module_config_array;
      }
    }

    // Registering module
    $sn_module[$class_module_name] = $this;
  }

  protected function __patch_menu(&$sn_menu_extra, &$menu_patch) {
    if(isset($menu_patch) && is_array($menu_patch) && !empty($menu_patch)) {
      foreach($menu_patch as $menu_item_name => $menu_item_data) {
        $sn_menu_extra[$menu_item_name] = $menu_item_data;
      }
    }
  }


  public function initialize() {
    // Checking module status - is it installed and active
    $this->check_status();
    if(!$this->manifest['active']) {
      return;
    }

    // Setting constants - if any
    if(isset($this->manifest['constants']) && is_array($this->manifest['constants']) && !empty($this->manifest['constants'])) {
      foreach($this->manifest['constants'] as $constant_name => $constant_value) {
        defined($constant_name) or define($constant_name, $constant_value);
      }
    }

    // Adding vars - if any
    // Due to possible introduce of new constants in previous step vars is assigned via special method to honor new constants
    // Assignation can work with simple variables and with multidimensional arrays - for ex. 'sn_data[groups][test]'
    // New values from module variables will overwrite previous values (for root variables) and array elements with corresponding indexes (for arrays)
    // Constants as array indexes are honored - it's make valid such declarations as 'sn_data[ques][QUE_STRUCTURES]'
    $this->manifest['vars'] = $this->__assign_vars();
    if(!empty($this->manifest['vars'])) {
      $vars_assigned = array();
      foreach($this->manifest['vars'] as $var_name => $var_value) {
        $sub_vars = explode('[', str_replace(']', '', $var_name));
        $var_name = $sub_vars[0];

        if(!isset($vars_assigned[$var_name])) {
          $vars_assigned[$var_name] = true;
          global $$var_name;
        }

        $pointer = &$$var_name;
        if(($n = count($sub_vars)) > 1) {
          for($i = 1; $i < $n; $i++) {
            if(defined($sub_vars[$i])) {
              $sub_vars[$i] = constant($sub_vars[$i]);
            }

            if(!isset($pointer[$sub_vars[$i]]) && $i != $n) {
              $pointer[$sub_vars[$i]] = array();
            }
            $pointer = &$pointer[$sub_vars[$i]];
          }
        }

        if(!isset($pointer) || !is_array($pointer)) {
          $pointer = $var_value;
        } elseif(is_array($$var_name)) {
          $pointer = array_merge_recursive_numeric($pointer, $var_value);
        }
      }
    }

    // Overriding function if any
    global $functions;
    sn_sys_handler_add($functions, $this->manifest['functions'], $this);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

    // Patching game menu - if any
    global $sn_menu_extra, $sn_menu_admin_extra;
    isset($this->manifest['menu']) and $this->__patch_menu($sn_menu_extra, $this->manifest['menu']);
    isset($this->manifest['menu_admin']) and $this->__patch_menu($sn_menu_admin_extra, $this->manifest['menu_admin']);

    global $sn_mvc;
    foreach($sn_mvc as $handler_type => &$handler_data) {
      sn_sys_handler_add($handler_data, $this->manifest['mvc'][$handler_type], $this, $handler_type);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    if(isset($this->manifest['i18n']) && is_array($this->manifest['i18n']) && !empty($this->manifest['i18n'])) {
      foreach($this->manifest['i18n'] as $i18n_page_name => &$i18n_file_list) {
        foreach($i18n_file_list as &$i18n_file_data) {
          if(is_array($i18n_file_data) && !$i18n_file_data['path']) {
            $i18n_file_data['path'] = $this->manifest['root_relative'];
          }
        }
        if(!isset($sn_mvc['i18n'][$i18n_page_name])) {
          $sn_mvc['i18n'][$i18n_page_name] = array();
        }
        $sn_mvc['i18n'][$i18n_page_name] += $i18n_file_list;
      }
    }

    if(!empty($this->manifest['javascript']) && is_array($this->manifest['javascript'])) {

      foreach($this->manifest['javascript'] as $javascript_page_name => &$javascript_list) {
        !isset($sn_mvc['javascript'][$javascript_page_name]) ? $sn_mvc['javascript'][$javascript_page_name] = array() : false;
        foreach($javascript_list as $script_name => &$script_content) {
          $sn_mvc['javascript'][$javascript_page_name][$script_name] = $script_content;
        }
      }
    }

    if(!empty($this->manifest['css']) && is_array($this->manifest['css'])) {

      foreach($this->manifest['css'] as $javascript_page_name => &$javascript_list) {
        !isset($sn_mvc['css'][$javascript_page_name]) ? $sn_mvc['css'][$javascript_page_name] = array() : false;
        foreach($javascript_list as $script_name => &$script_content) {
          $sn_mvc['css'][$javascript_page_name][$script_name] = $script_content;
        }
      }
    }

    if(!empty($this->manifest['navbar_prefix_button']) && is_array($this->manifest['navbar_prefix_button'])) {
      foreach($this->manifest['navbar_prefix_button'] as $button_image => $button_url_relative) {
        $sn_mvc['navbar_prefix_button'][$button_image] = $button_url_relative;
      }
    }
  }

  function check_status() {

  }
}



1		<?php
2
3		class sn_module {
4		public $manifest = array(
5		'package' => 'core',
6		'name' => 'sn_module',
7		'version' => '1c0',
8		'copyright' => 'Project "SuperNova.WS" #41a6.35# copyright © 2009-2014 Gorlum',
9
10		// 'require' => null,
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-03-23 16:50 UTC by Report Bug Copy Issue Report `43%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
11		'root_relative' => '',
12
13		'installed' => true,
14		'active' => true,
15
16		// 'constants' array - contents of this array would be instaled into engine
17		'constants' => array(
18		// 'UNIT_STRUCTURE_NEW' => 999999,
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-03-23 16:50 UTC by Report Bug Copy Issue Report `58%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
19		),
20
21		'vars' => array(), // Just a placeholder. vars assigned via special method __assign_vars(). Need 'cause of new constants that can be defined within module. See below
22
23		// 'functions' array - this functions would be installed as hooks
24		// Key: overwritable function name to replace
25		// Value: which method to use. Format: [*][<object_name>][.]<method>
26		// '*' means that new function would replace old one
27		// If object_name is ommited but "." is present - hook linked to global function
28		// If only "method" present - overwritable linked to appropriate method of current object
29		// Function/Method should be accessible on module init
30		'functions' => array(
31		// 'test_object_test_method' => 'test_object.test_method',
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-03-23 16:50 UTC by Report Bug Copy Issue Report `53%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
32		// 'test_function' => '.my_test_function',
33		// 'this_object_test_method' => 'test_method',
34		),
35
36		// 'menu' array - this menu items would be merged into main game menu
37		// Array element almost identical to $sn_menu with additional param 'LOCATION'.
38		// 'LOCATION' => '-news', // Special atrtribute for modules
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-03-23 16:50 UTC by Report Bug Copy Issue Report `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
39		// [-\|+][<menu_item_id>]
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-03-23 16:50 UTC by Report Bug Copy Issue Report `46%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
40		// <menu_item_id> identifies menu item aginst new menu item would be placed. When ommited new item placed against whole menu
41		// -/+ indicates that new item should be placed before/after identified menu item (or whole menu). If ommited and menu item exists - new item will replace previous one
42		// Empty or non-existent LOCATION equivalent to '+' - place item at end of menu
43		// Non-existent menu_item_id treated as ommited
44		'menu' => array(),
45
46		// 'page' array - defines pages which will handle this module and appropriate handlers
47		'page' => array(),
48		);
49
50		protected $config = array();
51
52		protected $module_full_class_path = __FILE__;
53
54		/**
55		* Динамическое назначение переменных
56		*
57		* Актуально, когда записываемые данные зависят от статуса игры
58		* Например - назначаются константы внутри модуля
59		*
60		* @return array
61		*/
62		function __assign_vars() {
		0 ignored issues – show Best Practice introduced 2016-03-23 16:50 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
63		return array(
64		/*
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-03-23 16:50 UTC by Report Bug Copy Issue Report `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
65		'sn_data' => array(
66		UNIT_STRUCTURE_NEW => array( // Will honor new constants
67		'name' => 'robot_factory',
68		'type' => UNIT_STRUCTURE,
69		'location' => LOC_PLANET,
70		'cost' => array(
71		RES_METAL => 400,
72		RES_CRYSTAL => 120,
73		RES_DEUTERIUM => 200,
74		RES_ENERGY => 0,
75		'factor' => 2,
76		),
77		'metal' => 400,
78		'crystal' => 120,
79		'deuterium' => 200,
80		'energy' => 0,
81		'factor' => 2,
82		),
83		),
84		*/
85		);
86		}
87
88		function loadModuleRootConfig() {
		0 ignored issues – show Best Practice introduced 2016-03-25 18:51 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
89		static $i;
90
91		require SN_ROOT_PHYSICAL . 'config.php';
92
93		$module_config_array = get_class($this) . '_config';
94		if(!empty($$module_config_array) && is_array($$module_config_array)) {
95		$this->config = $$module_config_array;
96		return true;
97		}
98
99		return false;
100		}
101
102		function __construct($filename = __FILE__) {
		0 ignored issues – show Best Practice introduced 2016-03-23 16:50 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
103		global $sn_module;
104
105		// Getting module PHP class name
106		$class_module_name = get_class($this);
107
108		// Getting module root relative to SN
109		$this->manifest['root_relative'] = str_replace(array(SN_ROOT_PHYSICAL, basename($filename)), '', str_replace('\\', '/', $filename));
110
111		// TODO: Load configuration from DB. Manifest setting
112		// Trying to load configuration from file
113		if(!$config_exists = $this->loadModuleRootConfig()) {
114		// Конфигурация может лежать в config_path в манифеста или в корне модуля
115		if(isset($this->manifest['config_path']) && file_exists($config_filename = $this->manifest['config_path'] . '/config.php')) {
116		$config_exists = true;
117		} elseif(file_exists($config_filename = dirname($filename) . '/config.php')) {
118		$config_exists = true;
119		}
120
121		if($config_exists) {
122		include($config_filename);
123		$module_config_array = $class_module_name . '_config';
124		$this->config = $$module_config_array;
125		}
126		}
127
128		// Registering module
129		$sn_module[$class_module_name] = $this;
130		}
131
132		protected function __patch_menu(&$sn_menu_extra, &$menu_patch) {
133		if(isset($menu_patch) && is_array($menu_patch) && !empty($menu_patch)) {
134		foreach($menu_patch as $menu_item_name => $menu_item_data) {
135		$sn_menu_extra[$menu_item_name] = $menu_item_data;
136		}
137		}
138		}
139
140
141		public function initialize() {
142		// Checking module status - is it installed and active
143		$this->check_status();
144		if(!$this->manifest['active']) {
145		return;
146		}
147
148		// Setting constants - if any
149		if(isset($this->manifest['constants']) && is_array($this->manifest['constants']) && !empty($this->manifest['constants'])) {
150		foreach($this->manifest['constants'] as $constant_name => $constant_value) {
151		defined($constant_name) or define($constant_name, $constant_value);
152		}
153		}
154
155		// Adding vars - if any
156		// Due to possible introduce of new constants in previous step vars is assigned via special method to honor new constants
157		// Assignation can work with simple variables and with multidimensional arrays - for ex. 'sn_data[groups][test]'
158		// New values from module variables will overwrite previous values (for root variables) and array elements with corresponding indexes (for arrays)
159		// Constants as array indexes are honored - it's make valid such declarations as 'sn_data[ques][QUE_STRUCTURES]'
160		$this->manifest['vars'] = $this->__assign_vars();
161		if(!empty($this->manifest['vars'])) {
162		$vars_assigned = array();
163		foreach($this->manifest['vars'] as $var_name => $var_value) {
164		$sub_vars = explode('[', str_replace(']', '', $var_name));
165		$var_name = $sub_vars[0];
166
167		if(!isset($vars_assigned[$var_name])) {
168		$vars_assigned[$var_name] = true;
169		global $$var_name;
170		}
171
172		$pointer = &$$var_name;
173		if(($n = count($sub_vars)) > 1) {
174		for($i = 1; $i < $n; $i++) {
175		if(defined($sub_vars[$i])) {
176		$sub_vars[$i] = constant($sub_vars[$i]);
177		}
178
179		if(!isset($pointer[$sub_vars[$i]]) && $i != $n) {
180		$pointer[$sub_vars[$i]] = array();
181		}
182		$pointer = &$pointer[$sub_vars[$i]];
183		}
184		}
185
186		if(!isset($pointer) \|\| !is_array($pointer)) {
187		$pointer = $var_value;
188		} elseif(is_array($$var_name)) {
189		$pointer = array_merge_recursive_numeric($pointer, $var_value);
190		}
191		}
192		}
193
194		// Overriding function if any
195		global $functions;
196		sn_sys_handler_add($functions, $this->manifest['functions'], $this);
		0 ignored issues – show Documentation introduced 2016-03-23 16:50 UTC by Report Bug Copy Issue Report `$this` is of type `this<sn_module>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
197
198		// Patching game menu - if any
199		global $sn_menu_extra, $sn_menu_admin_extra;
200		isset($this->manifest['menu']) and $this->__patch_menu($sn_menu_extra, $this->manifest['menu']);
201		isset($this->manifest['menu_admin']) and $this->__patch_menu($sn_menu_admin_extra, $this->manifest['menu_admin']);
202
203		global $sn_mvc;
204		foreach($sn_mvc as $handler_type => &$handler_data) {
205		sn_sys_handler_add($handler_data, $this->manifest['mvc'][$handler_type], $this, $handler_type);
		0 ignored issues – show Documentation introduced 2016-03-23 16:50 UTC by Report Bug Copy Issue Report `$this` is of type `this<sn_module>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
206		}
207
208		if(isset($this->manifest['i18n']) && is_array($this->manifest['i18n']) && !empty($this->manifest['i18n'])) {
209		foreach($this->manifest['i18n'] as $i18n_page_name => &$i18n_file_list) {
210		foreach($i18n_file_list as &$i18n_file_data) {
211		if(is_array($i18n_file_data) && !$i18n_file_data['path']) {
212		$i18n_file_data['path'] = $this->manifest['root_relative'];
213		}
214		}
215		if(!isset($sn_mvc['i18n'][$i18n_page_name])) {
216		$sn_mvc['i18n'][$i18n_page_name] = array();
217		}
218		$sn_mvc['i18n'][$i18n_page_name] += $i18n_file_list;
219		}
220		}
221
222	View Code Duplication	if(!empty($this->manifest['javascript']) && is_array($this->manifest['javascript'])) {
		0 ignored issues – show Duplication introduced 2016-03-23 18:43 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
223		foreach($this->manifest['javascript'] as $javascript_page_name => &$javascript_list) {
224		!isset($sn_mvc['javascript'][$javascript_page_name]) ? $sn_mvc['javascript'][$javascript_page_name] = array() : false;
225		foreach($javascript_list as $script_name => &$script_content) {
226		$sn_mvc['javascript'][$javascript_page_name][$script_name] = $script_content;
227		}
228		}
229		}
230
231	View Code Duplication	if(!empty($this->manifest['css']) && is_array($this->manifest['css'])) {
		0 ignored issues – show Duplication introduced 2016-03-23 18:43 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
232		foreach($this->manifest['css'] as $javascript_page_name => &$javascript_list) {
233		!isset($sn_mvc['css'][$javascript_page_name]) ? $sn_mvc['css'][$javascript_page_name] = array() : false;
234		foreach($javascript_list as $script_name => &$script_content) {
235		$sn_mvc['css'][$javascript_page_name][$script_name] = $script_content;
236		}
237		}
238		}
239
240		if(!empty($this->manifest['navbar_prefix_button']) && is_array($this->manifest['navbar_prefix_button'])) {
241		foreach($this->manifest['navbar_prefix_button'] as $button_image => $button_url_relative) {
242		$sn_mvc['navbar_prefix_button'][$button_image] = $button_url_relative;
243		}
244		}
245		}
246
247		function check_status() {
		0 ignored issues – show Best Practice introduced 2016-03-23 16:50 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
248		}
249		}
250
251

supernova-ws / SuperNova