supernova-ws /
SuperNova
| Conditions | 4 |
| Paths | 8 |
| Total Lines | 51 |
| Code Lines | 21 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 0 |
| CRAP Score | 20 |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 44 | public static function DeleteSelectedUser($UserID) { |
||
| 45 | $internalTransaction = false; |
||
| 46 | if (!sn_db_transaction_check(false)) { |
||
| 47 | sn_db_transaction_start(); |
||
| 48 | |||
| 49 | $internalTransaction = true; |
||
| 50 | } |
||
| 51 | |||
| 52 | $TheUser = db_user_by_id($UserID); |
||
|
Deprecated Code
introduced
by
|
|||
| 53 | |||
| 54 | if (!empty($TheUser['ally_id'])) { |
||
| 55 | $TheAlly = doquery("SELECT * FROM `{{alliance}}` WHERE `id` = '" . $TheUser['ally_id'] . "';", '', true); |
||
| 56 | $TheAlly['ally_members'] -= 1; |
||
| 57 | doquery("UPDATE `{{alliance}}` SET `ally_members` = '" . $TheAlly['ally_members'] . "' WHERE `id` = '" . $TheAlly['id'] . "';"); |
||
| 58 | |||
| 59 | // if ( $TheAlly['ally_members'] > 0 ) { |
||
| 60 | // doquery ( "UPDATE `{{alliance}}` SET `ally_members` = '" . $TheAlly['ally_members'] . "' WHERE `id` = '" . $TheAlly['id'] . "';"); |
||
| 61 | // } else { |
||
| 62 | // doquery ( "DELETE FROM `{{alliance}}` WHERE `id` = '" . $TheAlly['id'] . "';"); |
||
| 63 | // doquery ( "DELETE FROM `{{statpoints}}` WHERE `stat_type` = '2' AND `id_owner` = '" . $TheAlly['id'] . "';"); |
||
| 64 | // } |
||
| 65 | } |
||
| 66 | |||
| 67 | // Deleting all fleets |
||
| 68 | db_fleet_list_delete_by_owner($UserID); |
||
| 69 | |||
| 70 | // Deleting all planets |
||
| 71 | DBStaticPlanet::db_planet_list_delete_by_owner($UserID); |
||
| 72 | |||
| 73 | // TEMPORARY player messages not deleted |
||
| 74 | // doquery("DELETE FROM `{{messages}}` WHERE `message_sender` = '" . $UserID . "';"); |
||
| 75 | // doquery("DELETE FROM `{{messages}}` WHERE `message_owner` = '" . $UserID . "';"); |
||
| 76 | |||
| 77 | doquery("DELETE FROM `{{notes}}` WHERE `owner` = '" . $UserID . "';"); |
||
| 78 | |||
| 79 | doquery("DELETE FROM `{{buddy}}` WHERE `BUDDY_SENDER_ID` = '" . $UserID . "';"); |
||
| 80 | doquery("DELETE FROM `{{buddy}}` WHERE `BUDDY_OWNER_ID` = '" . $UserID . "';"); |
||
| 81 | |||
| 82 | doquery("DELETE FROM `{{referrals}}` WHERE (`id` = '{$UserID}') OR (`id_partner` = '{$UserID}');"); |
||
| 83 | |||
| 84 | doquery("DELETE FROM `{{statpoints}}` WHERE `stat_type` = '1' AND `id_owner` = '" . $UserID . "';"); |
||
| 85 | |||
| 86 | // Deleting all units |
||
| 87 | SN::db_del_record_list(LOC_UNIT, "`unit_location_type` = " . LOC_PLAYER . " AND `unit_player_id` = " . $UserID); |
||
| 88 | |||
| 89 | // Deleting player's record |
||
| 90 | SN::db_del_record_by_id(LOC_USER, $UserID); |
||
| 91 | SN::$config->pass()->users_amount = SN::$config->pass()->users_amount - 1; |
||
| 92 | |||
| 93 | if ($internalTransaction) { |
||
| 94 | sn_db_transaction_commit(); |
||
| 95 | } |
||
| 99 |
Loading history...