DeleteSelectedUser() - Code Metrics - Inspection of "DOC-43a15.8: Changelog editing" - supernova-ws/SuperNova - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — trunk ( 1c4b6b...c0c172 )

by SuperNova.WS

created 2018-03-21 03:16 UTC

DeleteSelectedUser() B

↳ Parent: Project

Complexity

Conditions	3
Paths	3

Size

Total Lines	34
Code Lines	24

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	24
nc	3
nop	1
dl	0
loc	34
rs	8.8571
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
B	sys_admin_player_ban()	0	24	3

<?php
/**
 * Created by PhpStorm.
 * User: Gorlum
 * Date: 17.04.2015
 * Time: 6:37
 */

function sys_user_vacation($user) {
  global $config;
function myFunction($a, $b) {
    // Do something
}

  if(sys_get_param_str('vacation') == 'leave') {
    if ($user['vacation'] < SN_TIME_NOW) {
      $user['vacation'] = 0;
      $user['vacation_next'] = SN_TIME_NOW + $config->player_vacation_timeout;
      db_user_set_by_id($user['id'], "`vacation` = {$user['vacation']}, `vacation_next` = {$user['vacation_next']}");
      /** @scrutinizer ignore-deprecated */ db_user_set_by_id($user['id'], "`vacation` = {$user['vacation']}, `vacation_next` = {$user['vacation_next']}");
    }
  }

  if($user['vacation']) {
    // sn_sys_logout(false, true);

    // core_auth::logout(false, true);


    $template = gettemplate('vacation', true);
    $template = gettemplate('vacation', /** @scrutinizer ignore-type */ true);

    $template->assign_vars(array(
      'MENU' => false,
      'NAVBAR' => false,

      'NAME' => $user['username'],
      'VACATION_END' => date(FMT_DATE_TIME, $user['vacation']),
      'CAN_LEAVE' => $user['vacation'] <= SN_TIME_NOW,
      'RANDOM' => mt_rand(1, 2),
    ));

    display($template);
  }

  return false;
}

function sys_is_multiaccount($user1, $user2) {
  global $config;
function myFunction($a, $b) {
    // Do something
}

  return $user1['user_lastip'] == $user2['user_lastip'] && !$config->game_multiaccount_enabled;
}

/**
 * @param        $banner
 * @param        $banned
 * @param        $term
 * @param bool   $is_vacation
 * @param string $reason
 */
function sys_admin_player_ban($banner, $banned, $term, $is_vacation = true, $reason = '') {
  $ban_current = db_user_by_id($banned['id'], false, 'banaday');
  $ban_current = /** @scrutinizer ignore-deprecated */ db_user_by_id($banned['id'], false, 'banaday');
  $ban_until = ($ban_current['banaday'] ? $ban_current['banaday'] : SN_TIME_NOW) + $term;

  db_user_set_by_id($banned['id'], "`banaday` = {$ban_until} " . ($is_vacation ? ", `vacation` = '{$ban_until}' " : ''));
  /** @scrutinizer ignore-deprecated */ db_user_set_by_id($banned['id'], "`banaday` = {$ban_until} " . ($is_vacation ? ", `vacation` = '{$ban_until}' " : ''));

  $banned['username'] = db_escape($banned['username']);
  $banner['username'] = db_escape($banner['username']);
  doquery(
    "INSERT INTO
      {{banned}}
    SET
      `ban_user_id` = '{$banned['id']}',
      `ban_user_name` = '{$banned['username']}',
      `ban_reason` = '{$reason}',
      `ban_time` = " . SN_TIME_NOW . ",
      `ban_until` = {$ban_until},
      `ban_issuer_id` = '{$banner['id']}',
      `ban_issuer_name` = '{$banner['username']}',
      `ban_issuer_email` = '{$banner['email']}'
  ");

  DBStaticPlanet::db_planet_set_by_owner($banned['id'],
    "`metal_mine_porcent` = 0, `crystal_mine_porcent` = 0, `deuterium_sintetizer_porcent` = 0, `solar_plant_porcent` = 0,
    `fusion_plant_porcent` = 0, `solar_satelit_porcent` = 0, `ship_sattelite_sloth_porcent` = 0"
  );
}

/**
 * @param        $banner
 * @param        $banned
 * @param string $reason
 */
function sys_admin_player_ban_unset($banner, $banned, $reason = '') {
  db_user_set_by_id($banned['id'], "`banaday` = 0, `vacation` = " . SN_TIME_NOW . "");
  /** @scrutinizer ignore-deprecated */ db_user_set_by_id($banned['id'], "`banaday` = 0, `vacation` = " . SN_TIME_NOW . "");

  $banned['username'] = db_escape($banned['username']);
  $banner['username'] = db_escape($banner['username']);
  $reason = db_escape($reason);
  doquery(
    "INSERT INTO {{banned}}
    SET
      `ban_user_id` = '{$banned['id']}',
      `ban_user_name` = '{$banned['username']}',
      `ban_reason` = '{$reason}',
      `ban_time` = 0,
      `ban_until` = " . SN_TIME_NOW . ",
      `ban_issuer_id` = '{$banner['id']}',
      `ban_issuer_name` = '{$banner['username']}',
      `ban_issuer_email` = '{$banner['email']}'
  ");
}

function player_create($username_unsafe, $email_unsafe, $options) {
  sn_db_transaction_check(true);

  global $config, $lang;
function myFunction($a, $b) {
    // Do something
}

  static $player_options_string = 'opt_mnl_spy^1|opt_email_mnl_spy^0|opt_email_mnl_joueur^0|opt_email_mnl_alliance^0|opt_mnl_attaque^1|opt_email_mnl_attaque^0|opt_mnl_exploit^1|opt_email_mnl_exploit^0|opt_mnl_transport^1|opt_email_mnl_transport^0|opt_email_msg_admin^1|opt_mnl_expedition^1|opt_email_mnl_expedition^0|opt_mnl_buildlist^1|opt_email_mnl_buildlist^0|opt_int_navbar_resource_force^1|';

  empty($options['planet_options']) ? $options['planet_options'] = array() : false;

  $field_set = array(
    'server_name' => SN_ROOT_VIRTUAL,
    'register_time' => SN_TIME_NOW,
    'news_lastread' => SN_TIME_NOW,
    'user_bot' => $options['user_bot'] = empty($options['user_bot']) ? USER_BOT_PLAYER : $options['total_points'],

    'username' => $username_unsafe,
    'email' => $email_unsafe,
    'email_2' => $email_unsafe,

    'lang' => $options['language_iso'] ? $options['language_iso'] : DEFAULT_LANG,
    'skin' => DEFAULT_SKIN_NAME,

    'total_points' => $options['total_points'] = empty($options['total_points']) ? 0 : $options['total_points'],

    'options' => (empty($options['options']) ? $player_options_string : $options['options']) . (empty($options['options_extra']) ? '' : $options['options_extra']),

    'galaxy' => $options['galaxy'] = intval($options['galaxy'] ? $options['galaxy'] : 0),
    'system' => $options['system'] = intval($options['system'] ? $options['system'] : 0),
    'planet' => $options['planet'] = intval($options['planet'] ? $options['planet'] : 0),
  );

  !empty($options['salt']) ? $field_set['salt'] = $options['salt'] : false;
  !empty($options['password_encoded_unsafe']) ? $field_set['password'] = $options['password_encoded_unsafe'] : false;
  \DBAL\DbQuery::build()->setTable('users')->setValues($field_set)->doInsert();
  $user_new = db_user_by_id(db_insert_id());
  $user_new = /** @scrutinizer ignore-deprecated */ db_user_by_id(db_insert_id());

  if(!($options['galaxy'] && $options['system'] && $options['planet'])) {
    $options['galaxy'] = $config->LastSettedGalaxyPos;
    $options['system'] = $config->LastSettedSystemPos;
    $segment_size = floor($config->game_maxPlanet / 3);
    $segment = floor($config->LastSettedPlanetPos / $segment_size);
    $segment++;
    $options['planet'] = mt_rand(1 + $segment * $segment_size, ($segment + 1) * $segment_size);

    while(true) {
      if($options['planet'] > $config->game_maxPlanet) {
        $options['planet'] = mt_rand(0, $segment_size - 1) + 1;
        $options['system']++;
      }
      if($options['system'] > $config->game_maxSystem) {
        $options['system'] = 1;
        $options['galaxy']++;
      }
      $options['galaxy'] > $config->game_maxGalaxy ? $options['galaxy'] = 1 : false;

      $galaxy_row = DBStaticPlanet::db_planet_by_gspt($options['galaxy'], $options['system'], $options['planet'], PT_PLANET, true, 'id');
      if(!$galaxy_row['id']) {
        $config->db_saveItem(array(
          'LastSettedGalaxyPos' => $options['galaxy'],
          'LastSettedSystemPos' => $options['system'],
          'LastSettedPlanetPos' => $options['planet'],
        ));
        break;
      }
      $options['planet'] += 3;
    }
  }
  $new_planet_id = uni_create_planet($options['galaxy'], $options['system'], $options['planet'], $user_new['id'], '', true, $options['planet_options']);

  db_user_set_by_id($user_new['id'],
  /** @scrutinizer ignore-deprecated */ db_user_set_by_id($user_new['id'],
    "`id_planet` = '{$new_planet_id}', `current_planet` = '{$new_planet_id}',
    `galaxy` = '{$options['galaxy']}', `system` = '{$options['system']}', `planet` = '{$options['planet']}'"
  );

  $config->db_saveItem('users_amount', $config->users_amount + 1);

  $username_safe = db_escape($username_unsafe);
  doquery("REPLACE INTO {{player_name_history}} SET `player_id` = {$user_new['id']}, `player_name` = '{$username_safe}'");

  if(!empty($options['partner_id']) && ($referral_row = db_user_by_id($options['partner_id'], true))) {
  if(!empty($options['partner_id']) && ($referral_row = /** @scrutinizer ignore-deprecated */ db_user_by_id($options['partner_id'], true))) {
    doquery("INSERT INTO {{referrals}} SET `id` = {$user_new['id']}, `id_partner` = {$options['partner_id']}");
  }

  sys_player_new_adjust($user_new['id'], $new_planet_id);

  return $result = db_user_by_id($user_new['id']);
  return $result = /** @scrutinizer ignore-deprecated */ db_user_by_id($user_new['id']);
}


Push — trunk ( 1c4b6b...c0c172 )

DeleteSelectedUser() B

Complexity

Size

Duplication

Importance

1 Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

supernova-ws / SuperNova

Push — trunk ( 1c4b6b...c0c172 )

DeleteSelectedUser() B

Complexity

Size

Duplication

Importance

1 Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like