playerNickOrder() - Code Metrics - Inspection of "UPDATE-feat-43a12.8: Added patch mechanic to updat..." - supernova-ws/SuperNova - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — trunk ( e6cc80...a060bf )

by SuperNova.WS

created 2018-02-27 08:44 UTC

playerNickOrder() A

↳ Parent: Project

Complexity

Conditions	3
Paths	3

Size

Total Lines	14
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	7
c	0
b	0
f	0
nc	3
nop	1
dl	0
loc	14
rs	9.4285

<?php

/**
 * Created by Gorlum 04.12.2017 4:20
 */

global $nickSorting;
function myFunction($a, $b) {
    // Do something
}
$nickSorting = [
  NICK_HTML,

  NICK_FIRST,

  NICK_RACE,
  NICK_GENDER,
  NICK_AWARD,
  NICK_VACATION,
  NICK_BIRTHSDAY,
  NICK_PREMIUM,
  NICK_AUTH_LEVEL,

  NICK_HIGHLIGHT,
  NICK_CLASS,
  NICK_NICK_CLASS,
  NICK_NICK,
  NICK_NICK_CLASS_END,
  NICK_ALLY_CLASS,
  NICK_ALLY,
  NICK_ALLY_CLASS_END,
  NICK_CLASS_END,
  NICK_HIGHLIGHT_END,

  NICK_LAST,
];

/**
 * Ordering nick parts according to predefined part order
 *
 * @param array $array
 *
 * @return array
 */
function playerNickOrder($array) {
  global $nickSorting;
function myFunction($a, $b) {
    // Do something
}

  $result = [];
  // Rearranging nick parts according to sort array
  foreach ($nickSorting as $nickPartId) {
    if (array_key_exists($nickPartId, $array)) {
      $result[$nickPartId] = $array[$nickPartId];
      unset($array[$nickPartId]);
    }
  }

  // Adding what left of nick parts to resulting array
  return array_merge($result, $array);
}

// Может принимать: (array)$user, $nick_render_array, $nick_render_array_html, $nick_render_string_compact

function player_nick_render_to_html($result, $options = false) {
  $result = player_nick_uncompact($result);

  if (is_array($result)) {
    if (isset($result['id'])) {
      $result = player_nick_render_current_to_array($result, $options);
    }
    if (!isset($result[NICK_HTML])) {
      $result = player_nick_render_array_to_html($result);
    }
    unset($result[NICK_HTML]);
    $result = implode('', playerNickOrder($result));
  }

  return $result;
}

/**
 * Pack nick parts to string
 *
 * @param array $nick_array
 *
 * @return string
 */
function player_nick_compact($nick_array) {
  return json_encode(playerNickOrder($nick_array));
}

/**
 * Unpacks nick parts from string - if necessary
 *
 * @param array|string $nick_string
 *
 * @return array|string
 */
function player_nick_uncompact($nick_string) {
  $result = $nick_string;
  if (is_string($nick_string) && strpos($nick_string, '{"') === 0) {
    $result = json_decode($nick_string, true);
    if (json_last_error() !== JSON_ERROR_NONE) {
      $result = $nick_string;
    }
  }

  return $result;
}

function player_nick_render_array_to_html($nick_array) {
  $result = null;

  return sn_function_call('player_nick_render_array_to_html', array($nick_array, &$result));
}

/**
 * @param array $nick_array
 * @param array $result
 *
 * @return array
 */
function sn_player_nick_render_array_to_html($nick_array, &$result) {
  static $iconCache = array();

  if (empty($iconCache['gender_' . $nick_array[NICK_GENDER]])) {
    $iconCache['gender_' . $nick_array[NICK_GENDER]] = classSupernova::$gc->skinModel->getImageCurrent("gender_{$nick_array[NICK_GENDER]}|html");
    $iconCache['icon_vacation'] = classSupernova::$gc->skinModel->getImageCurrent('icon_vacation|html');
    $iconCache['icon_birthday'] = classSupernova::$gc->skinModel->getImageCurrent('icon_birthday|html');
  }

  // ALL STRING ARE UNSAFE!!!
  if (isset($nick_array[NICK_BIRTHSDAY])) {
    $result[NICK_BIRTHSDAY] = $iconCache['icon_birthday'];
  }

  if (isset($nick_array[NICK_VACATION])) {
    $result[NICK_VACATION] = $iconCache['icon_vacation'];
  }

  if (isset($nick_array[NICK_GENDER])) {
    $result[NICK_GENDER] = $iconCache['gender_' . $nick_array[NICK_GENDER]];
  }

  $highlight = null;
  if (isset($nick_array[NICK_PREMIUM])) {
    $highlight = classSupernova::$config->chat_highlight_premium;

  }

  if (isset($nick_array[NICK_AUTH_LEVEL])) {
    switch ($nick_array[NICK_AUTH_LEVEL]) {
      case 4:
        $highlight = classSupernova::$config->chat_highlight_developer;

      break;

      case 3:
        $highlight = classSupernova::$config->chat_highlight_admin;

      break;

      case 2:
        $highlight = classSupernova::$config->chat_highlight_operator;

      break;

      case 1:
        $highlight = classSupernova::$config->chat_highlight_moderator;

      break;
    }

  }

  if ($highlight) {
    list($result[NICK_HIGHLIGHT], $result[NICK_HIGHLIGHT_END]) = explode('$1', $highlight);
  }

  if (isset($nick_array[NICK_CLASS])) {
    $result[NICK_CLASS] = '<span ' . $nick_array[NICK_CLASS] . '>';
    $result[NICK_CLASS_END] = '</span>';
  }

  $result[NICK_NICK] = sys_safe_output($nick_array[NICK_NICK]);

  if (isset($nick_array[NICK_ALLY])) {
    $result[NICK_ALLY] = '[' . sys_safe_output($nick_array[NICK_ALLY]) . ']';
  }

  $result[NICK_HTML] = true;

  return $result;
}

/**
 * @param array      $render_user
 * @param array|bool $options - [
 *                            'color' => true,
 *                            'icons' => true,
 *                            'gender' => true,
 *                            'birthday' => true,
 *                            'ally' => true,
 *                            ]
 *
 * @return mixed
 */
function player_nick_render_current_to_array($render_user, $options = false) {
  $result = null;

  return sn_function_call('player_nick_render_current_to_array', array($render_user, $options, &$result));
}

/**
 * @param array      $render_user
 * @param array|bool $options - [
 *                            'color' => true,
 *                            'icons' => true,
 *                            'gender' => true,
 *                            'birthday' => true,
 *                            'ally' => true,
 *                            ]
 * @param array      $result
 *
 * @return mixed
 */
function sn_player_nick_render_current_to_array($render_user, $options = false, &$result) {
  /*

  $options = $options !== true ? $options :
    array(
      'color' => true,
      'icons' => true,
      'gender' => true,
      'birthday' => true,
      'ally' => true,
    );
  */


  if ($render_user['user_birthday'] && ($options === true || isset($options['icons']) || isset($options['birthday'])) && (date('Y', SN_TIME_NOW) . date('-m-d', strtotime($render_user['user_birthday'])) == date('Y-m-d', SN_TIME_NOW))) {
    $result[NICK_BIRTHSDAY] = '';
  }

  if ($options === true || (isset($options['icons']) && $options['icons']) || (isset($options['gender']) && $options['gender'])) {
    $result[NICK_GENDER] = $render_user['gender'] == GENDER_UNKNOWN ? 'unknown' : ($render_user['gender'] == GENDER_FEMALE ? 'female' : 'male');
  }

  if (($options === true || (isset($options['icons']) && $options['icons']) || (isset($options['vacancy']) && $options['vacancy'])) && $render_user['vacation']) {

    $result[NICK_VACATION] = $render_user['vacation'];
  }

  if ($options === true || (isset($options['color']) && $options['color'])) {
    if ($user_auth_level = $render_user['authlevel']) {
      $result[NICK_AUTH_LEVEL] = $user_auth_level;
    }
    if ($user_premium = mrc_get_level($render_user, false, UNIT_PREMIUM)) {
    if ($user_premium = mrc_get_level($render_user, /** @scrutinizer ignore-type */ false, UNIT_PREMIUM)) {
      $result[NICK_PREMIUM] = $user_premium;
    }
  }

  if ((isset($options['class']) && $options['class'])) {
    $result[NICK_CLASS] = (isset($result_options[NICK_CLASS]) ? ' ' . $result_options[NICK_CLASS] : '') . $options['class'];

  }

  if ($render_user['ally_tag'] && ($options === true || (isset($options['ally']) && $options['ally']))) {
    $result[NICK_ALLY] = $render_user['ally_tag'];
  }

  $result[NICK_NICK] = $render_user['username'];

  return $result;
}


Push — trunk ( e6cc80...a060bf )

playerNickOrder() A

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

supernova-ws / SuperNova

Push — trunk ( e6cc80...a060bf )

playerNickOrder() A

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like