supernova-ws /
SuperNova
| Conditions | 95 |
| Paths | 7128 |
| Total Lines | 272 |
| Code Lines | 134 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 201 | function sn_flt_can_attack($planet_src, $planet_dst, $fleet = [], $mission, $options = [], &$result) { |
||
| 202 | //TODO: try..catch |
||
| 203 | global $config, $user; |
||
| 204 | |||
| 205 | !is_array($options) ? $options = [] : false; |
||
| 206 | |||
| 207 | if ($user['vacation']) { |
||
| 208 | return $result = ATTACK_OWN_VACATION; |
||
| 209 | } |
||
| 210 | |||
| 211 | $sn_groups_mission = sn_get_groups('missions'); |
||
| 212 | if (!isset($sn_groups_mission[$mission])) { |
||
| 213 | return $result = ATTACK_MISSION_ABSENT; |
||
| 214 | } |
||
| 215 | $sn_data_mission = $sn_groups_mission[$mission]; |
||
| 216 | |||
| 217 | //TODO: Проверка на отстуствие ресурсов в нетранспортных миссиях (Транспорт, Передислокация, Колонизация) |
||
| 218 | |||
| 219 | //TODO: Проверка на наличие ресурсов при Транспорте |
||
| 220 | // TODO: Проверка на отрицательные ресурсы при транспорте |
||
| 221 | // TODO: Проверка на перегрузку при транспорте |
||
| 222 | |||
| 223 | // TODO: В ракетных миссиях могут лететь только ракеты |
||
| 224 | // TODO: В неракетных миссиях ракеты должны отсутствовать |
||
| 225 | |||
| 226 | if (empty($fleet) || !is_array($fleet)) { |
||
| 227 | return $result = ATTACK_NO_FLEET; |
||
| 228 | } |
||
| 229 | |||
| 230 | $ships = 0; |
||
| 231 | $recyclers = 0; |
||
| 232 | $spies = 0; |
||
| 233 | $resources = 0; |
||
| 234 | $ship_ids = sn_get_groups('fleet'); |
||
| 235 | $resource_ids = sn_get_groups('resources_loot'); |
||
| 236 | foreach ($fleet as $ship_id => $ship_count) { |
||
| 237 | $is_ship = in_array($ship_id, $ship_ids); |
||
| 238 | $is_resource = in_array($ship_id, $resource_ids); |
||
| 239 | // if (!$is_ship && !$is_resource) { |
||
| 240 | // // TODO Спецобработчик для Капитана и модулей |
||
| 241 | // return ATTACK_WRONG_UNIT; |
||
| 242 | // } |
||
| 243 | |||
| 244 | if ($ship_count < 0) { |
||
| 245 | return $result = $is_ship ? ATTACK_SHIP_COUNT_WRONG : ATTACK_RESOURCE_COUNT_WRONG; |
||
| 246 | } |
||
| 247 | |||
| 248 | if ($ship_count > mrc_get_level($user, $planet_src, $ship_id)) { |
||
| 249 | // TODO ATTACK_NO_MISSILE |
||
| 250 | return $result = $is_ship ? ATTACK_NO_SHIPS : ATTACK_NO_RESOURCES; |
||
| 251 | } |
||
| 252 | |||
| 253 | if ($is_ship) { |
||
| 254 | $single_ship_data = get_ship_data($ship_id, $user); |
||
| 255 | if ($single_ship_data[P_SPEED] <= 0) { |
||
| 256 | return $result = ATTACK_ZERO_SPEED; |
||
| 257 | } |
||
| 258 | $ships += $ship_count; |
||
| 259 | $recyclers += in_array($ship_id, sn_get_groups('flt_recyclers')) ? $ship_count : 0; |
||
| 260 | $spies += $ship_id == SHIP_SPY ? $ship_count : 0; |
||
| 261 | } elseif ($is_resource) { |
||
| 262 | $resources += $ship_count; |
||
| 263 | } |
||
| 264 | } |
||
| 265 | |||
| 266 | if (empty($resources) && !empty($options[P_FLEET_ATTACK_RES_LIST]) && is_array($options[P_FLEET_ATTACK_RES_LIST])) { |
||
| 267 | $resources = array_sum($options[P_FLEET_ATTACK_RES_LIST]); |
||
| 268 | } |
||
| 269 | |||
| 270 | if ( |
||
| 271 | isset($options[P_FLEET_ATTACK_RESOURCES_SUM]) |
||
| 272 | && $options[P_FLEET_ATTACK_RESOURCES_SUM] > 0 |
||
| 273 | && empty($sn_data_mission['transport']) |
||
| 274 | ) { |
||
| 275 | return $result = ATTACK_RESOURCE_FORBIDDEN; |
||
| 276 | } |
||
| 277 | |||
| 278 | /* |
||
| 279 | elseif($mission == MT_TRANSPORT) |
||
| 280 | { |
||
| 281 | return ATTACK_TRANSPORT_EMPTY; |
||
| 282 | } |
||
| 283 | */ |
||
| 284 | |||
| 285 | $speed = $options[P_FLEET_ATTACK_SPEED_PERCENT_TENTH]; |
||
| 286 | if ($speed && ($speed != intval($speed) || $speed < 1 || $speed > 10)) { |
||
| 287 | return $result = ATTACK_WRONG_SPEED; |
||
| 288 | } |
||
| 289 | |||
| 290 | $travel_data = flt_travel_data($user, $planet_src, $planet_dst, $fleet, $options[P_FLEET_ATTACK_SPEED_PERCENT_TENTH]); |
||
| 291 | |||
| 292 | |||
| 293 | if (mrc_get_level($user, $planet_src, RES_DEUTERIUM) < $fleet[RES_DEUTERIUM] + $travel_data['consumption']) { |
||
| 294 | return $result = ATTACK_NO_FUEL; |
||
| 295 | } |
||
| 296 | |||
| 297 | if ($travel_data['consumption'] > $travel_data['capacity']) { |
||
| 298 | return $result = ATTACK_TOO_FAR; |
||
| 299 | } |
||
| 300 | |||
| 301 | if ($travel_data['hold'] < $resources) { |
||
| 302 | return $result = ATTACK_OVERLOADED; |
||
| 303 | } |
||
| 304 | |||
| 305 | $fleet_start_time = SN_TIME_NOW + $travel_data['duration']; |
||
| 306 | |||
| 307 | $fleet_group = $options[P_FLEET_ATTACK_FLEET_GROUP]; |
||
| 308 | if ($fleet_group) { |
||
| 309 | if ($mission != MT_AKS) { |
||
| 310 | return $result = ATTACK_WRONG_MISSION; |
||
| 311 | }; |
||
| 312 | |||
| 313 | $acs = DbFleetStatic::dbAcsGetById($fleet_group); |
||
| 314 | if (!$acs['id']) { |
||
| 315 | return $result = ATTACK_NO_ACS; |
||
| 316 | } |
||
| 317 | |||
| 318 | if ($planet_dst['galaxy'] != $acs['galaxy'] || $planet_dst['system'] != $acs['system'] || $planet_dst['planet'] != $acs['planet'] || $planet_dst['planet_type'] != $acs['planet_type']) { |
||
| 319 | return $result = ATTACK_ACS_WRONG_TARGET; |
||
| 320 | } |
||
| 321 | |||
| 322 | if ($fleet_start_time > $acs['ankunft']) { |
||
| 323 | return $result = ATTACK_ACS_TOO_LATE; |
||
| 324 | } |
||
| 325 | |||
| 326 | if (DbFleetStatic::acsIsAcsFull($acs['id'])) { |
||
| 327 | return $result = ATTACK_ACS_MAX_FLEETS; |
||
| 328 | } |
||
| 329 | } |
||
| 330 | |||
| 331 | $flying_fleets = $options[P_FLEET_ATTACK_FLYING_COUNT]; |
||
| 332 | if (!$flying_fleets) { |
||
| 333 | $flying_fleets = DbFleetStatic::fleet_count_flying($user['id']); |
||
| 334 | } |
||
| 335 | if (GetMaxFleets($user) <= $flying_fleets && $mission != MT_MISSILE) { |
||
| 336 | return $result = ATTACK_NO_SLOTS; |
||
| 337 | } |
||
| 338 | |||
| 339 | // В одиночку шпионские зонды могут летать только в миссии Шпионаж, Передислокация и Транспорт |
||
| 340 | if ($ships && $spies && $spies == $ships && !($mission == MT_SPY || $mission == MT_RELOCATE || $mission == MT_TRANSPORT)) { |
||
| 341 | return $result = ATTACK_SPIES_LONLY; |
||
| 342 | } |
||
| 343 | |||
| 344 | // Checking for no planet |
||
| 345 | if (!$planet_dst['id_owner']) { |
||
| 346 | if ($mission == MT_COLONIZE && !$fleet[SHIP_COLONIZER]) { |
||
| 347 | return $result = ATTACK_NO_COLONIZER; |
||
| 348 | } |
||
| 349 | |||
| 350 | if ($mission == MT_EXPLORE || $mission == MT_COLONIZE) { |
||
| 351 | return $result = ATTACK_ALLOWED; |
||
| 352 | } |
||
| 353 | |||
| 354 | return $result = ATTACK_NO_TARGET; |
||
| 355 | } |
||
| 356 | |||
| 357 | if ($mission == MT_RECYCLE) { |
||
| 358 | if ($planet_dst['debris_metal'] + $planet_dst['debris_crystal'] <= 0) { |
||
| 359 | return $result = ATTACK_NO_DEBRIS; |
||
| 360 | } |
||
| 361 | if ($recyclers <= 0) { |
||
| 362 | return $result = ATTACK_NO_RECYCLERS; |
||
| 363 | } |
||
| 364 | |||
| 365 | return $result = ATTACK_ALLOWED; |
||
| 366 | } |
||
| 367 | |||
| 368 | // Got planet. Checking if it is ours |
||
| 369 | if ($planet_dst['id_owner'] == $user['id']) { |
||
| 370 | if ($mission == MT_TRANSPORT || $mission == MT_RELOCATE) { |
||
| 371 | return $result = ATTACK_ALLOWED; |
||
| 372 | } |
||
| 373 | |||
| 374 | return $planet_src['id'] == $planet_dst['id'] ? ATTACK_SAME : ATTACK_OWN; |
||
| 375 | } |
||
| 376 | |||
| 377 | // No, planet not ours. Cutting mission that can't be send to not-ours planet |
||
| 378 | if ($mission == MT_RELOCATE || $mission == MT_COLONIZE || $mission == MT_EXPLORE) { |
||
| 379 | return $result = ATTACK_WRONG_MISSION; |
||
| 380 | } |
||
| 381 | |||
| 382 | $enemy = db_user_by_id($planet_dst['id_owner']); |
||
| 383 | // We cannot attack or send resource to users in VACATION mode |
||
| 384 | if ($enemy['vacation'] && $mission != MT_RECYCLE) { |
||
| 385 | return $result = ATTACK_VACATION; |
||
| 386 | } |
||
| 387 | |||
| 388 | // Multi IP protection |
||
| 389 | // TODO: Here we need a procedure to check proxies |
||
| 390 | if (sys_is_multiaccount($user, $enemy)) { |
||
| 391 | return $result = ATTACK_SAME_IP; |
||
| 392 | } |
||
| 393 | |||
| 394 | $user_points = $user['total_points']; |
||
| 395 | $enemy_points = $enemy['total_points']; |
||
| 396 | |||
| 397 | // Is it transport? If yes - checking for buffing to prevent mega-alliance destroyer |
||
| 398 | if ($mission == MT_TRANSPORT) { |
||
| 399 | if ($user_points >= $enemy_points || $config->allow_buffing) { |
||
| 400 | return $result = ATTACK_ALLOWED; |
||
| 401 | } else { |
||
| 402 | return $result = ATTACK_BUFFING; |
||
| 403 | } |
||
| 404 | } |
||
| 405 | |||
| 406 | // Only aggresive missions passed to this point. HOLD counts as passive but aggresive |
||
| 407 | |||
| 408 | // Is it admin with planet protection? |
||
| 409 | if ($planet_dst['id_level'] > $user['authlevel']) { |
||
| 410 | return $result = ATTACK_ADMIN; |
||
| 411 | } |
||
| 412 | |||
| 413 | // Okay. Now skipping protection checks for inactive longer then 1 week |
||
| 414 | if (!$enemy['onlinetime'] || $enemy['onlinetime'] >= (SN_TIME_NOW - 60 * 60 * 24 * 7)) { |
||
| 415 | if ( |
||
| 416 | (SN::$gc->general->playerIsNoobByPoints($enemy_points) && !SN::$gc->general->playerIsNoobByPoints($user_points)) |
||
| 417 | || |
||
| 418 | (SN::$gc->general->playerIs1stStrongerThen2nd($user_points, $enemy_points)) |
||
| 419 | ) { |
||
| 420 | if ($mission != MT_HOLD) { |
||
| 421 | return $result = ATTACK_NOOB; |
||
| 422 | } |
||
| 423 | if ($mission == MT_HOLD && !($user['ally_id'] && $user['ally_id'] == $enemy['ally_id'] && $config->ally_help_weak)) { |
||
| 424 | return $result = ATTACK_NOOB; |
||
| 425 | } |
||
| 426 | } |
||
| 427 | } |
||
| 428 | |||
| 429 | // Is it HOLD mission? If yes - there should be ally deposit |
||
| 430 | if ($mission == MT_HOLD) { |
||
| 431 | if (mrc_get_level($user, $planet_dst, STRUC_ALLY_DEPOSIT)) { |
||
| 432 | return $result = ATTACK_ALLOWED; |
||
| 433 | } |
||
| 434 | |||
| 435 | return $result = ATTACK_NO_ALLY_DEPOSIT; |
||
| 436 | } |
||
| 437 | |||
| 438 | if ($mission == MT_SPY) { |
||
| 439 | return $result = $spies >= 1 ? ATTACK_ALLOWED : ATTACK_NO_SPIES; |
||
| 440 | } |
||
| 441 | |||
| 442 | // Is it MISSILE mission? |
||
| 443 | if ($mission == MT_MISSILE) { |
||
| 444 | $sn_data_mip = get_unit_param(UNIT_DEF_MISSILE_INTERPLANET); |
||
| 445 | if (mrc_get_level($user, $planet_src, STRUC_SILO) < $sn_data_mip[P_REQUIRE][STRUC_SILO]) { |
||
| 446 | return $result = ATTACK_NO_SILO; |
||
| 447 | } |
||
| 448 | |||
| 449 | if (!$fleet[UNIT_DEF_MISSILE_INTERPLANET]) { |
||
| 450 | return $result = ATTACK_NO_MISSILE; |
||
| 451 | } |
||
| 452 | |||
| 453 | $distance = abs($planet_dst['system'] - $planet_src['system']); |
||
| 454 | $mip_range = flt_get_missile_range($user); |
||
| 455 | if ($distance > $mip_range || $planet_dst['galaxy'] != $planet_src['galaxy']) { |
||
| 456 | return $result = ATTACK_MISSILE_TOO_FAR; |
||
| 457 | } |
||
| 458 | |||
| 459 | if (!empty($options[P_FLEET_ATTACK_TARGET_STRUCTURE]) && !in_array($options[P_FLEET_ATTACK_TARGET_STRUCTURE], sn_get_groups('defense_active'))) { |
||
| 460 | return $result = ATTACK_WRONG_STRUCTURE; |
||
| 461 | } |
||
| 462 | } |
||
| 463 | |||
| 464 | if ($mission == MT_DESTROY && $planet_dst['planet_type'] != PT_MOON) { |
||
| 465 | return $result = ATTACK_WRONG_MISSION; |
||
| 466 | } |
||
| 467 | |||
| 468 | if ($mission == MT_ATTACK || $mission == MT_AKS || $mission == MT_DESTROY) { |
||
| 469 | return $result = flt_bashing_check($user, $enemy, $planet_dst, $mission, $travel_data['duration'], $fleet_group); |
||
| 470 | } |
||
| 471 | |||
| 472 | return $result = ATTACK_ALLOWED; |
||
| 473 | } |
||
| 627 |
Loading history...