Chat\Chat::_chatMsgView()

Complexity

Conditions	32
Paths	1600

Size

Total Lines	176
Code Lines	125

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
  protected function _chatMsgView($template = null) {
    defined('IN_AJAX') or define('IN_AJAX', true);

    global $config, $user, $lang;


    $history = sys_get_param_str('history');
    if (!$history) {
      $config->array_set('users', $user['id'], 'chat_last_refresh', SN_TIME_MICRO);
      // $chat_player_row = $this->sn_chat_advanced_get_chat_player_record($user['id']);
      doquery("UPDATE {{chat_player}} SET `chat_player_refresh_last` = " . SN_TIME_NOW . " WHERE `chat_player_player_id` = {$user['id']} LIMIT 1;");

The function doquery() has been deprecated.

    }

    $page                         = 0;
    $last_message                 = '';
    $alliance                     = 0;
    $template_result['.']['chat'] = array();

$template_result was never initialized. Although not strictly required by PHP, it is generally a good practice to add $template_result = array(); before regardless.

    if (!$history && $config->getMode() != classCache::CACHER_NO_CACHE && $config->chat_timeout && SN_TIME_MICRO - $config->array_get('users', $user['id'], 'chat_last_activity') > $config->chat_timeout) {
      $result['disable']              = true;

$result was never initialized. Although not strictly required by PHP, it is generally a good practice to add $result = array(); before regardless.

      $template_result['.']['chat'][] = array(
        'TIME'    => date(FMT_DATE_TIME, htmlentities(SN_TIME_NOW + SN_CLIENT_TIME_DIFF, ENT_QUOTES, 'utf-8')),

htmlentities(Chat\SN_TIME_NOW + Chat\SN_CLIENT_TIME_DIFF, Chat\ENT_QUOTES, 'utf-8') of type string is incompatible with the type integer|null expected by parameter $timestamp of date().

        'DISABLE' => true,
      );
    } else {
      $alliance = sys_get_param_str('ally') && $user['ally_id'] ? $user['ally_id'] : 0;

      $page_limit = sys_get_param_id('line_per_page', self::CHAT_DEFAULT_LINES_PER_PAGE); // Chat rows Limit

      $where_add    = '';
      $last_message = 0;
      if ($history) {
        $rows       = doquery("SELECT count(1) AS CNT

The function doquery() has been deprecated.

          FROM {{chat}}
          WHERE
          (
            (ally_id = '{$alliance}' AND `chat_message_recipient_id` IS NULL) OR
            (ally_id = 0 AND `chat_message_recipient_id` = {$user['id']}) OR
            (ally_id = 0 AND `chat_message_sender_id` = {$user['id']} AND `chat_message_recipient_id` IS NOT NULL) OR
            (ally_id = 0 AND `chat_message_sender_id` IS NULL AND `chat_message_recipient_id` IS NULL)
          )
        ", true);

true of type true is incompatible with the type string expected by parameter $table of doquery().

        $page_count = ceil($rows['CNT'] / $page_limit);

        for ($i = 1; $i <= $page_count; $i++) {
          $template_result['.']['page'][] = array(
            'NUMBER' => $i
          );
        }

        $page = min($page_count, max(1, sys_get_param_int('sheet')));
      } else {
        $last_message = sys_get_param_id('last_message');
        $where_add    = $last_message ? "AND `messageid` > {$last_message}" : '';
        $page         = 1;
      }

      $start_row = ($page - 1) * $page_limit;// OR `chat_message_recipient_id` = {$user['id']}
      $start_row = $start_row < 0 ? 0 : $start_row;
      $query     = doquery(

The function doquery() has been deprecated.

        "SELECT c.*, u.authlevel
        FROM
          {{chat}} AS c
          LEFT JOIN {{users}} AS u ON u.id = c.chat_message_sender_id
        WHERE
          (
            (c.ally_id = '{$alliance}' AND `chat_message_recipient_id` IS NULL) OR
            (c.ally_id = 0 AND `chat_message_recipient_id` = {$user['id']}) OR
            (c.ally_id = 0 AND `chat_message_sender_id` = {$user['id']} AND `chat_message_recipient_id` IS NOT NULL) OR
            (c.ally_id = 0 AND `chat_message_sender_id` IS NULL AND `chat_message_recipient_id` IS NULL)
          )
          {$where_add}
        ORDER BY messageid DESC
        LIMIT {$start_row}, {$page_limit}");
      while ($chat_row = db_fetch($query)) {

The function db_fetch() has been deprecated.

        $chat_row['user']               = player_nick_render_to_html($chat_row['user']);
        $nick_stripped                  = htmlentities(strip_tags($chat_row['user']), ENT_QUOTES, 'utf-8');
        $template_result['.']['chat'][] = array(
          'TIME'                => SN::$gc->bbCodeParser->expandBbCode(date(FMT_DATE_TIME, $chat_row['timestamp'] + SN_CLIENT_TIME_DIFF)),
          'NICK'                => $chat_row['user'],
          'NICK_STRIPPED'       => $nick_stripped,
          'TEXT'                => SN::$gc->bbCodeParser->expandBbCode($chat_row['message'], $chat_row['authlevel']),
          'SENDER_ID'           => $chat_row['chat_message_sender_id'],
          'SENDER_NAME'         => $safe_name = sys_safe_output($chat_row['chat_message_sender_name']),
          'SENDER_NAME_SAFE'    => $safe_name <> $chat_row['chat_message_sender_name'] || strpbrk($safe_name, ' /\\\'') ? '&quot;' . $safe_name . '&quot;' : $safe_name,
          'RECIPIENT_ID'        => $chat_row['chat_message_recipient_id'],
          'RECIPIENT_NAME'      => $safe_name_recipient = sys_safe_output($chat_row['chat_message_recipient_name']),
          'RECIPIENT_NAME_SAFE' => $safe_name_recipient <> $chat_row['chat_message_recipient_name'] || strpbrk($safe_name_recipient, ' /\\\'') ? '&quot;' . $safe_name_recipient . '&quot;' : $safe_name_recipient,
        );

        $last_message = max($last_message, $chat_row['messageid']);
      }
    }

    $template_result['.']['chat'] = array_reverse($template_result['.']['chat']);

    $template_result += array(
      'PAGE'        => $page,
      'PAGES_TOTAL' => $page_count,

The variable $page_count does not seem to be defined for all execution paths leading up to this point.

      'PAGE_NEXT'   => $page < $page_count ? $page + 1 : $page,
      'PAGE_PREV'   => $page > 1 ? $page - 1 : $page,
      'ALLY'        => $alliance,
      'HISTORY'     => $history,
      'USER_ID'     => $user['id'],
    );

//    $template = $this->addModuleTemplate('chat_messages', $template);
    $template = SnTemplate::gettemplate('chat/chat_messages', $template);
    $template->assign_recursive($template_result);

    if ($history) {
      $pageTitle = "{$lang['chat_history']} - {$lang[$alliance ? 'chat_ally' : 'chat_common']}";
      SnTemplate::display($template, $pageTitle);
    } else {
      $result['last_message'] = $last_message;
      $result['html']         = SnTemplate::templateRenderToHtml($template);

//      $template = $this->addModuleTemplate('chat_online', $template);
      $template                              = SnTemplate::gettemplate('chat/chat_online', null);
//      $template->assign_recursive($template_result);
      $chat_online_players                   = 0;
      $chat_online_invisibles                = 0;
      $chat_player_invisible                 = 0;
      $template_result['.']['online_player'] = array();
      $ally_add                              = $alliance ? "AND u.ally_id = {$alliance}" : '';

      $chat_player_list = db_chat_player_list_online($config->chat_refresh_rate, $ally_add);

      // TODO: Добавить ограничение по бану
      while ($chat_player_row = db_fetch($chat_player_list)) {

The function db_fetch() has been deprecated.

        $chat_online_players++;
        if ($chat_player_row['chat_player_invisible']) {
          $chat_online_invisibles++;
        }

        if (!$chat_player_row['chat_player_invisible'] || $user['authlevel']) {
          $safe_name                               = sys_safe_output($chat_player_row['username']);
          $safe_name                               = $chat_player_row['username'] <> $safe_name || strpbrk($safe_name, ' /\\\'') !== false ? '&quot;' . $safe_name . '&quot;' : $safe_name;
          $template_result['.']['online_player'][] = array(
            'ID'          => $chat_player_row['id'],
            'NAME'        => player_nick_render_to_html($chat_player_row, array(
              'color' => true,
              'icons' => true,
              'ally'  => !$alliance,
              'class' => 'class="chat_nick_whisper" safe_name="' . $safe_name . '"',
            )),
            'NAME_SAFE'   => $safe_name,
            'MUTED'       => $chat_player_row['chat_player_muted'] && $chat_player_row['chat_player_muted'] >= SN_TIME_NOW ? date(FMT_DATE_TIME, $chat_player_row['chat_player_muted']) : false,
            'MUTE_REASON' => htmlentities($chat_player_row['chat_player_mute_reason'], ENT_COMPAT, 'UTF-8'),
            'INVISIBLE'   => $chat_player_row['chat_player_invisible'],
            'AUTH_LEVEL'  => $chat_player_row['authlevel'],
          );
        }
        if ($user['id'] == $chat_player_row['id']) {
          $chat_player_invisible = $chat_player_row['chat_player_invisible'];
        }
      }

      $chat_commands   = &$this->_chat_commands;
      $template_result = array_merge($template_result, array(
        'USER_ID'         => $user['id'],
        'USER_AUTHLEVEL'  => $user['authlevel'],
        'USER_CAN_BAN'    => in_array($user['authlevel'], $chat_commands['ban']['access']),
        'USER_CAN_MUTE'   => in_array($user['authlevel'], $chat_commands['mute']['access']),
        'USER_CAN_UNMUTE' => in_array($user['authlevel'], $chat_commands['unmute']['access']),
      ));
      $template->assign_recursive($template_result);
      $result['online'] = SnTemplate::templateRenderToHtml($template);

      $result['online_players']        = $chat_online_players;
      $result['online_invisibles']     = $chat_online_invisibles;
      $result['chat_player_invisible'] = $chat_player_invisible;
      $result['users_total']           = SN::$config->users_amount;
      $result['users_online']          = SN::$config->var_online_user_count;
      print(json_encode($result));
    }
    die();

Using exit here is not recommended.

  }