COE_missileAttack()

Complexity

Conditions	11
Paths	18

Size

Total Lines	78
Code Lines	45

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
function COE_missileAttack($defenceTech, $attackerTech, $MIPs, $structures, $targetedStructure = '0') {
  // Here we select which part of defense should take damage: structure or shield
  // $damageTo = P_SHIELD;
  // $damageTo = P_STRUCTURE;
  $damageTo = P_DEFENSE;

  $mip_data  = get_unit_param(UNIT_DEF_MISSILE_INTERPLANET);
  $MIPDamage = floor(mrc_modify_value($attackerTech, false, TECH_WEAPON, $MIPs * $mip_data[P_ATTACK] * mt_rand(80, 120) / 100));

It seems like mrc_modify_value($attackerTech, false, TECH_WEAPON, $MIPs * $mip_data[P_ATTACK] * mt_rand(80, 120) / 100) can also be of type null; however, parameter $num of floor() does only seem to accept double|integer, maybe add an additional type check?

  foreach ($structures as $key => $structure) {
    $unit_info                     = get_unit_param($key);
    $amplify                       = isset($mip_data[P_AMPLIFY][$key]) ? $mip_data[P_AMPLIFY][$key] : 1;
    $structures[$key][P_SHIELD]    = floor(mrc_modify_value($defenceTech, false, TECH_SHIELD, $unit_info[P_SHIELD]) / $amplify);
    $structures[$key][P_STRUCTURE] = floor(mrc_modify_value($defenceTech, false, TECH_ARMOR, $unit_info[P_ARMOR]) / $amplify);
    $structures[$key][P_DEFENSE]   = floor((
        mrc_modify_value($defenceTech, false, TECH_ARMOR, $unit_info[P_ARMOR]) +
        mrc_modify_value($defenceTech, false, TECH_SHIELD, $unit_info[P_SHIELD])
      ) / $amplify * mt_rand(80, 120) / 100);
  }

  $startStructs = $structures;

  if ($targetedStructure) {
    //attacking only selected structure
    $damageDone                        = $structures[$targetedStructure][$damageTo];
    $structsDestroyed                  = min(floor($MIPDamage / $damageDone), $structures[$targetedStructure][0]);
    $structures[$targetedStructure][0] -= $structsDestroyed;
    $MIPDamage                         -= $structsDestroyed * $damageDone;
  } else {
    // REALLY random attack
    $can_be_damaged = sn_get_groups('defense_active');
//debug($structures);
//debug($can_be_damaged);
    do {
      // finding is there any structure that can be damaged with leftovers of $MIPDamage
      foreach ($can_be_damaged as $key => $unit_id) {
//debug($structures[$unit_id][0]);
//debug($structures[$unit_id][$damageTo], $MIPDamage);
        if ($structures[$unit_id][0] <= 0 || $structures[$unit_id][$damageTo] > $MIPDamage) {
          unset($can_be_damaged[$key]);
        }
      }
      if (empty($can_be_damaged)) {
        break;
      }
      sort($can_be_damaged);
//debug($can_be_damaged, 'can be damaged');
      $random_defense = mt_rand(0, count($can_be_damaged) - 1);
//debug($can_be_damaged[$random_defense], 'Target');
      $current_target = &$structures[$can_be_damaged[$random_defense]];
//debug($current_target[0], 'Amount was');
      $can_be_destroyed = min($current_target[0], floor($MIPDamage / $current_target[$damageTo]));
//debug($MIPDamage, 'MIPDamage');
//debug($can_be_destroyed, 'Can be destroyed');
      $destroyed         = mt_rand(1, $can_be_destroyed);
      $MIPDamage         -= $current_target[$damageTo] * $destroyed;
      $current_target[0] -= $destroyed;
//debug($destroyed, 'Actually destroyed');

//print('<hr>');
    } while ($MIPDamage > 0 && !empty($can_be_damaged));
//debug($MIPDamage, 'MIPDamage left');
  }
//debug($structures);//die();
  // 1/2 of metal and 1/4 of crystal of destroyed structures returns to planet
  $metal   = 0;
  $crystal = 0;
  foreach ($structures as $key => $structure) {
    $unit_info = get_unit_param($key);
    $destroyed = $startStructs[$key][0] - $structure[0];
    $metal     += $destroyed * $unit_info[P_COST][RES_METAL] / 2;
    $crystal   += $destroyed * $unit_info[P_COST][RES_CRYSTAL] / 4;
  }

  $return['structures'] = $structures;     // Structures left after attack

$return was never initialized. Although not strictly required by PHP, it is generally a good practice to add $return = array(); before regardless.

  $return['metal']      = floor($metal);   // Metal scraps
  $return['crystal']    = floor($crystal); // Crystal scraps

  return $return;
}