Alliance\AllianceMember

Complexity

Total Complexity

8

Size/Duplication

Total Lines	80
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	getPlayerId()	0	2	1
A	changeTitle()	0	8	2
A	__construct()	0	5	2
A	getMemberName()	0	2	1
A	asPtl()	0	14	1
A	isOwner()	0	2	1

<?php
/**
 * Created by Gorlum 28.11.2017 11:15
 */

namespace Alliance;


use Player\RecordPlayer;

/**
 * Class AllianceMember
 *
 * Class represents member of Alliance
 *
 * @package Alliance
 */
class AllianceMember {

  /**
   * @var AllianceTitle $title
   */
  protected $title;
  /**
   * @var array $player
   */
  public $player;
  /**
   * @var Alliance $alliance
   */
  protected $alliance;


  public function __construct(Alliance $alliance, RecordPlayer $player) {
    $this->alliance = $alliance;
    $this->player = $player;

It seems like $player of type Player\RecordPlayer is incompatible with the declared type array of property $player.

    $this->title = $this->alliance->getTitleList()->getTitle($this->isOwner() ? Alliance::OWNER_INDEX : $this->player->ally_rank_id);

The property ally_rank_id does not exist on Player\RecordPlayer. Since you implemented __get, consider adding a @property annotation.

  }

  /**
   * Change title of member
   *
   * @param AllianceTitle $title
   *
   * @return bool
   */
  public function changeTitle(AllianceTitle $title) {
    if(!$title instanceof AllianceTitle) {

$title is always a sub-type of Alliance\AllianceTitle.

      return false;
    }

    $this->player->ally_rank_id = $title->index;

    return $this->player->update();
  }

  /**
   * Get player ID of member
   *
   * @return mixed
   */
  public function getPlayerId() {
    return $this->player->id;
  }

  /**
   * @return mixed
   */
  public function getMemberName() {
    return $this->player->username;
  }

  /**
   * @return bool
   */
  public function isOwner() {
    return $this->getPlayerId() == $this->alliance->ownerId;
  }

  /**
   * @return array
   */
  public function asPtl() {
    return [
      'PLAYER_ID'    => $this->getPlayerId(),
      'PLAYER_NAME'  => $this->player->username,
      'ONLINE'       => $this->player->onlinetime,
      'ONLINE_SQL'   => date(FMT_DATE_TIME_SQL, $this->player->onlinetime),
      'VACATION'     => $this->player->vacation,
      'VACATION_SQL' => date(FMT_DATE_TIME_SQL, $this->player->vacation),
      'BAN'          => $this->player->banaday,
      'BAN_SQL'      => date(FMT_DATE_TIME_SQL, $this->player->banaday),
      'TITLE'        => $this->title->name,
      'TITLE_ID'     => $this->title->index,
      'RIGHTS'       => $this->title->rightsAsString(),
      'OWNER'        => $this->isOwner(),
    ];
  }

}