SWP\Bundle\ContentBundle\EventListener\ProcessArticleMediaListener

Complexity

Total Complexity

23

Size/Duplication

Total Lines	137
Duplicated Lines	8.76 %

Coupling/Cohesion

Components	1
Dependencies	9

Test Coverage

Coverage

26.32%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	9	1
C	onArticleCreate()	12	29	11
A	removeArticleMediaIfNeeded()	0	11	2
A	handleMedia()	0	12	3
B	replaceBodyImagesWithMedia()	0	33	6

<?php

/*
 * This file is part of the Superdesk Web Publisher Content Bundle.
 *
 * Copyright 2016 Sourcefabric z.ú. and contributors.
 *
 * For the full copyright and license information, please see the
 * AUTHORS and LICENSE files distributed with this source code.
 *
 * @copyright 2015 Sourcefabric z.ú
 * @license http://www.superdesk.org/license
 */

namespace SWP\Bundle\ContentBundle\EventListener;

use SWP\Bundle\ContentBundle\Doctrine\ArticleMediaRepositoryInterface;
use SWP\Bundle\ContentBundle\Doctrine\ORM\ArticleMediaRepository;
use SWP\Bundle\ContentBundle\Event\ArticleEvent;
use SWP\Bundle\ContentBundle\Factory\MediaFactoryInterface;
use SWP\Bundle\ContentBundle\Manager\MediaManagerInterface;
use SWP\Bundle\ContentBundle\Model\ArticleInterface;
use SWP\Bundle\ContentBundle\Model\ArticleMediaInterface;
use SWP\Component\Bridge\Model\ItemInterface;
use Symfony\Component\DomCrawler\Crawler;

class ProcessArticleMediaListener
{
    /**
     * @var ArticleMediaRepository
     */
    protected $articleMediaRepository;

    /**
     * @var MediaManagerInterface
     */
    protected $mediaManager;

    /**
     * @var MediaFactoryInterface
     */
    protected $mediaFactory;

    /**
     * ProcessArticleMediaListener constructor.
     *
     * @param ArticleMediaRepositoryInterface $articleMediaRepository
     * @param MediaManagerInterface           $mediaManager
     * @param MediaFactoryInterface           $mediaFactory
     */
    public function __construct(
        ArticleMediaRepositoryInterface $articleMediaRepository,
        MediaManagerInterface $mediaManager,
        MediaFactoryInterface $mediaFactory
    ) {
        $this->articleMediaRepository = $articleMediaRepository;

$articleMediaRepository is of type object<SWP\Bundle\ContentBundle\Doctrine\ArticleMediaRepositoryInterface>, but the property $articleMediaRepository was declared to be of type object<SWP\Bundle\ContentBundle\Doctrine\ORM\ArticleMediaRepository>. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

        $this->mediaManager = $mediaManager;
        $this->mediaFactory = $mediaFactory;
    }

    /**
     * @param ArticleEvent $event
     */
    public function onArticleCreate(ArticleEvent $event)
    {
        $package = $event->getPackage();
        $article = $event->getArticle();

        if (null !== $package && 0 === count($package->getItems())) {
            return;
        }

        foreach ($package->getItems() as $key => $packageItem) {
            if (ItemInterface::TYPE_PICTURE === $packageItem->getType() || ItemInterface::TYPE_FILE === $packageItem->getType()) {

This code seems to be duplicated across your project.

                $this->removeArticleMediaIfNeeded($key, $article);

                $articleMedia = $this->handleMedia($article, $key, $packageItem);
                $this->articleMediaRepository->persist($articleMedia);
            }

            if (null !== $packageItem->getItems() && 0 !== $packageItem->getItems()->count()) {
                foreach ($packageItem->getItems() as $key => $item) {
                    if (ItemInterface::TYPE_PICTURE === $item->getType() || ItemInterface::TYPE_FILE === $item->getType()) {

This code seems to be duplicated across your project.

                        $this->removeArticleMediaIfNeeded($key, $article);

                        $articleMedia = $this->handleMedia($article, $key, $item);
                        $this->articleMediaRepository->persist($articleMedia);
                    }
                }
            }
        }
    }

    private function removeArticleMediaIfNeeded($key, ArticleInterface $article)
    {
        $existingArticleMedia = $this->articleMediaRepository->findOneBy([
            'key' => $key,
            'article' => $article->getId(),
        ]);

        if (null !== $existingArticleMedia) {
            $this->articleMediaRepository->remove($existingArticleMedia);
        }
    }

    /**
     * @param ArticleInterface $article
     * @param string           $key
     * @param ItemInterface    $item
     *
     * @return ArticleMediaInterface
     */
    public function handleMedia(ArticleInterface $article, string $key, ItemInterface $item)
    {
        $articleMedia = $this->mediaFactory->create($article, $key, $item);

        if (ItemInterface::TYPE_PICTURE === $item->getType()) {
            $this->replaceBodyImagesWithMedia($article, $articleMedia);
        } elseif (ItemInterface::TYPE_FILE === $item->getType()) {

This elseif statement is empty, and could be removed.

            //TODO: handle files upload
        }

        return $articleMedia;
    }

    /**
     * @param ArticleInterface      $article
     * @param ArticleMediaInterface $articleMedia
     */
    private function replaceBodyImagesWithMedia(ArticleInterface $article, ArticleMediaInterface $articleMedia)
    {
        $body = $article->getBody();
        $mediaId = $articleMedia->getKey();
        preg_match(
            "/(<!-- EMBED START Image {id: \"$mediaId\"} -->)(.+?)(<!-- EMBED END Image {id: \"$mediaId\"} -->)/im",
            str_replace(PHP_EOL, '', $body),
            $embeds
        );
        if (empty($embeds)) {
            return;
        }

        $figureString = $embeds[2];
        $crawler = new Crawler($figureString);
        $images = $crawler->filter('figure img');
        /** @var \DOMElement $imageElement */
        foreach ($images as $imageElement) {
            foreach ($articleMedia->getRenditions() as $rendition) {
                if (strpos($imageElement->getAttribute('src'), $rendition->getImage()->getAssetId()) !== false) {
                    $attributes = $imageElement->attributes;
                    while ($attributes->length) {
                        $imageElement->removeAttribute($attributes->item(0)->name);
                    }
                    $imageElement->setAttribute('src', $this->mediaManager->getMediaUri($rendition->getImage()));
                    $imageElement->setAttribute('data-media-id', $mediaId);
                    $imageElement->setAttribute('data-image-id', $rendition->getImage()->getAssetId());
                }
            }
        }

        $article->setBody(str_replace($figureString, $crawler->filter('body')->html(), $body));
    }
}