PwaAwareRouter::generate() - Code Metrics - Inspection of "Add PWA config to tenant" - superdesk/web-publisher - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1198)

by Greg

created 2021-03-25 13:39 UTC

PwaAwareRouter::generate() A

↳ Parent: PwaAwareRouter

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	3

<?php

declare(strict_types=1);

/*
 * This file is part of the Superdesk Web Publisher Core Bundle.
 *
 * Copyright 2015 Sourcefabric z.u. and contributors.
 *
 * For the full copyright and license information, please see the
 * AUTHORS and LICENSE files distributed with this source code.
 *
 * @copyright 2021 Sourcefabric z.ú
 * @license http://www.superdesk.org/license
 */

namespace SWP\Bundle\CoreBundle\Routing;

use Psr\Container\ContainerInterface;
use Psr\Log\LoggerInterface;
use SWP\Component\MultiTenancy\Context\TenantContextInterface;
use Symfony\Bundle\FrameworkBundle\Routing\Router;
use Symfony\Component\Routing\RequestContext;

class PwaAwareRouter extends Router
{

    /**
     * @var TenantContextInterface
     */
    private $tenantContext;

    public function __construct(

        ContainerInterface $container,
        $resource,
        array $options = [],
        RequestContext $context = null,
        ContainerInterface $parameters = null,
        LoggerInterface $logger = null,
        string $defaultLocale = null
    ) {
        $this->tenantContext = $container->get('swp_multi_tenancy.tenant_context');

        parent::__construct($container, $resource, $options, $context, $parameters, $logger, $defaultLocale);
    }

    /**
     * {@inheritdoc}
     */
    public function generate($name, $parameters = [], $referenceType = false)
    {
        $url = parent::generate($name, $parameters, $referenceType);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        if($name === 'swp_user_verify_email') {
            $url = $this->applyPWAUrl($url);
        }
        return $url;
    }

    private function applyPWAUrl (string $url): string {
        if ($this->tenantContext->getTenant() &&
            $this->tenantContext->getTenant()->getPWAConfig() &&

            $this->tenantContext->getTenant()->getPWAConfig()->getUrl()

        ) {
            $PWAUrlParts = parse_url($this->tenantContext->getTenant()->getPWAConfig()->getUrl());

            $urlParts = parse_url($url);
            $url = $PWAUrlParts['scheme'].'://'.$PWAUrlParts['host'].':'.$PWAUrlParts['port'].$urlParts['path'].'?'.$urlParts['query'];
        }
        return $url;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		/*
6		* This file is part of the Superdesk Web Publisher Core Bundle.
7		*
8		* Copyright 2015 Sourcefabric z.u. and contributors.
9		*
10		* For the full copyright and license information, please see the
11		* AUTHORS and LICENSE files distributed with this source code.
12		*
13		* @copyright 2021 Sourcefabric z.ú
14		* @license http://www.superdesk.org/license
15		*/
16
17		namespace SWP\Bundle\CoreBundle\Routing;
18
19		use Psr\Container\ContainerInterface;
20		use Psr\Log\LoggerInterface;
21		use SWP\Component\MultiTenancy\Context\TenantContextInterface;
22		use Symfony\Bundle\FrameworkBundle\Routing\Router;
23		use Symfony\Component\Routing\RequestContext;
24
25		class PwaAwareRouter extends Router
26		{
27
28		/**
29		* @var TenantContextInterface
30		*/
31		private $tenantContext;
32
33	View Code Duplication	public function __construct(
		0 ignored issues – show Duplication introduced 2021-03-25 13:49 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
34		ContainerInterface $container,
35		$resource,
36		array $options = [],
37		RequestContext $context = null,
38		ContainerInterface $parameters = null,
39		LoggerInterface $logger = null,
40		string $defaultLocale = null
41		) {
42		$this->tenantContext = $container->get('swp_multi_tenancy.tenant_context');
43
44		parent::__construct($container, $resource, $options, $context, $parameters, $logger, $defaultLocale);
45		}
46
47		/**
48		* {@inheritdoc}
49		*/
50		public function generate($name, $parameters = [], $referenceType = false)
51		{
52		$url = parent::generate($name, $parameters, $referenceType);
		0 ignored issues – show Documentation introduced 2021-03-25 13:49 UTC by Report Bug Copy Issue Report `$referenceType` is of type `boolean`, but the function expects a `integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
53		if($name === 'swp_user_verify_email') {
54		$url = $this->applyPWAUrl($url);
55		}
56		return $url;
57		}
58
59		private function applyPWAUrl (string $url): string {
60		if ($this->tenantContext->getTenant() &&
61		$this->tenantContext->getTenant()->getPWAConfig() &&
		0 ignored issues – show Bug introduced 2021-03-25 13:49 UTC by Report Bug Copy Issue Report The method `getPWAConfig()` does not seem to exist on `object<SWP\Component\Mul...\Model\TenantInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
62		$this->tenantContext->getTenant()->getPWAConfig()->getUrl()
		0 ignored issues – show Bug introduced 2021-03-25 13:49 UTC by Report Bug Copy Issue Report The method `getPWAConfig()` does not seem to exist on `object<SWP\Component\Mul...\Model\TenantInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
63		) {
64		$PWAUrlParts = parse_url($this->tenantContext->getTenant()->getPWAConfig()->getUrl());
		0 ignored issues – show Bug introduced 2021-03-25 13:49 UTC by Report Bug Copy Issue Report The method `getPWAConfig()` does not seem to exist on `object<SWP\Component\Mul...\Model\TenantInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
65		$urlParts = parse_url($url);
66		$url = $PWAUrlParts['scheme'].'://'.$PWAUrlParts['host'].':'.$PWAUrlParts['port'].$urlParts['path'].'?'.$urlParts['query'];
67		}
68		return $url;
69		}
70		}
71

superdesk / web-publisher

Pull Request — master (#1198)

PwaAwareRouter::generate() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like