SWP\Bundle\CoreBundle\Serializer\ContentListItemsCountHandler

Complexity

Total Complexity

3

Size/Duplication

Total Lines	40
Duplicated Lines	27.5 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	serializeToJson()	0	12	1
A	getSubscribingMethods()	11	11	1

<?php

declare(strict_types=1);

/*
 * This file is part of the Superdesk Web Publisher Core Bundle.
 *
 * Copyright 2019 Sourcefabric z.ú. and contributors.
 *
 * For the full copyright and license information, please see the
 * AUTHORS and LICENSE files distributed with this source code.
 *
 * @copyright 2019 Sourcefabric z.ú
 * @license http://www.superdesk.org/license
 */

namespace SWP\Bundle\CoreBundle\Serializer;

use JMS\Serializer\GraphNavigator;
use JMS\Serializer\Handler\SubscribingHandlerInterface;
use JMS\Serializer\JsonSerializationVisitor;
use SWP\Bundle\CoreBundle\Repository\ContentListItemRepositoryInterface;
use SWP\Component\Common\Criteria\Criteria;

final class ContentListItemsCountHandler implements SubscribingHandlerInterface
{
    /**
     * @var ContentListItemRepositoryInterface
     */
    private $contentListItemRepository;

    public function __construct(ContentListItemRepositoryInterface $contentListItemRepository)
    {
        $this->contentListItemRepository = $contentListItemRepository;
    }

    /**
     * {@inheritdoc}
     */
    public static function getSubscribingMethods()

This method seems to be duplicated in your project.

    {
        return [
            [
                'direction' => GraphNavigator::DIRECTION_SERIALIZATION,
                'format' => 'json',
                'type' => 'SWP\Bundle\CoreBundle\Model\ContentListItemsCountInterface',
                'method' => 'serializeToJson',
            ],
        ];
    }

    public function serializeToJson(
        JsonSerializationVisitor $visitor,

The parameter $visitor is not used and could be removed.

        $data,

The parameter $data is not used and could be removed.

        $type,

The parameter $type is not used and could be removed.

        $context
    ) {
        $object = $context->getObject();
        $criteria = new Criteria();
        $criteria->set('contentList', $object);

        return $this->contentListItemRepository->getCountByCriteria($criteria, null);

The call to ContentListItemRepositoryInterface::getCountByCriteria() has too many arguments starting with null.

    }
}