SWP\Bundle\CoreBundle\Controller\RelatedArticleOrganizationController

Complexity

Total Complexity

12

Size/Duplication

Total Lines	94
Duplicated Lines	13.83 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getAction()	0	9	1
A	getRelatedAction()	0	8	1
B	getRelated()	3	39	8
A	findOr404()	10	10	2

<?php

declare(strict_types=1);

/*
 * This file is part of the Superdesk Web Publisher Core Bundle.
 *
 * Copyright 2019 Sourcefabric z.ú. and contributors.
 *
 * For the full copyright and license information, please see the
 * AUTHORS and LICENSE files distributed with this source code.
 *
 * @copyright 2019 Sourcefabric z.ú
 * @license http://www.superdesk.org/license
 */

namespace SWP\Bundle\CoreBundle\Controller;

use Nelmio\ApiDocBundle\Annotation\ApiDoc;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use SWP\Bundle\CoreBundle\Model\PackageInterface;
use SWP\Bundle\CoreBundle\Model\RelatedArticleList;
use SWP\Bundle\CoreBundle\Model\RelatedArticleListItem;
use SWP\Bundle\MultiTenancyBundle\MultiTenancyEvents;
use SWP\Component\Bridge\Model\GroupInterface;
use SWP\Component\Common\Exception\NotFoundHttpException;
use SWP\Component\Common\Response\SingleResourceResponse;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\Request;

class RelatedArticleOrganizationController extends Controller
{
    /**
     * @ApiDoc(
     *     resource=true,
     *     description="Returns a list of related articles",
     *     statusCodes={
     *         200="Returned on success"
     *     }
     * )
     * @Route("/api/{version}/organization/articles/related/", options={"expose"=true}, defaults={"version"="v1"}, name="swp_api_core_organization_related_articles")
     * @Method("POST")
     */
    public function getAction(Request $request)
    {
        $content = $request->getContent();
        $package = $this->get('swp_bridge.transformer.json_to_package')->transform($content);

        $relatedArticlesList = $this->getRelated($package);

        return new SingleResourceResponse($relatedArticlesList);
    }

    /**
     * @ApiDoc(
     *     resource=true,
     *     description="Returns a list of related articles",
     *     statusCodes={
     *         200="Returned on success"
     *     }
     * )
     * @Route("/api/{version}/packages/{id}/related/", options={"expose"=true}, defaults={"version"="v1"}, name="swp_api_core_packages_related_articles", requirements={"id"="\d+"})
     * @Method("GET")
     */
    public function getRelatedAction(string $id)
    {
        $package = $this->findOr404((int) $id);

        $relatedArticlesList = $this->getRelated($package);

        return new SingleResourceResponse($relatedArticlesList);
    }

    private function getRelated(PackageInterface $package): RelatedArticleList
    {
        $relatedItemsGroups = $package->getGroups()->filter(function ($group) {
            return GroupInterface::TYPE_RELATED === $group->getType();
        });

        $relatedArticlesList = new RelatedArticleList();

        if (null === $package || (null !== $package && 0 === \count($relatedItemsGroups))) {

This code seems to be duplicated across your project.

            return $relatedArticlesList;
        }

        $this->get('event_dispatcher')->dispatch(MultiTenancyEvents::TENANTABLE_DISABLE);
        $articleRepository = $this->get('swp.repository.article');

        foreach ($relatedItemsGroups as $relatedItemsGroup) {
            foreach ($relatedItemsGroup->getItems() as $item) {
                if (null === ($existingArticles = $articleRepository->findBy(['code' => $item->getGuid()]))) {
                    continue;
                }

                $tenants = [];
                foreach ($existingArticles as $existingArticle) {
                    $tenantCode = $existingArticle->getTenantCode();
                    $tenant = $this->get('swp.repository.tenant')->findOneByCode($tenantCode);

                    $tenants[] = $tenant;
                }

                $relatedArticleListItem = new RelatedArticleListItem();
                $relatedArticleListItem->setTenants($tenants);
                $relatedArticleListItem->setTitle($item->getHeadline());

                $relatedArticlesList->addRelatedArticleItem($relatedArticleListItem);
            }
        }

        return $relatedArticlesList;
    }

    private function findOr404(int $id): PackageInterface

This method seems to be duplicated in your project.

    {
        $this->get('event_dispatcher')->dispatch(MultiTenancyEvents::TENANTABLE_DISABLE);
        $tenantContext = $this->get('swp_multi_tenancy.tenant_context');
        if (null === $package = $this->get('swp.repository.package')->findOneBy(['id' => $id, 'organization' => $tenantContext->getTenant()->getOrganization()])) {
            throw new NotFoundHttpException('Package was not found.');
        }

        return $package;
    }
}