Completed
Pull Request — 2.1 (#1183)
by Greg
09:14
created
SWP/Bundle/StorageBundle/EventListener/ORMMappedSuperclassSubscriber.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -73,6 +73,9 @@  discard block
 block discarded – undo
73 73
         }
74 74
     }
75 75
 
76
+    /**
77
+     * @param string $className
78
+     */
76 79
     private function getResourceByClass($className)
77 80
     {
78 81
         foreach ($this->resources as $resource) {
@@ -86,7 +89,7 @@  discard block
 block discarded – undo
86 89
 
87 90
     /**
88 91
      * @param ClassMetadataInfo $metadata
89
-     * @param $configuration
92
+     * @param \Doctrine\ORM\Configuration $configuration
90 93
      */
91 94
     private function setAssociationMappings(ClassMetadataInfo $metadata, $configuration)
92 95
     {
Please login to merge, or discard this patch.
src/SWP/Bundle/ContentBundle/Manager/MediaManager.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -98,6 +98,9 @@
 block discarded – undo
98 98
         return $uri;
99 99
     }
100 100
 
101
+    /**
102
+     * @param string $fileName
103
+     */
101 104
     public function saveFile(UploadedFile $uploadedFile, $fileName): void
102 105
     {
103 106
         $filePath = $this->assetLocationResolver->getMediaBasePath().'/'.$fileName.'.'.$this->guessExtension($uploadedFile);
Please login to merge, or discard this patch.
src/SWP/Bundle/CoreBundle/Controller/ContentListItemController.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -307,6 +307,9 @@
 block discarded – undo
307 307
         return new SingleResourceResponse($form, new ResponseContext(400));
308 308
     }
309 309
 
310
+    /**
311
+     * @param ContentListInterface $listId
312
+     */
310 313
     private function findByContentOr404($listId, $contentId): ContentListItemInterface
311 314
     {
312 315
         /** @var ContentListItemInterface $listItem */
Please login to merge, or discard this patch.
src/SWP/Bundle/CoreBundle/MessageHandler/ImageConversionHandler.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -112,6 +112,9 @@
 block discarded – undo
112 112
         }
113 113
     }
114 114
 
115
+    /**
116
+     * @param ImageInterface $image
117
+     */
115 118
     private function markArticlesMediaAsUpdated($image)
116 119
     {
117 120
         /** @var ImageRenditionInterface[] $articleMedia */
Please login to merge, or discard this patch.
src/SWP/Bundle/CoreBundle/Provider/FailedEntriesProvider.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -34,6 +34,9 @@
 block discarded – undo
34 34
         $this->receiver = $receiver;
35 35
     }
36 36
 
37
+    /**
38
+     * @param integer $max
39
+     */
37 40
     public function getFailedEntries(?int $max): array
38 41
     {
39 42
         $envelopes = $this->receiver->all($max);
Please login to merge, or discard this patch.
src/SWP/Bundle/CoreBundle/AppleNews/Api/AppleNewsApi.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -119,6 +119,9 @@
 block discarded – undo
119 119
         return 'multipart/form-data; boundary='.$this->boundary;
120 120
     }
121 121
 
122
+    /**
123
+     * @param string $json
124
+     */
122 125
     public function post(string $path, $json, array $metadata = []): ResponseInterface
123 126
     {
124 127
         $multipartStream = new MultipartStream($this->generateData($json, $metadata), $this->boundary);
Please login to merge, or discard this patch.
src/SWP/Bundle/CoreBundle/Controller/AuthController.php 1 patch
Doc Comments   -85 removed lines patch added patch discarded remove patch
@@ -180,88 +180,3 @@
 block discarded – undo
180 180
                 return new SingleResourceResponse([
181 181
                     'status' => 401,
182 182
                     'message' => <<<'MESSAGE'
183
-Unauthorized (user not found in Superdesk). 
184
-Make sure that Publisher can talk to Superdesk instance. Set it's address in "SUPERDESK_SERVERS" environment variable.
185
-MESSAGE,
186
-                ], new ResponseContext(401));
187
-            }
188
-
189
-            $publisherUser = $userProvider->findOneByEmail($superdeskUser['email']);
190
-            if (null === $publisherUser) {
191
-                try {
192
-                    $publisherUser = $userProvider->loadUserByUsername($superdeskUser['username']);
193
-                } catch (UsernameNotFoundException $e) {
194
-                    $publisherUser = null;
195
-                }
196
-            }
197
-
198
-            if (null === $publisherUser) {
199
-                /** @var UserInterface $publisherUser */
200
-                $publisherUser = $userManager->createUser();
201
-                $publisherUser->setUsername($superdeskUser['username']);
202
-                $publisherUser->setEmail($superdeskUser['email']);
203
-                $publisherUser->setRoles(['ROLE_INTERNAL_API']);
204
-                $publisherUser->setFirstName(\array_key_exists('first_name', $superdeskUser) ? $superdeskUser['first_name'] : 'Anon.');
205
-                $publisherUser->setLastName(\array_key_exists('last_name', $superdeskUser) ? $superdeskUser['last_name'] : '');
206
-                $publisherUser->setPlainPassword(password_hash(random_bytes(36), PASSWORD_BCRYPT));
207
-                $publisherUser->setEnabled(true);
208
-                $userManager->updateUser($publisherUser);
209
-            }
210
-
211
-            if (null !== $publisherUser) {
212
-                return $this->returnApiTokenResponse($publisherUser, str_replace('Basic ', '', $formData['token']));
213
-            }
214
-        }
215
-
216
-        return new SingleResourceResponse([
217
-            'status' => 401,
218
-            'message' => 'Unauthorized',
219
-        ], new ResponseContext(401));
220
-    }
221
-
222
-    private function returnApiTokenResponse(UserInterface $user, string $token = null): SingleResourceResponseInterface
223
-    {
224
-        /** @var ApiKeyInterface $apiKey */
225
-        $apiKey = $this->generateOrGetApiKey($user, $token);
226
-
227
-        return new SingleResourceResponse([
228
-            'token' => [
229
-                'api_key' => $apiKey->getApiKey(),
230
-                'valid_to' => $apiKey->getValidTo(),
231
-            ],
232
-            'user' => $user,
233
-        ]);
234
-    }
235
-
236
-    private function generateOrGetApiKey(UserInterface $user, $token): ?ApiKeyInterface
237
-    {
238
-        $apiKey = null;
239
-        if (null !== $token) {
240
-            $apiKey = $this->apiKeyRepository->getValidToken($token)->getQuery()->getOneOrNullResult();
241
-        } else {
242
-            $validKeys = $this->apiKeyRepository->getValidTokenForUser($user)->getQuery()->getResult();
243
-            if (count($validKeys) > 0) {
244
-                $apiKey = reset($validKeys);
245
-            }
246
-        }
247
-
248
-        if (null === $apiKey) {
249
-            $apiKey = $this->apiKeyFactory->create($user, $token);
250
-
251
-            try {
252
-                $lock = $this->lockFactory->createLock(md5(json_encode(['type' => 'user_api_key', 'user' => $user->getId()])), 2);
253
-                if (!$lock->acquire()) {
254
-                    throw new RuntimeException('Other api key is created right now for this user');
255
-                }
256
-                $this->apiKeyRepository->add($apiKey);
257
-                $lock->release();
258
-            } catch (RuntimeException $e) {
259
-                sleep(2);
260
-
261
-                return $this->generateOrGetApiKey($user, $token);
262
-            }
263
-        }
264
-
265
-        return $apiKey;
266
-    }
267
-}
Please login to merge, or discard this patch.