AuthorRepository::findByCriteria() - Code Metrics - Inspection of "Improve full text search ES queries (#1150)" - superdesk/web-publisher - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 2.1 ( d7139b...4f94f6 )

by Rafał

created 2020-12-22 09:46 UTC

AuthorRepository::findByCriteria() A

↳ Parent: AuthorRepository

Complexity

Conditions	3
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	22
rs	9.568
c	0
b	0
f	0
cc	3
nc	2
nop	1

<?php

declare(strict_types=1);

/*
 * This file is part of the Superdesk Web Publisher ElasticSearch Bundle.
 *
 * Copyright 2017 Sourcefabric z.ú. and contributors.
 *
 * For the full copyright and license information, please see the
 * AUTHORS and LICENSE files distributed with this source code.
 *
 * @copyright 2017 Sourcefabric z.ú
 * @license http://www.superdesk.org/license
 */

namespace SWP\Bundle\ElasticSearchBundle\Repository;

use Elastica\Query;
use Elastica\Query\BoolQuery;
use Elastica\Query\MatchAll;
use FOS\ElasticaBundle\Paginator\PaginatorAdapterInterface;
use FOS\ElasticaBundle\Repository;
use SWP\Bundle\ElasticSearchBundle\Criteria\Criteria;

class AuthorRepository extends Repository
{
    public function findByCriteria(Criteria $criteria): PaginatorAdapterInterface
    {
        $boolFilter = new BoolQuery();

        if (null !== $criteria->getTerm() && '' !== $criteria->getTerm()) {
            $boolQuery = new BoolQuery();
            $term = $criteria->getTerm();

            $boolQuery->addShould(new Query\MatchPhrase('name', $term));
            $boolFilter->addMust($boolQuery);
        } else {
            $boolFilter->addMust(new MatchAll());
        }

        $query = Query::create($boolFilter)
            ->addSort([
                '_score' => 'desc',
                $criteria->getOrder()->getField() => $criteria->getOrder()->getDirection(),
            ]);

        return $this->createPaginatorAdapter($query);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* This file is part of the Superdesk Web Publisher ElasticSearch Bundle.
7			*
8			* Copyright 2017 Sourcefabric z.ú. and contributors.
9			*
10			* For the full copyright and license information, please see the
11			* AUTHORS and LICENSE files distributed with this source code.
12			*
13			* @copyright 2017 Sourcefabric z.ú
14			* @license http://www.superdesk.org/license
15			*/
16
17			namespace SWP\Bundle\ElasticSearchBundle\Repository;
18
19			use Elastica\Query;
20			use Elastica\Query\BoolQuery;
21			use Elastica\Query\MatchAll;
22			use FOS\ElasticaBundle\Paginator\PaginatorAdapterInterface;
23			use FOS\ElasticaBundle\Repository;
24			use SWP\Bundle\ElasticSearchBundle\Criteria\Criteria;
25
26			class AuthorRepository extends Repository
27			{
28			public function findByCriteria(Criteria $criteria): PaginatorAdapterInterface
29			{
30			$boolFilter = new BoolQuery();
31
32			if (null !== $criteria->getTerm() && '' !== $criteria->getTerm()) {
33			$boolQuery = new BoolQuery();
34			$term = $criteria->getTerm();
35
36			$boolQuery->addShould(new Query\MatchPhrase('name', $term));
37			$boolFilter->addMust($boolQuery);
38			} else {
39			$boolFilter->addMust(new MatchAll());
40			}
41
42			$query = Query::create($boolFilter)
43			->addSort([
44			'_score' => 'desc',
45			$criteria->getOrder()->getField() => $criteria->getOrder()->getDirection(),
46			]);
47
48			return $this->createPaginatorAdapter($query);
			0 ignored issues – show Documentation introduced 2017-05-16 08:37 UTC by Report Bug Copy Issue Report `$query` is of type `object<Elastica\Query>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
49			}
50			}
51

superdesk / web-publisher

Push — 2.1 ( d7139b...4f94f6 )

AuthorRepository::findByCriteria() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like