SWP\Bundle\CoreBundle\Repository\ArticleRepository

Complexity

Total Complexity

14

Size/Duplication

Total Lines	114
Duplicated Lines	14.04 %

Coupling/Cohesion

Components	2
Dependencies	5

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	getArticleByPackageExtraData()	0	13	1
A	getByCriteria()	8	8	1
A	getArticlesByCriteriaIds()	8	8	1
A	getArticleBySlugForPackage()	0	12	1
A	getArticlesByPackage()	0	10	1
A	getArticleByExtraData()	0	11	1
B	applySorting()	0	43	8

<?php

declare(strict_types=1);

/*
 * This file is part of the Superdesk Web Publisher Core Bundle.
 *
 * Copyright 2017 Sourcefabric z.ú. and contributors.
 *
 * For the full copyright and license information, please see the
 * AUTHORS and LICENSE files distributed with this source code.
 *
 * @copyright 2017 Sourcefabric z.ú
 * @license http://www.superdesk.org/license
 */

namespace SWP\Bundle\CoreBundle\Repository;

use Doctrine\ORM\QueryBuilder;
use SWP\Bundle\ContentBundle\Doctrine\ORM\ArticleRepository as ContentBundleArticleRepository;
use SWP\Bundle\CoreBundle\Model\ArticleEvent;
use SWP\Bundle\CoreBundle\Model\PackageInterface;
use SWP\Component\Common\Criteria\Criteria;

class ArticleRepository extends ContentBundleArticleRepository implements ArticleRepositoryInterface
{
    public function getByCriteria(Criteria $criteria, array $sorting): QueryBuilder

This method seems to be duplicated in your project.

    {
        $qb = parent::getByCriteria($criteria, $sorting)
            ->leftJoin('a.articleStatistics', 'stats')->addSelect('stats')
            ->leftJoin('a.externalArticle', 'ext')->addSelect('ext');

        return $qb;
    }

    public function getArticlesByCriteriaIds(Criteria $criteria): QueryBuilder

This method seems to be duplicated in your project.

    {
        $queryBuilder = parent::getArticlesByCriteriaIds($criteria)
            ->leftJoin('a.articleStatistics', 'stats')->addSelect('stats')
            ->leftJoin('a.externalArticle', 'ext')->addSelect('ext');

        return $queryBuilder;
    }

    public function getArticleBySlugForPackage(string $slug, PackageInterface $package): QueryBuilder
    {
        $queryBuilder = $this->createQueryBuilder('a');
        $queryBuilder
            ->where('a.slug = :slug')
                ->setParameter('slug', $slug)
            ->andWhere('a.package != :package')
                ->setParameter('package', $package)
        ;

        return $queryBuilder;
    }

    public function getArticlesByPackage(PackageInterface $package): QueryBuilder
    {
        $queryBuilder = $this->createQueryBuilder('a');
        $queryBuilder
            ->andWhere('a.package = :package')
            ->setParameter('package', $package)
        ;

        return $queryBuilder;
    }

    public function getArticleByPackageExtraData(string $key, string $value): QueryBuilder
    {
        $queryBuilder = $this->createQueryBuilder('a');
        $queryBuilder
            ->leftJoin('a.package', 'p')
            ->leftJoin('p.externalData', 'e')
            ->andWhere('e.key = :key')
            ->andWhere('e.value = :value')
            ->setParameters(['key' => $key, 'value' => $value])
        ;

        return $queryBuilder;
    }

    public function getArticleByExtraData(string $key, string $value): QueryBuilder
    {
        $criteria = new Criteria([
            'maxResults' => 1,
            'extra' => [
                $key => $value,
            ],
        ]);

        return $this->getArticlesByCriteria($criteria);
    }

    protected function applySorting(QueryBuilder $queryBuilder, array $sorting, string $alias, Criteria $criteria = null)
    {
        $properties = \array_merge($this->getClassMetadata()->getFieldNames(), $this->getClassMetadata()->getAssociationNames());
        foreach ($sorting as $property => $order) {
            if ('pageViews' === $property && !empty($order)) {
                if ($criteria instanceof Criteria && null !== $dateRange = $criteria->get('dateRange', null)) {
                    $start = new \DateTime();
                    $start->setTimestamp(strtotime($dateRange[0]));
                    $start->setTime(23, 59, 59);
                    $end = new \DateTime();
                    $end->setTimestamp(strtotime($dateRange[1]));
                    $end->setTime(0, 0, 0);

                    $articleEventsQuery = $this->_em->createQueryBuilder()
                        ->from(ArticleEvent::class, 'ae')
                        ->select('COUNT(ae.id)')
                        ->where('ae.createdAt <= :start')
                        ->andWhere('ae.createdAt >= :end')
                        ->andWhere('ae.articleStatistics = stats.id');

                    $queryBuilder
                        ->addSelect(sprintf('(%s) as HIDDEN events_count', $articleEventsQuery))
                        ->setParameter('start', $start)
                        ->setParameter('end', $end);
                    $queryBuilder->addOrderBy('events_count', $sorting['pageViews']);
                } else {
                    $queryBuilder->addOrderBy($this->getPropertyName('pageViewsNumber', 'stats'), $sorting['pageViews']);
                }
                unset($sorting['pageViews']);

                continue;
            }

            if (!\in_array($property, $properties)) {
                continue;
            }

            if (!empty($order)) {
                $queryBuilder->addOrderBy($this->getPropertyName($property, $alias), $order);
                unset($sorting[$property]);
            }
        }
    }
}