SWP\Bundle\CoreBundle\AppleNews\Api\AppleNewsApi

Complexity

Total Complexity

10

Size/Duplication

Total Lines	112
Duplicated Lines	16.07 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	createArticle()	9	9	1
A	updateArticle()	9	9	1
A	deleteArticle()	0	9	1
A	generateData()	0	25	2
A	generateHhmacSignature()	0	7	1
A	getAuthorizationSignature()	0	10	1
A	getContentType()	0	4	1
A	post()	0	13	1

<?php

declare(strict_types=1);

/*
 * This file is part of the Superdesk Web Publisher Core Bundle.
 *
 * Copyright 2020 Sourcefabric z.ú. and contributors.
 *
 * For the full copyright and license information, please see the
 * AUTHORS and LICENSE files distributed with this source code.
 *
 * @copyright 2020 Sourcefabric z.ú
 * @license http://www.superdesk.org/license
 */

namespace SWP\Bundle\CoreBundle\AppleNews\Api;

use GuzzleHttp\Client;
use GuzzleHttp\Psr7\MultipartStream;
use Psr\Http\Message\ResponseInterface;
use SWP\Bundle\CoreBundle\AppleNews\Api\Response\AppleNewsArticle;

final class AppleNewsApi
{
    private $httpClient;

    private $apiKeyId;

    private $apiKeySecret;

    private $boundary;

    public function __construct(Client $httpClient, string $apiKeyId, string $apiKeySecret)
    {
        $this->httpClient = $httpClient;
        $this->apiKeyId = $apiKeyId;
        $this->apiKeySecret = $apiKeySecret;
        $this->boundary = substr(md5(microtime()), random_int(0, 26), 64);
    }

    public function createArticle(string $channelId, string $json, array $metadata = []): AppleNewsArticle

This method seems to be duplicated in your project.

    {
        $path = "/channels/$channelId/articles";
        $response = $this->post($path, $json, $metadata);

        $jsonResponse = json_decode($response->getBody()->getContents(), true, 512, JSON_THROW_ON_ERROR);

        return AppleNewsArticle::fromRawResponse($jsonResponse);
    }

    public function updateArticle(string $articleId, string $json, array $metadata = []): AppleNewsArticle

This method seems to be duplicated in your project.

    {
        $path = "/articles/$articleId";
        $response = $this->post($path, $json, $metadata);

        $jsonResponse = json_decode($response->getBody()->getContents(), true, 512, JSON_THROW_ON_ERROR);

        return AppleNewsArticle::fromRawResponse($jsonResponse);
    }

    public function deleteArticle(string $articleId): void
    {
        $path = "/articles/$articleId";
        $this->httpClient->delete($path, [
            'headers' => [
                'Authorization' => $this->getAuthorizationSignature('DELETE', $path),
            ],
        ]);
    }

    private function generateData(string $json, array $metadata): array
    {
        $data = [
            [
                'name' => 'article',
                'filename' => 'article.json',
                'contents' => $json,
                'headers' => [
                    'Content-Type' => 'application/json',
                ],
            ],
        ];

        if (!empty($metadata)) {
            $data[] = [
                'name' => 'metadata',
                'contents' => json_encode(['data' => $metadata], JSON_THROW_ON_ERROR, 512),
                'headers' => [
                    'Content-Type' => 'application/json',
                ],
            ];
        }

        return $data;
    }

    private function generateHhmacSignature(string $message): string
    {
        $keyBytes = base64_decode($this->apiKeySecret);
        $hashed = hash_hmac('sha256', $message, $keyBytes, true);

        return base64_encode($hashed);
    }

    private function getAuthorizationSignature(string $method, string $path, string $content = ''): string
    {
        $date = gmdate(\DateTime::ATOM);
        $url = ClientFactory::BASE_URI.$path;
        $canonical = $method.$url.$date.$content;

        $signature = $this->generateHhmacSignature($canonical, $this->apiKeySecret);

The call to AppleNewsApi::generateHhmacSignature() has too many arguments starting with $this->apiKeySecret.

        return 'HHMAC; key="'.$this->apiKeyId.'"; signature="'.$signature.'"; date="'.$date.'"';
    }

    private function getContentType(): string
    {
        return 'multipart/form-data; boundary='.$this->boundary;
    }

    public function post(string $path, $json, array $metadata = []): ResponseInterface
    {
        $multipartStream = new MultipartStream($this->generateData($json, $metadata), $this->boundary);

        return $this->httpClient->post($path, [
            'body' => $multipartStream,
            'headers' => [
                'Authorization' => $this->getAuthorizationSignature('POST', $path, $this->getContentType().$multipartStream->getContents()),
                'Content-Type' => $this->getContentType(),
                'Content-Length' => strlen($json),
            ],
        ]);
    }
}