ItemAdapter::getSlice() - Code Metrics - Inspection of "Merge pull request #22 from m038/master" - superdesk/contentapi-sdk-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( bd326e...3b0d07 )

by Paweł

created 2016-01-18 15:52 UTC

ItemAdapter::getSlice() A

↳ Parent: ItemAdapter

Complexity

Conditions	3
Paths	3

Size

Total Lines	15
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	15
rs	9.4285
cc	3
eloc	9
nc	3
nop	2

<?php

/**
 * This file is part of the PHP SDK library for the Superdesk Content API.
 *
 * Copyright 2015 Sourcefabric z.u. and contributors.
 *
 * For the full copyright and license information, please see the
 * AUTHORS and LICENSE files distributed with this source code.
 *
 * @copyright 2015 Sourcefabric z.ú.
 * @license http://www.superdesk.org/license
 */

namespace Superdesk\ContentApiSdk\Api\Pagerfanta;

use Superdesk\ContentApiSdk\Data\Item;
use Superdesk\ContentApiSdk\Exception\InvalidDataException;
use Exception;

/**
 * Adapter for items.
 */
class ItemAdapter extends ResourceAdapter
{
    /**
     * {@inheritdoc}
     */
    public function getSlice($offset, $length)
    {
        $items = array();
        $resources = parent::getSlice($offset, $length);

        try {
            foreach ($resources as $itemData) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                $items[] = new Item($itemData);
            }
        } catch (Exception $e) {
            throw new InvalidDataException('Could not convert resources to items.', $e->getCode(), $e);
        }

        return $items;
    }
}


1			<?php
2
3			/**
4			* This file is part of the PHP SDK library for the Superdesk Content API.
5			*
6			* Copyright 2015 Sourcefabric z.u. and contributors.
7			*
8			* For the full copyright and license information, please see the
9			* AUTHORS and LICENSE files distributed with this source code.
10			*
11			* @copyright 2015 Sourcefabric z.ú.
12			* @license http://www.superdesk.org/license
13			*/
14
15			namespace Superdesk\ContentApiSdk\Api\Pagerfanta;
16
17			use Superdesk\ContentApiSdk\Data\Item;
18			use Superdesk\ContentApiSdk\Exception\InvalidDataException;
19			use Exception;
20
21			/**
22			* Adapter for items.
23			*/
24			class ItemAdapter extends ResourceAdapter
25			{
26			/**
27			* {@inheritdoc}
28			*/
29			public function getSlice($offset, $length)
30			{
31			$items = array();
32			$resources = parent::getSlice($offset, $length);
33
34			try {
35			foreach ($resources as $itemData) {
			0 ignored issues – show Bug introduced 2016-01-18 15:53 UTC by Report Bug Copy Issue Report The expression `$resources` of type `array\|object<stdClass>` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
36			$items[] = new Item($itemData);
37			}
38			} catch (Exception $e) {
39			throw new InvalidDataException('Could not convert resources to items.', $e->getCode(), $e);
40			}
41
42			return $items;
43			}
44			}
45

superdesk / contentapi-sdk-php

Push — master ( bd326e...3b0d07 )

ItemAdapter::getSlice() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like