Superdesk\ContentApiSdk\Api\Pagerfanta\PackageAdapter

Complexity

Total Complexity

6

Size/Duplication

Total Lines	62
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	11	1
B	getSlice()	0	22	5

<?php

/**
 * This file is part of the PHP SDK library for the Superdesk Content API.
 *
 * Copyright 2015 Sourcefabric z.u. and contributors.
 *
 * For the full copyright and license information, please see the
 * AUTHORS and LICENSE files distributed with this source code.
 *
 * @copyright 2015 Sourcefabric z.ú.
 * @license http://www.superdesk.org/license
 */

namespace Superdesk\ContentApiSdk\Api\Pagerfanta;

use Superdesk\ContentApiSdk\Api\Request\RequestInterface;
use Superdesk\ContentApiSdk\Client\ApiClientInterface;
use Superdesk\ContentApiSdk\ContentApiSdk;
use Superdesk\ContentApiSdk\Data\Package;
use Superdesk\ContentApiSdk\Exception\InvalidDataException;
use Exception;

/**
 * Adapter for package.
 */
class PackageAdapter extends ResourceAdapter
{
    /**
     * SDK Instance.
     *
     * @var ContentApiSdk
     */
    protected $apiInstance;

    /**
     * Resolve package associations.
     *
     * @var boolean
     */
    protected $resolveAssociations;

    /**
     * Instantiate object.
     *
     * @param ApiClientInterface $client HTTP client
     * @param RequestInterface $request API Request is_object(var)
     * @param ContentApiSdk $apiInstance SDK Instance
     * @param boolean $resolveAssociations Resolve package associations
     */
    public function __construct(
        ApiClientInterface $client,
        RequestInterface $request,
        ContentApiSdk $apiInstance,
        $resolveAssociations
    ) {
        parent::__construct($client, $request);

        $this->apiInstance = $apiInstance;
        $this->resolveAssociations = $resolveAssociations;
    }

    /**
     * {@inheritdoc}
     */
    public function getSlice($offset, $length)
    {
        $packages = array();
        $resources = parent::getSlice($offset, $length);

        try {
            foreach ($resources as $itemData) {

The expression $resources of type array|object<stdClass> is not guaranteed to be traversable. How about adding an additional type check?

                $packages[] = new Package($itemData);
            }

            if ($this->resolveAssociations) {
                foreach ($packages as $id => $package) {
                    $associations = $this->apiInstance->getAssociationsFromPackage($package);
                    $packages[$id] = $this->apiInstance->injectAssociations($package, $associations);
                }
            }
        } catch (Exception $e) {
            throw new InvalidDataException('Could not convert resources to packages.', $e->getCode(), $e);
        }

        return $packages;
    }
}