TransactionStatusResponse::isSuccessful() - Code Metrics - Inspection of "Fixed the status 'COMPLETED' in the expected respo..." - superbrave/omnipay-icepay-payments - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — fixed-transaction-status-respo... ( 02a72c...732abb )

by Kiet

created 2020-02-26 15:47 UTC

TransactionStatusResponse::isSuccessful() A

↳ Parent: TransactionStatusResponse

Complexity

Conditions	4
Paths	5

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	4

Importance

Changes	4
Bugs	0	Features	1

Metric	Value
cc	4
eloc	4
c	4
b	0
f	1
nc	5
nop	0
dl	0
loc	6
ccs	5
cts	5
cp	1
crap	4
rs	10

<?php

namespace Omnipay\IcepayPayments\Message;

/**
 * The response after getting the transaction status at Icepay.
 */
class TransactionStatusResponse extends AbstractResponse
{
    /**
     * {@inheritdoc}
     */
    public function isSuccessful(): bool
    {
        return (isset($this->data['status']) && in_array($this->data['status'], [
            self::RESPONSE_STATUS_COMPLETED,
            self::RESPONSE_STATUS_SETTLED,
        ])) && (isset($this->data['statusCode']) && $this->data['statusCode'] === 200);
    }

    /**
     * {@inheritdoc}
     */
    public function isCancelled(): bool
    {
        return parent::isCancelled() || $this->data['statusCode'] === self::RESPONSE_STATUS_CANCELLED;
    }

    /**
     * {@inheritdoc}
     */
    public function getTransactionReference(): ?string
    {
        return $this->request->getTransactionReference();
    }
}


1		<?php
2
3		namespace Omnipay\IcepayPayments\Message;
4
5		/**
6		* The response after getting the transaction status at Icepay.
7		*/
8		class TransactionStatusResponse extends AbstractResponse
9		{
10		/**
11		* {@inheritdoc}
12		*/
13	2	public function isSuccessful(): bool
14		{
15	2	return (isset($this->data['status']) && in_array($this->data['status'], [
16	1	self::RESPONSE_STATUS_COMPLETED,
17	2	self::RESPONSE_STATUS_SETTLED,
18	2	])) && (isset($this->data['statusCode']) && $this->data['statusCode'] === 200);
19		}
20
21		/**
22		* {@inheritdoc}
23		*/
24	1	public function isCancelled(): bool
25		{
26	1	return parent::isCancelled() \|\| $this->data['statusCode'] === self::RESPONSE_STATUS_CANCELLED;
27		}
28
29		/**
30		* {@inheritdoc}
31		*/
32	1	public function getTransactionReference(): ?string
33		{
34	1	return $this->request->getTransactionReference();
35		}
36		}
37

superbrave / omnipay-icepay-payments

Push — fixed-transaction-status-respo... ( 02a72c...732abb )

TransactionStatusResponse::isSuccessful() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like