CompleteAuthorizeResponse::getTransactionReference() - Code Metrics - Inspection of "refactor: Icepay Payments implementation." - superbrave/omnipay-icepay-payments - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#20)

by Kiet

created 2021-04-07 10:30 UTC

getTransactionReference() A

↳ Parent: CompleteAuthorizeResponse

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	1
c	1
b	0
f	0
nc	1
nop	0
dl	0
loc	3
ccs	2
cts	2
cp	1
crap	1
rs	10

<?php

declare(strict_types=1);

namespace Omnipay\IcepayPayments\Message;

use Omnipay\Common\Message\RequestInterface;

class CompleteAuthorizeResponse extends AbstractResponse
{
    /**
     * The response status code.
     *
     * @var int
     */
    private $statusCode;

    public function __construct(RequestInterface $request, int $statusCode, $data)
    {
        parent::__construct($request, $data);

        $this->statusCode = $statusCode;
    }

    /**
     * {@inheritdoc}
     */
    public function isSuccessful(): bool
    {
        return $this->getTransactionStatus() === self::TRANSACTION_STATUS_COMPLETED;
    }

    /**
     * {@inheritdoc}
     */
    public function isCancelled(): bool
    {
        return $this->getTransactionStatus() === self::TRANSACTION_STATUS_CANCELLED;
    }

    /**
     * {@inheritdoc}
     */
    public function getCode(): int
    {
        return $this->statusCode;
    }

    /**
     * {@inheritdoc}
     */
    public function getTransactionReference(): ?string
    {
        return $this->data['id'] ?? null;
    }

    /**
     * {@inheritdoc}
     *
     * Fallback on the postback data that was given by ICEPAY when the transaction cannot be found.
     * Do note: this is not a reliable way of checking the transaction status.
     *
     * @see https://documentation.icepay.com/payments/payment-process/payment-feedback/postback/
     */
    protected function getTransactionStatus(): ?string
    {
        if ($this->getCode() === 404) {
            return $this->request->getHttpRequest()->query->getAlpha('statusCode', null);
            return $this->request->/** @scrutinizer ignore-call */ getHttpRequest()->query->getAlpha('statusCode', null);
        }

        return $this->data['status'] ?? null;
    }
}


superbrave / omnipay-icepay-payments

Pull Request — master (#20)

getTransactionReference() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like