Issues in validators.py (master) - Issues in master - sunscrapers/djoser - Measure and Improve Code Quality continuously with Scrutinizer

Issues (463)

testproject/testapp/validators.py (6 issues)

Labels

Coding Style 4
Unused Code 2

Severity

Minor 2
Informational 4

from django.core.exceptions import ValidationError
class SomeClass:
    def some_method(self):
        """Do x and return foo."""


class Is666(object):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    def validate(self, password, *args, **kwargs):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        if password == "666":
            raise ValidationError("Password 666 is not allowed.", code="no666")


1			from django.core.exceptions import ValidationError
			0 ignored issues – show Coding Style introduced 2017-08-24 11:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this This module should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
2
3
4			class Is666(object):
			0 ignored issues – show Coding Style introduced 2017-08-24 11:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
5			def validate(self, password, args, *kwargs):
			0 ignored issues – show Coding Style introduced 2017-08-24 11:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2017-08-24 11:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this The argument `args` seems to be unused. Loading history... Unused Code introduced 2017-08-24 11:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this The argument `kwargs` seems to be unused. Loading history... Coding Style introduced 2017-08-24 11:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method could be written as a function/class method. If a method does not access any attributes of the class, it could also be implemented as a function or static method. This can help improve readability. For example class Foo: def some_method(self, x, y): return x + y; could be written as class Foo: @classmethod def some_method(cls, x, y): return x + y; Loading history...
6			if password == "666":
7			raise ValidationError("Password 666 is not allowed.", code="no666")
8

sunscrapers / djoser

Issues (463)

testproject/testapp/validators.py (6 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like