Issues in permissions.py (master) - Issues in master - sunscrapers/djoser - Measure and Improve Code Quality continuously with Scrutinizer

Issues (463)

djoser/permissions.py (4 issues)

Labels

Coding Style 3

Severity

Informational 4

from rest_framework import permissions
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
from rest_framework.permissions import SAFE_METHODS


class CurrentUserOrAdmin(permissions.IsAuthenticated):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    def has_object_permission(self, request, view, obj):
        user = request.user
        return user.is_staff or obj.pk == user.pk


class CurrentUserOrAdminOrReadOnly(permissions.IsAuthenticated):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    def has_object_permission(self, request, view, obj):
        user = request.user
        if type(obj) == type(user) and obj == user:

            return True
        return request.method in SAFE_METHODS or user.is_staff


1			from rest_framework import permissions
			0 ignored issues – show Coding Style introduced 2018-11-17 10:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this This module should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
2			from rest_framework.permissions import SAFE_METHODS
3
4
5			class CurrentUserOrAdmin(permissions.IsAuthenticated):
			0 ignored issues – show Coding Style introduced 2018-11-17 10:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
6			def has_object_permission(self, request, view, obj):
7			user = request.user
8			return user.is_staff or obj.pk == user.pk
9
10
11			class CurrentUserOrAdminOrReadOnly(permissions.IsAuthenticated):
			0 ignored issues – show Coding Style introduced 2019-01-09 20:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
12			def has_object_permission(self, request, view, obj):
13			user = request.user
14			if type(obj) == type(user) and obj == user:
			0 ignored issues – show introduced 2019-01-09 20:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Using type() instead of isinstance() for a typecheck. Loading history...
15			return True
16			return request.method in SAFE_METHODS or user.is_staff
17

sunscrapers / djoser

Issues (463)

djoser/permissions.py (4 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like