ProviderAuthView.get() - Code Metrics - Inspection of "Add integration with social-django" - sunscrapers/djoser - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#244)

by Piotr

created 2017-11-02 23:46 UTC

ProviderAuthView.get() A

↳ Parent: ProviderAuthView

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	13
rs	9.4285
cc	1

from rest_framework import generics, permissions
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
from rest_framework.response import Response


from social_django.utils import load_backend, load_strategy


from djoser.social.serializers import ProviderAuthSerializer


class ProviderAuthView(generics.CreateAPIView):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    permission_classes = [permissions.AllowAny]
    serializer_class = ProviderAuthSerializer

    def get(self, request, *args, **kwargs):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        redirect_uri = request.GET.get('redirect_uri') or 'http://localhost/'
        strategy = load_strategy(request)
        strategy.session_set('redirect_uri', redirect_uri)

        backend_name = self.kwargs['provider']
        backend = load_backend(
            strategy, backend_name, redirect_uri=redirect_uri

        )
        authorization_url = backend.auth_url()
        return Response(data={
            'authorization_url': authorization_url,
        })


1			from rest_framework import generics, permissions
			0 ignored issues – show Coding Style introduced 2017-11-02 22:04 UTC by Report Bug Copy Issue Report This module should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... introduced 2017-11-02 22:04 UTC by Report Bug Copy Issue Report Unable to import 'rest_framework' Loading history...
2			from rest_framework.response import Response
			0 ignored issues – show introduced 2017-11-02 22:04 UTC by Report Bug Copy Issue Report Unable to import 'rest_framework.response' Loading history...
3
4			from social_django.utils import load_backend, load_strategy
			0 ignored issues – show introduced 2017-11-02 22:04 UTC by Report Bug Copy Issue Report Unable to import 'social_django.utils' Loading history...
5
6			from djoser.social.serializers import ProviderAuthSerializer
7
8
9			class ProviderAuthView(generics.CreateAPIView):
			0 ignored issues – show Coding Style introduced 2017-11-02 22:04 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
10			permission_classes = [permissions.AllowAny]
11			serializer_class = ProviderAuthSerializer
12
13			def get(self, request, args, *kwargs):
			0 ignored issues – show Coding Style introduced 2017-11-02 22:04 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2017-11-02 22:04 UTC by Report Bug Copy Issue Report The argument `args` seems to be unused. Loading history... Unused Code introduced 2017-11-02 22:04 UTC by Report Bug Copy Issue Report The argument `kwargs` seems to be unused. Loading history...
14			redirect_uri = request.GET.get('redirect_uri') or 'http://localhost/'
15			strategy = load_strategy(request)
16			strategy.session_set('redirect_uri', redirect_uri)
17
18			backend_name = self.kwargs['provider']
19			backend = load_backend(
20			strategy, backend_name, redirect_uri=redirect_uri
21
22			)
23			authorization_url = backend.auth_url()
24			return Response(data={
25			'authorization_url': authorization_url,
26			})
27

sunscrapers / djoser

Pull Request — master (#244)

ProviderAuthView.get() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like