ProviderAuthSerializer - Code Metrics - Inspection of "Add integration with social-django" - sunscrapers/djoser - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#244)

by Piotr

created 2017-11-02 22:03 UTC

ProviderAuthSerializer A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	4
c	1
b	0
f	0
dl	0
loc	32
rs	10

3 Methods

Rating	Name	Size	Complexity
A	validate_state()	13	2
A	update()	2	1
A	create()	9	1

from rest_framework import serializers
class SomeClass:
    def some_method(self):
        """Do x and return foo."""

from social_core import exceptions

from social_django.utils import load_backend, load_strategy



class ProviderAuthSerializer(serializers.Serializer):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    id = serializers.IntegerField(read_only=True)

    email = serializers.CharField(read_only=True)
    code = serializers.CharField(write_only=True)
    state = serializers.CharField(required=False, write_only=True)

    def create(self, validated_data):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        strategy = load_strategy(self.context['request'])
        redirect_uri = strategy.session_get('redirect_uri')

        backend_name = self.context['view'].kwargs['provider']
        backend = load_backend(
            strategy, backend_name, redirect_uri=redirect_uri
        )
        return backend.auth_complete()

    def update(self, instance, validated_data):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        pass

    def validate_state(self, value):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        strategy = load_strategy(self.context['request'])
        redirect_uri = strategy.session_get('redirect_uri')

        backend_name = self.context['view'].kwargs['provider']
        backend = load_backend(
            strategy, backend_name, redirect_uri=redirect_uri
        )

        try:
            backend.validate_state()
        except exceptions.AuthException:
            raise serializers.ValidationError('State could not be verified.')


1			from rest_framework import serializers
			0 ignored issues – show Coding Style introduced 2017-11-02 22:04 UTC by Report Bug Copy Issue Report This module should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... introduced 2017-11-02 22:04 UTC by Report Bug Copy Issue Report Unable to import 'rest_framework' Loading history...
2
3			from social_core import exceptions
			0 ignored issues – show introduced 2017-11-02 22:04 UTC by Report Bug Copy Issue Report Unable to import 'social_core' Loading history...
4			from social_django.utils import load_backend, load_strategy
			0 ignored issues – show introduced 2017-11-02 22:04 UTC by Report Bug Copy Issue Report Unable to import 'social_django.utils' Loading history...
5
6
7			class ProviderAuthSerializer(serializers.Serializer):
			0 ignored issues – show Coding Style introduced 2017-11-02 22:04 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
8			id = serializers.IntegerField(read_only=True)
			0 ignored issues – show Coding Style Naming introduced 2017-11-02 22:04 UTC by Report Bug Copy Issue Report The name `id` does not conform to the class attribute naming conventions (`([A-Za-z_][A-Za-z0-9_]{2,30}\|(__.*__))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
9			email = serializers.CharField(read_only=True)
10			code = serializers.CharField(write_only=True)
11			state = serializers.CharField(required=False, write_only=True)
12
13			def create(self, validated_data):
			0 ignored issues – show Coding Style introduced 2017-11-02 22:04 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2017-11-02 22:04 UTC by Report Bug Copy Issue Report The argument `validated_data` seems to be unused. Loading history...
14			strategy = load_strategy(self.context['request'])
15			redirect_uri = strategy.session_get('redirect_uri')
16
17			backend_name = self.context['view'].kwargs['provider']
18			backend = load_backend(
19			strategy, backend_name, redirect_uri=redirect_uri
20			)
21			return backend.auth_complete()
22
23			def update(self, instance, validated_data):
			0 ignored issues – show Coding Style introduced 2017-11-02 22:04 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
24			pass
25
26			def validate_state(self, value):
			0 ignored issues – show Coding Style introduced 2017-11-02 22:04 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2017-11-02 22:04 UTC by Report Bug Copy Issue Report The argument `value` seems to be unused. Loading history...
27			strategy = load_strategy(self.context['request'])
28			redirect_uri = strategy.session_get('redirect_uri')
29
30			backend_name = self.context['view'].kwargs['provider']
31			backend = load_backend(
32			strategy, backend_name, redirect_uri=redirect_uri
33			)
34
35			try:
36			backend.validate_state()
37			except exceptions.AuthException:
38			raise serializers.ValidationError('State could not be verified.')
39

sunscrapers / djoser

Pull Request — master (#244)

ProviderAuthSerializer A

Complexity

Size/Duplication

Importance

3 Methods

Duplication Side-by-Side

Filter issues like