test_invalid_serialize_request_wrong_uid() - Code Metrics - Inspection of "[WIP] Version 2.0" - sunscrapers/djoser - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#259)

by Piotr

created 2018-01-16 01:16 UTC

test_invalid_serialize_request_wrong_uid() A

↳ Parent: Project

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
c	1
b	0
f	0
dl	0
loc	11
rs	9.4285

import pytest
class SomeClass:
    def some_method(self):
        """Do x and return foo."""

from django.contrib.auth import get_user_model

from django.contrib.auth.tokens import default_token_generator


from djoser import exceptions, pipelines, signals, utils
from tests.common import catch_signal, mock

User = get_user_model()



@pytest.mark.django_db(transaction=False)
def test_valid_serialize_request(test_inactive_user):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    request = mock.MagicMock()
    request.data = {
        'uid': utils.encode_uid(test_inactive_user.pk),
        'token': default_token_generator.make_token(test_inactive_user)
    }
    result = pipelines.user_activate.serialize_request(request, {})

    assert 'serializer' in result
    assert 'user' in result['serializer'].validated_data
    assert result['serializer'].validated_data['user'] == test_inactive_user


@pytest.mark.django_db(transaction=False)
def test_invalid_serialize_request_wrong_uid():
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    request = mock.MagicMock()
    request.data = {
        'uid': utils.encode_uid(1),
        'token': 'whatever',
    }
    with pytest.raises(exceptions.ValidationError) as e:

        pipelines.user_activate.serialize_request(request, {})

    assert e.value.errors == {
        'non_field_errors': ["Invalid user id or user doesn't exist."]
    }


def test_invalid_serialize_request_stale_token(test_user):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    request = mock.MagicMock()
    request.data = {
        'uid': utils.encode_uid(test_user.pk),
        'token': default_token_generator.make_token(test_user),
    }
    with pytest.raises(exceptions.ValidationError) as e:

        pipelines.user_activate.serialize_request(request, {})

    assert e.value.errors == {
        'non_field_errors': ['Stale token for given user.']
    }


@pytest.mark.django_db(transaction=False)
def test_valid_perform(test_inactive_user):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    serializer = mock.MagicMock()
    serializer.validated_data = {'user': test_inactive_user}
    context = {'serializer': serializer}

    assert test_inactive_user.is_active is False
    result = pipelines.user_activate.perform(None, context)
    assert test_inactive_user.is_active is True
    assert result['user'] == test_inactive_user


def test_valid_signal(test_user):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    request = mock.MagicMock()
    context = {'user': test_user}

    with catch_signal(signals.user_activated) as handler:
        pipelines.user_activate.signal(request, context)

    handler.assert_called_once_with(
        sender=mock.ANY,
        signal=signals.user_activated,
        user=test_user,
        request=request
    )


@pytest.mark.django_db(transaction=False)
def test_valid_pipeline(test_inactive_user):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    request = mock.MagicMock()
    request.data = {
        'uid': utils.encode_uid(test_inactive_user.pk),
        'token': default_token_generator.make_token(test_inactive_user)
    }

    pipeline = pipelines.user_activate.Pipeline(request)
    with catch_signal(signals.user_activated) as handler:
        result = pipeline.run()

    handler.assert_called_once_with(
        sender=mock.ANY,
        signal=signals.user_activated,
        user=result['user'],
        request=request
    )

    assert test_inactive_user.is_active is False
    test_inactive_user.refresh_from_db()
    assert test_inactive_user.is_active is True


1			import pytest
			0 ignored issues – show Coding Style introduced 2018-01-15 18:28 UTC by Report Bug Copy Issue Report This module should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... introduced 2018-01-15 18:28 UTC by Report Bug Copy Issue Report Unable to import 'pytest' Loading history... Bug introduced 2018-01-15 18:28 UTC by Report Bug Copy Issue Report There seems to be a cyclic import (djoser.urls.base -> djoser.views). Cyclic imports may cause partly loaded modules to be returned. This might lead to unexpected runtime behavior which is hard to debug. Loading history... Bug introduced 2018-01-15 18:28 UTC by Report Bug Copy Issue Report There seems to be a cyclic import (djoser.urls.authtoken -> djoser.views). Cyclic imports may cause partly loaded modules to be returned. This might lead to unexpected runtime behavior which is hard to debug. Loading history...
2
3			from django.contrib.auth import get_user_model
			0 ignored issues – show introduced 2018-01-16 01:14 UTC by Report Bug Copy Issue Report Unable to import 'django.contrib.auth' Loading history...
4			from django.contrib.auth.tokens import default_token_generator
			0 ignored issues – show introduced 2017-08-24 11:14 UTC by Report Bug Copy Issue Report Unable to import 'django.contrib.auth.tokens' Loading history...
5
6			from djoser import exceptions, pipelines, signals, utils
7			from tests.common import catch_signal, mock
8
9			User = get_user_model()
			0 ignored issues – show Coding Style Naming introduced 2018-01-16 01:14 UTC by Report Bug Copy Issue Report The name `User` does not conform to the constant naming conventions (`(([A-Z_][A-Z0-9_])\|(__.__))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
10
11
12			@pytest.mark.django_db(transaction=False)
13			def test_valid_serialize_request(test_inactive_user):
			0 ignored issues – show Coding Style introduced 2018-01-15 18:28 UTC by Report Bug Copy Issue Report This function should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
14			request = mock.MagicMock()
15			request.data = {
16			'uid': utils.encode_uid(test_inactive_user.pk),
17			'token': default_token_generator.make_token(test_inactive_user)
18			}
19			result = pipelines.user_activate.serialize_request(request, {})
20
21			assert 'serializer' in result
22			assert 'user' in result['serializer'].validated_data
23			assert result['serializer'].validated_data['user'] == test_inactive_user
24
25
26			@pytest.mark.django_db(transaction=False)
27			def test_invalid_serialize_request_wrong_uid():
			0 ignored issues – show Coding Style Naming introduced 2018-01-15 18:28 UTC by Report Bug Copy Issue Report The name `test_invalid_serialize_request_wrong_uid` does not conform to the function naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history... Coding Style introduced 2018-01-15 18:28 UTC by Report Bug Copy Issue Report This function should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
28			request = mock.MagicMock()
29			request.data = {
30			'uid': utils.encode_uid(1),
31			'token': 'whatever',
32			}
33			with pytest.raises(exceptions.ValidationError) as e:
			0 ignored issues – show Coding Style Naming introduced 2018-01-15 18:28 UTC by Report Bug Copy Issue Report The name `e` does not conform to the variable naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
34			pipelines.user_activate.serialize_request(request, {})
35
36			assert e.value.errors == {
37			'non_field_errors': ["Invalid user id or user doesn't exist."]
38			}
39
40
41			def test_invalid_serialize_request_stale_token(test_user):
			0 ignored issues – show Coding Style Naming introduced 2018-01-15 18:28 UTC by Report Bug Copy Issue Report The name `test_invalid_serialize_request_stale_token` does not conform to the function naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history... Coding Style introduced 2018-01-15 18:28 UTC by Report Bug Copy Issue Report This function should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
42			request = mock.MagicMock()
43			request.data = {
44			'uid': utils.encode_uid(test_user.pk),
45			'token': default_token_generator.make_token(test_user),
46			}
47			with pytest.raises(exceptions.ValidationError) as e:
			0 ignored issues – show Coding Style Naming introduced 2018-01-16 01:14 UTC by Report Bug Copy Issue Report The name `e` does not conform to the variable naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
48			pipelines.user_activate.serialize_request(request, {})
49
50			assert e.value.errors == {
51			'non_field_errors': ['Stale token for given user.']
52			}
53
54
55			@pytest.mark.django_db(transaction=False)
56			def test_valid_perform(test_inactive_user):
			0 ignored issues – show Coding Style introduced 2018-01-15 18:28 UTC by Report Bug Copy Issue Report This function should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
57			serializer = mock.MagicMock()
58			serializer.validated_data = {'user': test_inactive_user}
59			context = {'serializer': serializer}
60
61			assert test_inactive_user.is_active is False
62			result = pipelines.user_activate.perform(None, context)
63			assert test_inactive_user.is_active is True
64			assert result['user'] == test_inactive_user
65
66
67			def test_valid_signal(test_user):
			0 ignored issues – show Coding Style introduced 2018-01-15 18:28 UTC by Report Bug Copy Issue Report This function should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
68			request = mock.MagicMock()
69			context = {'user': test_user}
70
71			with catch_signal(signals.user_activated) as handler:
72			pipelines.user_activate.signal(request, context)
73
74			handler.assert_called_once_with(
75			sender=mock.ANY,
76			signal=signals.user_activated,
77			user=test_user,
78			request=request
79			)
80
81
82			@pytest.mark.django_db(transaction=False)
83			def test_valid_pipeline(test_inactive_user):
			0 ignored issues – show Coding Style introduced 2018-01-15 18:28 UTC by Report Bug Copy Issue Report This function should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
84			request = mock.MagicMock()
85			request.data = {
86			'uid': utils.encode_uid(test_inactive_user.pk),
87			'token': default_token_generator.make_token(test_inactive_user)
88			}
89
90			pipeline = pipelines.user_activate.Pipeline(request)
91			with catch_signal(signals.user_activated) as handler:
92			result = pipeline.run()
93
94			handler.assert_called_once_with(
95			sender=mock.ANY,
96			signal=signals.user_activated,
97			user=result['user'],
98			request=request
99			)
100
101			assert test_inactive_user.is_active is False
102			test_inactive_user.refresh_from_db()
103			assert test_inactive_user.is_active is True
104

sunscrapers / djoser

Pull Request — master (#259)

test_invalid_serialize_request_wrong_uid() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like