BasePipeline - Code Metrics - Inspection of "[WIP] Version 2.0" - sunscrapers/djoser - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#259)

by Piotr

created 2018-01-16 01:16 UTC

BasePipeline A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	20
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	20
rs	10
wmc	5

2 Methods

Rating	Name	Duplication	Size	Complexity
A	run()	0	12	3
A	__init__()	0	4	2

class BasePipeline(object):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    steps = None

    def __init__(self, request, steps=None):
        self._request = request
        if steps is not None:
            self.steps = steps

    def run(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        assert self.steps is not None, (
            'Pipeline `steps` have not been specified. '
            'They are required to run the pipeline.'
        )

        context = {'request': self._request}
        for step_func in self.steps:
            step_context = step_func(self._request, context) or {}
            context.update(step_context)

        return context


1			class BasePipeline(object):
			0 ignored issues – show Coding Style introduced 2018-01-15 18:28 UTC by Report Bug Copy Issue Report This module should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Coding Style introduced 2018-01-15 18:28 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
2			steps = None
3
4			def __init__(self, request, steps=None):
5			self._request = request
6			if steps is not None:
7			self.steps = steps
8
9			def run(self):
			0 ignored issues – show Coding Style introduced 2018-01-15 18:28 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
10			assert self.steps is not None, (
11			'Pipeline `steps` have not been specified. '
12			'They are required to run the pipeline.'
13			)
14
15			context = {'request': self._request}
16			for step_func in self.steps:
17			step_context = step_func(self._request, context) or {}
18			context.update(step_context)
19
20			return context
21

sunscrapers / djoser

Pull Request — master (#259)

BasePipeline A

Complexity

Size/Duplication

Importance

2 Methods

Duplication Side-by-Side

Filter issues like