BasePipelineViewSet - Code Metrics - Inspection of "[WIP] Version 2.0" - sunscrapers/djoser - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#259)

by Piotr

created 2018-01-22 14:58 UTC

BasePipelineViewSet A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	5
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	5
rs	10
wmc	1

1 Method

Rating	Name	Duplication	Size	Complexity
A	run()	0	2	1

from django.contrib.auth import get_user_model
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
from rest_framework import permissions, status, viewsets

from rest_framework.response import Response


from djoser import pipelines
from djoser.conf import settings

User = get_user_model()



class BasePipelineViewSet(viewsets.ViewSet):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    view_pipeline_adapter = settings.VIEW_PIPELINE_ADAPTER

    def run(self, pipeline, request):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        return BasePipelineViewSet.view_pipeline_adapter(pipeline, request)


class UsersViewSet(BasePipelineViewSet):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    permission_classes = [permissions.AllowAny]

    def create(self, request, *args, **kwargs):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        pipeline = pipelines.user_create.Pipeline
        response_data = self.run(pipeline, request)
        return Response(response_data, status=status.HTTP_201_CREATED)


class UserViewSet(BasePipelineViewSet):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    permission_classes = [permissions.IsAuthenticated]

    def me(self, request, *args, **kwargs):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        pipeline = pipelines.user_detail.Pipeline
        response_data = self.run(pipeline, request)
        return Response(response_data, status=status.HTTP_200_OK)

    def update(self, request, *args, **kwargs):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        pipeline = pipelines.user_update.Pipeline
        response_data = self.run(pipeline, request)
        return Response(response_data, status=status.HTTP_200_OK)

    def remove(self, request, *args, **kwargs):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        pipeline = pipelines.user_delete.Pipeline
        self.run(pipeline, request)
        return Response(status=status.HTTP_204_NO_CONTENT)


class UserActivateViewSet(BasePipelineViewSet):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    permission_classes = [permissions.AllowAny]

    def create(self, request, *args, **kwargs):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        pipeline = pipelines.user_activate.Pipeline
        self.run(pipeline, request)
        return Response(status=status.HTTP_204_NO_CONTENT)


class UsernameUpdateViewSet(BasePipelineViewSet):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    permission_classes = [permissions.IsAuthenticated]

    def create(self, request, *args, **kwargs):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        pipeline = pipelines.username_update.Pipeline
        self.run(pipeline, request)
        return Response(status=status.HTTP_204_NO_CONTENT)


class PasswordUpdateViewSet(BasePipelineViewSet):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    permission_classes = [permissions.IsAuthenticated]

    def create(self, request, *args, **kwargs):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        pipeline = pipelines.password_update.Pipeline
        self.run(pipeline, request)
        return Response(status=status.HTTP_204_NO_CONTENT)


class PasswordResetViewSet(BasePipelineViewSet):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    permission_classes = [permissions.AllowAny]

    def create(self, request, *args, **kwargs):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        pipeline = pipelines.password_reset.Pipeline
        self.run(pipeline, request)
        return Response(status=status.HTTP_204_NO_CONTENT)


class PasswordResetConfirmViewSet(BasePipelineViewSet):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    permission_classes = [permissions.AllowAny]

    def create(self, request, *args, **kwargs):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        pipeline = pipelines.password_reset_confirm.Pipeline
        self.run(pipeline, request)
        return Response(status=status.HTTP_204_NO_CONTENT)


1			from django.contrib.auth import get_user_model
			0 ignored issues – show Coding Style introduced 2017-08-24 11:14 UTC by Report Bug Copy Issue Report This module should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... introduced 2017-08-24 11:14 UTC by Report Bug Copy Issue Report Unable to import 'django.contrib.auth' Loading history...
2			from rest_framework import permissions, status, viewsets
			0 ignored issues – show introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report Unable to import 'rest_framework' Loading history...
3			from rest_framework.response import Response
			0 ignored issues – show introduced 2017-08-24 11:14 UTC by Report Bug Copy Issue Report Unable to import 'rest_framework.response' Loading history...
4
5			from djoser import pipelines
6			from djoser.conf import settings
7
8			User = get_user_model()
			0 ignored issues – show Coding Style Naming introduced 2017-08-24 11:14 UTC by Report Bug Copy Issue Report The name `User` does not conform to the constant naming conventions (`(([A-Z_][A-Z0-9_])\|(__.__))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
9
10
11			class BasePipelineViewSet(viewsets.ViewSet):
			0 ignored issues – show Coding Style introduced 2018-01-22 14:22 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
12			view_pipeline_adapter = settings.VIEW_PIPELINE_ADAPTER
13
14			def run(self, pipeline, request):
			0 ignored issues – show Coding Style introduced 2018-01-22 14:22 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Coding Style introduced 2018-01-22 14:22 UTC by Report Bug Copy Issue Report This method could be written as a function/class method. If a method does not access any attributes of the class, it could also be implemented as a function or static method. This can help improve readability. For example class Foo: def some_method(self, x, y): return x + y; could be written as class Foo: @classmethod def some_method(cls, x, y): return x + y; Loading history...
15			return BasePipelineViewSet.view_pipeline_adapter(pipeline, request)
16
17
18			class UsersViewSet(BasePipelineViewSet):
			0 ignored issues – show Coding Style introduced 2018-01-22 14:22 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
19			permission_classes = [permissions.AllowAny]
20
21			def create(self, request, args, *kwargs):
			0 ignored issues – show Coding Style introduced 2017-10-03 07:19 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2017-10-03 07:19 UTC by Report Bug Copy Issue Report The argument `kwargs` seems to be unused. Loading history... Unused Code introduced 2017-10-03 07:19 UTC by Report Bug Copy Issue Report The argument `args` seems to be unused. Loading history...
22			pipeline = pipelines.user_create.Pipeline
23			response_data = self.run(pipeline, request)
24			return Response(response_data, status=status.HTTP_201_CREATED)
25
26
27			class UserViewSet(BasePipelineViewSet):
			0 ignored issues – show Coding Style introduced 2018-01-22 14:22 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
28			permission_classes = [permissions.IsAuthenticated]
29
30			def me(self, request, args, *kwargs):
			0 ignored issues – show Coding Style Naming introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The name `me` does not conform to the method naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history... Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `kwargs` seems to be unused. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `args` seems to be unused. Loading history...
31			pipeline = pipelines.user_detail.Pipeline
32			response_data = self.run(pipeline, request)
33			return Response(response_data, status=status.HTTP_200_OK)
34
35			def update(self, request, args, *kwargs):
			0 ignored issues – show Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `kwargs` seems to be unused. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `args` seems to be unused. Loading history...
36			pipeline = pipelines.user_update.Pipeline
37			response_data = self.run(pipeline, request)
38			return Response(response_data, status=status.HTTP_200_OK)
39
40			def remove(self, request, args, *kwargs):
			0 ignored issues – show Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `args` seems to be unused. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `kwargs` seems to be unused. Loading history...
41			pipeline = pipelines.user_delete.Pipeline
42			self.run(pipeline, request)
43			return Response(status=status.HTTP_204_NO_CONTENT)
44
45
46			class UserActivateViewSet(BasePipelineViewSet):
			0 ignored issues – show Coding Style introduced 2018-01-22 14:22 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
47			permission_classes = [permissions.AllowAny]
48
49			def create(self, request, args, *kwargs):
			0 ignored issues – show Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `args` seems to be unused. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `kwargs` seems to be unused. Loading history...
50			pipeline = pipelines.user_activate.Pipeline
51			self.run(pipeline, request)
52			return Response(status=status.HTTP_204_NO_CONTENT)
53
54
55			class UsernameUpdateViewSet(BasePipelineViewSet):
			0 ignored issues – show Coding Style introduced 2018-01-22 14:22 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
56			permission_classes = [permissions.IsAuthenticated]
57
58			def create(self, request, args, *kwargs):
			0 ignored issues – show Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `args` seems to be unused. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `kwargs` seems to be unused. Loading history...
59			pipeline = pipelines.username_update.Pipeline
60			self.run(pipeline, request)
61			return Response(status=status.HTTP_204_NO_CONTENT)
62
63
64			class PasswordUpdateViewSet(BasePipelineViewSet):
			0 ignored issues – show Coding Style introduced 2018-01-22 14:22 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
65			permission_classes = [permissions.IsAuthenticated]
66
67			def create(self, request, args, *kwargs):
			0 ignored issues – show Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `args` seems to be unused. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `kwargs` seems to be unused. Loading history...
68			pipeline = pipelines.password_update.Pipeline
69			self.run(pipeline, request)
70			return Response(status=status.HTTP_204_NO_CONTENT)
71
72
73			class PasswordResetViewSet(BasePipelineViewSet):
			0 ignored issues – show Coding Style introduced 2018-01-22 14:22 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
74			permission_classes = [permissions.AllowAny]
75
76			def create(self, request, args, *kwargs):
			0 ignored issues – show Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `args` seems to be unused. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `kwargs` seems to be unused. Loading history...
77			pipeline = pipelines.password_reset.Pipeline
78			self.run(pipeline, request)
79			return Response(status=status.HTTP_204_NO_CONTENT)
80
81
82			class PasswordResetConfirmViewSet(BasePipelineViewSet):
			0 ignored issues – show Coding Style introduced 2018-01-22 14:22 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
83			permission_classes = [permissions.AllowAny]
84
85			def create(self, request, args, *kwargs):
			0 ignored issues – show Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `args` seems to be unused. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `kwargs` seems to be unused. Loading history...
86			pipeline = pipelines.password_reset_confirm.Pipeline
87			self.run(pipeline, request)
88			return Response(status=status.HTTP_204_NO_CONTENT)
89

sunscrapers / djoser

Pull Request — master (#259)

BasePipelineViewSet A

Complexity

Size/Duplication

Importance

1 Method

Duplication Side-by-Side

Filter issues like