TokenCreateView._action() - Code Metrics - Inspection of "[WIP] Version 2.0" - sunscrapers/djoser - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#259)

by Piotr

created 2018-01-22 15:13 UTC

TokenCreateView._action() A

↳ Parent: Project

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	6
rs	9.4285
cc	1

from django.contrib.auth import get_user_model
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
from rest_framework import permissions, status, viewsets

from rest_framework.response import Response


from djoser import pipelines
from djoser.conf import settings

User = get_user_model()



def run_pipeline(pipeline, request):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    return settings.VIEW_PIPELINE_ADAPTER(pipeline, request)


class UsersViewSet(viewsets.ViewSet):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    permission_classes = [permissions.AllowAny]

    def create(self, request, *args, **kwargs):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        pipeline = pipelines.user_create.Pipeline
        response_data = run_pipeline(pipeline, request)
        return Response(response_data, status=status.HTTP_201_CREATED)


class UserViewSet(viewsets.ViewSet):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    permission_classes = [permissions.IsAuthenticated]

    def me(self, request, *args, **kwargs):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        pipeline = pipelines.user_detail.Pipeline
        response_data = run_pipeline(pipeline, request)
        return Response(response_data, status=status.HTTP_200_OK)

    def update(self, request, *args, **kwargs):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        pipeline = pipelines.user_update.Pipeline
        response_data = run_pipeline(pipeline, request)
        return Response(response_data, status=status.HTTP_200_OK)

    def remove(self, request, *args, **kwargs):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        pipeline = pipelines.user_delete.Pipeline
        run_pipeline(pipeline, request)
        return Response(status=status.HTTP_204_NO_CONTENT)


class UserActivateViewSet(viewsets.ViewSet):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    permission_classes = [permissions.AllowAny]

    def create(self, request, *args, **kwargs):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        pipeline = pipelines.user_activate.Pipeline
        run_pipeline(pipeline, request)
        return Response(status=status.HTTP_204_NO_CONTENT)


class UsernameUpdateViewSet(viewsets.ViewSet):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    permission_classes = [permissions.IsAuthenticated]

    def create(self, request, *args, **kwargs):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        pipeline = pipelines.username_update.Pipeline
        run_pipeline(pipeline, request)
        return Response(status=status.HTTP_204_NO_CONTENT)


class PasswordUpdateViewSet(viewsets.ViewSet):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    permission_classes = [permissions.IsAuthenticated]

    def create(self, request, *args, **kwargs):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        pipeline = pipelines.password_update.Pipeline
        run_pipeline(pipeline, request)
        return Response(status=status.HTTP_204_NO_CONTENT)


class PasswordResetViewSet(viewsets.ViewSet):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    permission_classes = [permissions.AllowAny]

    def create(self, request, *args, **kwargs):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        pipeline = pipelines.password_reset.Pipeline
        run_pipeline(pipeline, request)
        return Response(status=status.HTTP_204_NO_CONTENT)


class PasswordResetConfirmViewSet(viewsets.ViewSet):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    permission_classes = [permissions.AllowAny]

    def create(self, request, *args, **kwargs):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        pipeline = pipelines.password_reset_confirm.Pipeline
        run_pipeline(pipeline, request)
        return Response(status=status.HTTP_204_NO_CONTENT)


1			from django.contrib.auth import get_user_model
			0 ignored issues – show Coding Style introduced 2017-08-24 11:14 UTC by Report Bug Copy Issue Report This module should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... introduced 2017-08-24 11:14 UTC by Report Bug Copy Issue Report Unable to import 'django.contrib.auth' Loading history...
2			from rest_framework import permissions, status, viewsets
			0 ignored issues – show introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report Unable to import 'rest_framework' Loading history...
3			from rest_framework.response import Response
			0 ignored issues – show introduced 2017-08-24 11:14 UTC by Report Bug Copy Issue Report Unable to import 'rest_framework.response' Loading history...
4
5			from djoser import pipelines
6			from djoser.conf import settings
7
8			User = get_user_model()
			0 ignored issues – show Coding Style Naming introduced 2018-01-22 15:15 UTC by Report Bug Copy Issue Report The name `User` does not conform to the constant naming conventions (`(([A-Z_][A-Z0-9_])\|(__.__))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
9
10
11			def run_pipeline(pipeline, request):
			0 ignored issues – show Coding Style introduced 2018-01-22 15:15 UTC by Report Bug Copy Issue Report This function should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
12			return settings.VIEW_PIPELINE_ADAPTER(pipeline, request)
13
14
15			class UsersViewSet(viewsets.ViewSet):
			0 ignored issues – show Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
16			permission_classes = [permissions.AllowAny]
17
18			def create(self, request, args, *kwargs):
			0 ignored issues – show Coding Style introduced 2017-10-03 07:19 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2017-10-03 07:19 UTC by Report Bug Copy Issue Report The argument `kwargs` seems to be unused. Loading history... Unused Code introduced 2017-10-03 07:19 UTC by Report Bug Copy Issue Report The argument `args` seems to be unused. Loading history... Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method could be written as a function/class method. If a method does not access any attributes of the class, it could also be implemented as a function or static method. This can help improve readability. For example class Foo: def some_method(self, x, y): return x + y; could be written as class Foo: @classmethod def some_method(cls, x, y): return x + y; Loading history...
19			pipeline = pipelines.user_create.Pipeline
20			response_data = run_pipeline(pipeline, request)
21			return Response(response_data, status=status.HTTP_201_CREATED)
22
23
24			class UserViewSet(viewsets.ViewSet):
			0 ignored issues – show Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
25			permission_classes = [permissions.IsAuthenticated]
26
27			def me(self, request, args, *kwargs):
			0 ignored issues – show Coding Style Naming introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The name `me` does not conform to the method naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history... Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `kwargs` seems to be unused. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `args` seems to be unused. Loading history... Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method could be written as a function/class method. If a method does not access any attributes of the class, it could also be implemented as a function or static method. This can help improve readability. For example class Foo: def some_method(self, x, y): return x + y; could be written as class Foo: @classmethod def some_method(cls, x, y): return x + y; Loading history...
28			pipeline = pipelines.user_detail.Pipeline
29			response_data = run_pipeline(pipeline, request)
30			return Response(response_data, status=status.HTTP_200_OK)
31
32			def update(self, request, args, *kwargs):
			0 ignored issues – show Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `kwargs` seems to be unused. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `args` seems to be unused. Loading history... Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method could be written as a function/class method. If a method does not access any attributes of the class, it could also be implemented as a function or static method. This can help improve readability. For example class Foo: def some_method(self, x, y): return x + y; could be written as class Foo: @classmethod def some_method(cls, x, y): return x + y; Loading history...
33			pipeline = pipelines.user_update.Pipeline
34			response_data = run_pipeline(pipeline, request)
35			return Response(response_data, status=status.HTTP_200_OK)
36
37			def remove(self, request, args, *kwargs):
			0 ignored issues – show Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `args` seems to be unused. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `kwargs` seems to be unused. Loading history... Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method could be written as a function/class method. If a method does not access any attributes of the class, it could also be implemented as a function or static method. This can help improve readability. For example class Foo: def some_method(self, x, y): return x + y; could be written as class Foo: @classmethod def some_method(cls, x, y): return x + y; Loading history...
38			pipeline = pipelines.user_delete.Pipeline
39			run_pipeline(pipeline, request)
40			return Response(status=status.HTTP_204_NO_CONTENT)
41
42
43			class UserActivateViewSet(viewsets.ViewSet):
			0 ignored issues – show Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
44			permission_classes = [permissions.AllowAny]
45
46			def create(self, request, args, *kwargs):
			0 ignored issues – show Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `args` seems to be unused. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `kwargs` seems to be unused. Loading history... Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method could be written as a function/class method. If a method does not access any attributes of the class, it could also be implemented as a function or static method. This can help improve readability. For example class Foo: def some_method(self, x, y): return x + y; could be written as class Foo: @classmethod def some_method(cls, x, y): return x + y; Loading history...
47			pipeline = pipelines.user_activate.Pipeline
48			run_pipeline(pipeline, request)
49			return Response(status=status.HTTP_204_NO_CONTENT)
50
51
52			class UsernameUpdateViewSet(viewsets.ViewSet):
			0 ignored issues – show Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
53			permission_classes = [permissions.IsAuthenticated]
54
55			def create(self, request, args, *kwargs):
			0 ignored issues – show Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `args` seems to be unused. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `kwargs` seems to be unused. Loading history... Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method could be written as a function/class method. If a method does not access any attributes of the class, it could also be implemented as a function or static method. This can help improve readability. For example class Foo: def some_method(self, x, y): return x + y; could be written as class Foo: @classmethod def some_method(cls, x, y): return x + y; Loading history...
56			pipeline = pipelines.username_update.Pipeline
57			run_pipeline(pipeline, request)
58			return Response(status=status.HTTP_204_NO_CONTENT)
59
60
61			class PasswordUpdateViewSet(viewsets.ViewSet):
			0 ignored issues – show Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
62			permission_classes = [permissions.IsAuthenticated]
63
64			def create(self, request, args, *kwargs):
			0 ignored issues – show Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `args` seems to be unused. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `kwargs` seems to be unused. Loading history... Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method could be written as a function/class method. If a method does not access any attributes of the class, it could also be implemented as a function or static method. This can help improve readability. For example class Foo: def some_method(self, x, y): return x + y; could be written as class Foo: @classmethod def some_method(cls, x, y): return x + y; Loading history...
65			pipeline = pipelines.password_update.Pipeline
66			run_pipeline(pipeline, request)
67			return Response(status=status.HTTP_204_NO_CONTENT)
68
69
70			class PasswordResetViewSet(viewsets.ViewSet):
			0 ignored issues – show Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
71			permission_classes = [permissions.AllowAny]
72
73			def create(self, request, args, *kwargs):
			0 ignored issues – show Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `args` seems to be unused. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `kwargs` seems to be unused. Loading history... Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method could be written as a function/class method. If a method does not access any attributes of the class, it could also be implemented as a function or static method. This can help improve readability. For example class Foo: def some_method(self, x, y): return x + y; could be written as class Foo: @classmethod def some_method(cls, x, y): return x + y; Loading history...
74			pipeline = pipelines.password_reset.Pipeline
75			run_pipeline(pipeline, request)
76			return Response(status=status.HTTP_204_NO_CONTENT)
77
78
79			class PasswordResetConfirmViewSet(viewsets.ViewSet):
			0 ignored issues – show Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
80			permission_classes = [permissions.AllowAny]
81
82			def create(self, request, args, *kwargs):
			0 ignored issues – show Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `args` seems to be unused. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `kwargs` seems to be unused. Loading history... Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method could be written as a function/class method. If a method does not access any attributes of the class, it could also be implemented as a function or static method. This can help improve readability. For example class Foo: def some_method(self, x, y): return x + y; could be written as class Foo: @classmethod def some_method(cls, x, y): return x + y; Loading history...
83			pipeline = pipelines.password_reset_confirm.Pipeline
84			run_pipeline(pipeline, request)
85			return Response(status=status.HTTP_204_NO_CONTENT)
86

sunscrapers / djoser

Pull Request — master (#259)

TokenCreateView._action() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like