test_valid_pipeline() - Code Metrics - Inspection of "[WIP] Version 2.0" - sunscrapers/djoser - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#259)

by Piotr

created 2018-01-29 17:38 UTC

test_valid_pipeline() B

↳ Parent: Project

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	14
Bugs	0	Features	0

Metric	Value
cc	5
c	14
b	0
f	0
dl	0
loc	22
rs	8.3411

import pytest
class SomeClass:
    def some_method(self):
        """Do x and return foo."""

from django.contrib.auth import get_user_model

from djoser import pipelines, signals
from djoser.conf import settings
from tests.common import catch_signal, mock

User = get_user_model()



@pytest.mark.django_db(transaction=False)
def test_valid_serialize_request(test_user):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    request = mock.MagicMock()
    request.user = test_user
    request.data = {'email': 'new@localhost'}
    context = {'request': request}
    result = pipelines.user_update.serialize_request(**context)

    assert 'serializer' in result
    assert result['serializer'].validated_data == request.data


@pytest.mark.django_db(transaction=False)
def test_valid_perform(test_user):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    request = mock.MagicMock()
    request.user = test_user
    old_email = test_user.email

    serializer = mock.MagicMock()
    serializer.validated_data = {'email': 'new@localhost'}
    context = {'request': request, 'serializer': serializer}
    result = pipelines.user_update.perform(**context)

    assert 'user' in result
    assert result['user'].username == test_user.username
    assert result['user'].email == serializer.validated_data['email']
    assert result['user'].email != old_email
    assert test_user.email == serializer.validated_data['email']


def test_valid_signal(test_user):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    request = mock.MagicMock()
    context = {'request': request, 'user': test_user}

    with catch_signal(signals.user_updated) as handler:
        pipelines.user_update.signal(**context)

    handler.assert_called_once_with(
        sender=mock.ANY,
        signal=signals.user_updated,
        user=test_user,
        request=request
    )


@pytest.mark.django_db(transaction=False)
def test_valid_serialize_instance(test_user):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    context = {'user': test_user}
    result = pipelines.user_update.serialize_instance(**context)
    username = getattr(test_user, User.USERNAME_FIELD)

    assert 'response_data' in result
    assert result['response_data'] == {
        'id': 1,
        'email': test_user.email,
        User.USERNAME_FIELD: username,
    }


@pytest.mark.django_db(transaction=False)
def test_valid_pipeline(test_user):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    request = mock.MagicMock()
    request.user = test_user
    request.data = {'email': 'new@localhost'}
    username = getattr(test_user, User.USERNAME_FIELD)

    steps = settings.PIPELINES.user_update
    pipeline = pipelines.base.Pipeline(request, steps)
    with catch_signal(signals.user_updated) as handler:
        result = pipeline.run()

    handler.assert_called_once_with(
        sender=mock.ANY,
        signal=signals.user_updated,
        user=result['user'],
        request=request
    )

    assert test_user.email == request.data['email']
    assert 'response_data' in result
    assert result['response_data'] == {
        'id': 1,
        'email': test_user.email,
        User.USERNAME_FIELD: username,
    }


# TODO: test errors, test FK, test m2m



1			import pytest
			0 ignored issues – show Coding Style introduced 2018-01-15 18:28 UTC by Report Bug Copy Issue Report This module should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... introduced 2018-01-15 18:28 UTC by Report Bug Copy Issue Report Unable to import 'pytest' Loading history...
2
3			from django.contrib.auth import get_user_model
4
5			from djoser import pipelines, signals
6			from djoser.conf import settings
7			from tests.common import catch_signal, mock
8
9			User = get_user_model()
			0 ignored issues – show Coding Style Naming introduced 2018-01-15 18:28 UTC by Report Bug Copy Issue Report The name `User` does not conform to the constant naming conventions (`(([A-Z_][A-Z0-9_])\|(__.__))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
10
11
12			@pytest.mark.django_db(transaction=False)
13			def test_valid_serialize_request(test_user):
			0 ignored issues – show Coding Style introduced 2018-01-15 18:28 UTC by Report Bug Copy Issue Report This function should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
14			request = mock.MagicMock()
15			request.user = test_user
16			request.data = {'email': 'new@localhost'}
17			context = {'request': request}
18			result = pipelines.user_update.serialize_request(**context)
19
20			assert 'serializer' in result
21			assert result['serializer'].validated_data == request.data
22
23
24			@pytest.mark.django_db(transaction=False)
25			def test_valid_perform(test_user):
			0 ignored issues – show Coding Style introduced 2018-01-15 18:28 UTC by Report Bug Copy Issue Report This function should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
26			request = mock.MagicMock()
27			request.user = test_user
28			old_email = test_user.email
29
30			serializer = mock.MagicMock()
31			serializer.validated_data = {'email': 'new@localhost'}
32			context = {'request': request, 'serializer': serializer}
33			result = pipelines.user_update.perform(**context)
34
35			assert 'user' in result
36			assert result['user'].username == test_user.username
37			assert result['user'].email == serializer.validated_data['email']
38			assert result['user'].email != old_email
39			assert test_user.email == serializer.validated_data['email']
40
41
42			def test_valid_signal(test_user):
			0 ignored issues – show Coding Style introduced 2018-01-15 18:28 UTC by Report Bug Copy Issue Report This function should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
43			request = mock.MagicMock()
44			context = {'request': request, 'user': test_user}
45
46			with catch_signal(signals.user_updated) as handler:
47			pipelines.user_update.signal(**context)
48
49			handler.assert_called_once_with(
50			sender=mock.ANY,
51			signal=signals.user_updated,
52			user=test_user,
53			request=request
54			)
55
56
57			@pytest.mark.django_db(transaction=False)
58			def test_valid_serialize_instance(test_user):
			0 ignored issues – show Coding Style introduced 2018-01-15 18:28 UTC by Report Bug Copy Issue Report This function should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
59			context = {'user': test_user}
60			result = pipelines.user_update.serialize_instance(**context)
61			username = getattr(test_user, User.USERNAME_FIELD)
62
63			assert 'response_data' in result
64			assert result['response_data'] == {
65			'id': 1,
66			'email': test_user.email,
67			User.USERNAME_FIELD: username,
68			}
69
70
71			@pytest.mark.django_db(transaction=False)
72			def test_valid_pipeline(test_user):
			0 ignored issues – show Coding Style introduced 2018-01-15 18:28 UTC by Report Bug Copy Issue Report This function should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
73			request = mock.MagicMock()
74			request.user = test_user
75			request.data = {'email': 'new@localhost'}
76			username = getattr(test_user, User.USERNAME_FIELD)
77
78			steps = settings.PIPELINES.user_update
79			pipeline = pipelines.base.Pipeline(request, steps)
80			with catch_signal(signals.user_updated) as handler:
81			result = pipeline.run()
82
83			handler.assert_called_once_with(
84			sender=mock.ANY,
85			signal=signals.user_updated,
86			user=result['user'],
87			request=request
88			)
89
90			assert test_user.email == request.data['email']
91			assert 'response_data' in result
92			assert result['response_data'] == {
93			'id': 1,
94			'email': test_user.email,
95			User.USERNAME_FIELD: username,
96			}
97
98
99			# TODO: test errors, test FK, test m2m
			0 ignored issues – show Coding Style introduced 2018-01-15 18:28 UTC by Report Bug Copy Issue Report `TODO` and `FIXME` comments should generally be avoided. Loading history...
100

sunscrapers / djoser

Pull Request — master (#259)

test_valid_pipeline() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like