BasePipeline.run() - Code Metrics - Inspection of "[WIP] Version 2.0" - sunscrapers/djoser - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#259)

by Piotr

created 2018-01-22 14:20 UTC

BasePipeline.run() A

↳ Parent: BasePipeline

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
c	1
b	0
f	0
dl	0
loc	12
rs	9.4285

from rest_framework import serializers
class SomeClass:
    def some_method(self):
        """Do x and return foo."""

from djoser import exceptions


def default_view_pipeline_adapter(pipeline, request):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    try:
        result = pipeline(request).run()
    except exceptions.ValidationError as e:

        raise serializers.ValidationError(e.errors)

    return result.get('response_data')


class BasePipeline(object):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    steps = None

    def __init__(self, request, steps=None):
        self._request = request
        if steps is not None:
            self.steps = steps

    def run(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        assert self.steps is not None, (
            'Pipeline `steps` have not been specified. '
            'They are required to run the pipeline.'
        )

        context = {'request': self._request}
        for step_func in self.steps:
            step_context = step_func(**context) or {}
            context.update(step_context)

        return context


1			from rest_framework import serializers
			0 ignored issues – show Coding Style introduced 2018-01-22 14:22 UTC by Report Bug Copy Issue Report This module should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... introduced 2018-01-22 14:22 UTC by Report Bug Copy Issue Report Unable to import 'rest_framework' Loading history...
2
3			from djoser import exceptions
4
5
6			def default_view_pipeline_adapter(pipeline, request):
			0 ignored issues – show Coding Style introduced 2018-01-22 14:22 UTC by Report Bug Copy Issue Report This function should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
7			try:
8			result = pipeline(request).run()
9			except exceptions.ValidationError as e:
			0 ignored issues – show Coding Style Naming introduced 2018-01-22 14:22 UTC by Report Bug Copy Issue Report The name `e` does not conform to the variable naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
10			raise serializers.ValidationError(e.errors)
11
12			return result.get('response_data')
13
14
15			class BasePipeline(object):
			0 ignored issues – show Coding Style introduced 2018-01-22 14:22 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
16			steps = None
17
18			def __init__(self, request, steps=None):
19			self._request = request
20			if steps is not None:
21			self.steps = steps
22
23			def run(self):
			0 ignored issues – show Coding Style introduced 2018-01-15 18:28 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
24			assert self.steps is not None, (
25			'Pipeline `steps` have not been specified. '
26			'They are required to run the pipeline.'
27			)
28
29			context = {'request': self._request}
30			for step_func in self.steps:
31			step_context = step_func(**context) or {}
32			context.update(step_context)
33
34			return context
35

sunscrapers / djoser

Pull Request — master (#259)

BasePipeline.run() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like