UsernameUpdateViewSet - Code Metrics - Inspection of "[WIP] Version 2.0" - sunscrapers/djoser - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#259)

by Piotr

created 2018-01-31 23:28 UTC

UsernameUpdateViewSet A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	7
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	7
rs	10
wmc	1

1 Method

Rating	Name	Duplication	Size	Complexity
A	create()	0	4	1

from django.contrib.auth import get_user_model
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
from rest_framework import permissions, status, viewsets
from rest_framework.response import Response

from djoser.conf import settings

User = get_user_model()



def run_pipeline(request, steps):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    return settings.VIEW_PIPELINE_ADAPTER(request, steps)


class UsersViewSet(viewsets.ViewSet):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    permission_classes = [permissions.AllowAny]

    def create(self, request, *args, **kwargs):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        steps = settings.PIPELINES['user_create']
        response_data = run_pipeline(request, steps)
        return Response(response_data, status=status.HTTP_201_CREATED)


class UserViewSet(viewsets.ViewSet):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    permission_classes = [permissions.IsAuthenticated]

    def me(self, request, *args, **kwargs):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        steps = settings.PIPELINES['user_detail']
        response_data = run_pipeline(request, steps)
        return Response(response_data, status=status.HTTP_200_OK)

    def update(self, request, *args, **kwargs):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        steps = settings.PIPELINES['user_update']
        response_data = run_pipeline(request, steps)
        return Response(response_data, status=status.HTTP_200_OK)

    def remove(self, request, *args, **kwargs):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        steps = settings.PIPELINES['user_delete']
        run_pipeline(request, steps)
        return Response(status=status.HTTP_204_NO_CONTENT)


class UserActivateViewSet(viewsets.ViewSet):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    permission_classes = [permissions.AllowAny]

    def create(self, request, *args, **kwargs):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        steps = settings.PIPELINES['user_activate']
        run_pipeline(request, steps)
        return Response(status=status.HTTP_204_NO_CONTENT)


class UsernameUpdateViewSet(viewsets.ViewSet):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    permission_classes = [permissions.IsAuthenticated]

    def create(self, request, *args, **kwargs):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        steps = settings.PIPELINES['username_update']
        run_pipeline(request, steps)
        return Response(status=status.HTTP_204_NO_CONTENT)


class PasswordUpdateViewSet(viewsets.ViewSet):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    permission_classes = [permissions.IsAuthenticated]

    def create(self, request, *args, **kwargs):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        steps = settings.PIPELINES['password_update']
        run_pipeline(request, steps)
        return Response(status=status.HTTP_204_NO_CONTENT)


class PasswordResetViewSet(viewsets.ViewSet):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    permission_classes = [permissions.AllowAny]

    def create(self, request, *args, **kwargs):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        steps = settings.PIPELINES['password_reset']
        run_pipeline(request, steps)
        return Response(status=status.HTTP_204_NO_CONTENT)


class PasswordResetConfirmViewSet(viewsets.ViewSet):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    permission_classes = [permissions.AllowAny]

    def create(self, request, *args, **kwargs):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        steps = settings.PIPELINES['password_reset_confirm']
        run_pipeline(request, steps)
        return Response(status=status.HTTP_204_NO_CONTENT)


1			from django.contrib.auth import get_user_model
			0 ignored issues – show Coding Style introduced 2017-08-24 11:14 UTC by Report Bug Copy Issue Report This module should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
2			from rest_framework import permissions, status, viewsets
3			from rest_framework.response import Response
4
5			from djoser.conf import settings
6
7			User = get_user_model()
			0 ignored issues – show Coding Style Naming introduced 2018-01-22 15:15 UTC by Report Bug Copy Issue Report The name `User` does not conform to the constant naming conventions (`(([A-Z_][A-Z0-9_])\|(__.__))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
8
9
10			def run_pipeline(request, steps):
			0 ignored issues – show Coding Style introduced 2018-01-27 17:15 UTC by Report Bug Copy Issue Report This function should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
11			return settings.VIEW_PIPELINE_ADAPTER(request, steps)
12
13
14			class UsersViewSet(viewsets.ViewSet):
			0 ignored issues – show Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
15			permission_classes = [permissions.AllowAny]
16
17			def create(self, request, args, *kwargs):
			0 ignored issues – show Coding Style introduced 2017-10-03 07:19 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2017-10-03 07:19 UTC by Report Bug Copy Issue Report The argument `kwargs` seems to be unused. Loading history... Unused Code introduced 2017-10-03 07:19 UTC by Report Bug Copy Issue Report The argument `args` seems to be unused. Loading history... Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method could be written as a function/class method. If a method does not access any attributes of the class, it could also be implemented as a function or static method. This can help improve readability. For example class Foo: def some_method(self, x, y): return x + y; could be written as class Foo: @classmethod def some_method(cls, x, y): return x + y; Loading history...
18			steps = settings.PIPELINES['user_create']
19			response_data = run_pipeline(request, steps)
20			return Response(response_data, status=status.HTTP_201_CREATED)
21
22
23			class UserViewSet(viewsets.ViewSet):
			0 ignored issues – show Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
24			permission_classes = [permissions.IsAuthenticated]
25
26			def me(self, request, args, *kwargs):
			0 ignored issues – show Coding Style Naming introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The name `me` does not conform to the method naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history... Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `kwargs` seems to be unused. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `args` seems to be unused. Loading history... Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method could be written as a function/class method. If a method does not access any attributes of the class, it could also be implemented as a function or static method. This can help improve readability. For example class Foo: def some_method(self, x, y): return x + y; could be written as class Foo: @classmethod def some_method(cls, x, y): return x + y; Loading history...
27			steps = settings.PIPELINES['user_detail']
28			response_data = run_pipeline(request, steps)
29			return Response(response_data, status=status.HTTP_200_OK)
30
31			def update(self, request, args, *kwargs):
			0 ignored issues – show Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `kwargs` seems to be unused. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `args` seems to be unused. Loading history... Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method could be written as a function/class method. If a method does not access any attributes of the class, it could also be implemented as a function or static method. This can help improve readability. For example class Foo: def some_method(self, x, y): return x + y; could be written as class Foo: @classmethod def some_method(cls, x, y): return x + y; Loading history...
32			steps = settings.PIPELINES['user_update']
33			response_data = run_pipeline(request, steps)
34			return Response(response_data, status=status.HTTP_200_OK)
35
36			def remove(self, request, args, *kwargs):
			0 ignored issues – show Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `args` seems to be unused. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `kwargs` seems to be unused. Loading history... Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method could be written as a function/class method. If a method does not access any attributes of the class, it could also be implemented as a function or static method. This can help improve readability. For example class Foo: def some_method(self, x, y): return x + y; could be written as class Foo: @classmethod def some_method(cls, x, y): return x + y; Loading history...
37			steps = settings.PIPELINES['user_delete']
38			run_pipeline(request, steps)
39			return Response(status=status.HTTP_204_NO_CONTENT)
40
41
42			class UserActivateViewSet(viewsets.ViewSet):
			0 ignored issues – show Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
43			permission_classes = [permissions.AllowAny]
44
45			def create(self, request, args, *kwargs):
			0 ignored issues – show Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `args` seems to be unused. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `kwargs` seems to be unused. Loading history... Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method could be written as a function/class method. If a method does not access any attributes of the class, it could also be implemented as a function or static method. This can help improve readability. For example class Foo: def some_method(self, x, y): return x + y; could be written as class Foo: @classmethod def some_method(cls, x, y): return x + y; Loading history...
46			steps = settings.PIPELINES['user_activate']
47			run_pipeline(request, steps)
48			return Response(status=status.HTTP_204_NO_CONTENT)
49
50
51			class UsernameUpdateViewSet(viewsets.ViewSet):
			0 ignored issues – show Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
52			permission_classes = [permissions.IsAuthenticated]
53
54			def create(self, request, args, *kwargs):
			0 ignored issues – show Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `args` seems to be unused. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `kwargs` seems to be unused. Loading history... Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method could be written as a function/class method. If a method does not access any attributes of the class, it could also be implemented as a function or static method. This can help improve readability. For example class Foo: def some_method(self, x, y): return x + y; could be written as class Foo: @classmethod def some_method(cls, x, y): return x + y; Loading history...
55			steps = settings.PIPELINES['username_update']
56			run_pipeline(request, steps)
57			return Response(status=status.HTTP_204_NO_CONTENT)
58
59
60			class PasswordUpdateViewSet(viewsets.ViewSet):
			0 ignored issues – show Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
61			permission_classes = [permissions.IsAuthenticated]
62
63			def create(self, request, args, *kwargs):
			0 ignored issues – show Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `args` seems to be unused. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `kwargs` seems to be unused. Loading history... Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method could be written as a function/class method. If a method does not access any attributes of the class, it could also be implemented as a function or static method. This can help improve readability. For example class Foo: def some_method(self, x, y): return x + y; could be written as class Foo: @classmethod def some_method(cls, x, y): return x + y; Loading history...
64			steps = settings.PIPELINES['password_update']
65			run_pipeline(request, steps)
66			return Response(status=status.HTTP_204_NO_CONTENT)
67
68
69			class PasswordResetViewSet(viewsets.ViewSet):
			0 ignored issues – show Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
70			permission_classes = [permissions.AllowAny]
71
72			def create(self, request, args, *kwargs):
			0 ignored issues – show Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `args` seems to be unused. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `kwargs` seems to be unused. Loading history... Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method could be written as a function/class method. If a method does not access any attributes of the class, it could also be implemented as a function or static method. This can help improve readability. For example class Foo: def some_method(self, x, y): return x + y; could be written as class Foo: @classmethod def some_method(cls, x, y): return x + y; Loading history...
73			steps = settings.PIPELINES['password_reset']
74			run_pipeline(request, steps)
75			return Response(status=status.HTTP_204_NO_CONTENT)
76
77
78			class PasswordResetConfirmViewSet(viewsets.ViewSet):
			0 ignored issues – show Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
79			permission_classes = [permissions.AllowAny]
80
81			def create(self, request, args, *kwargs):
			0 ignored issues – show Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `args` seems to be unused. Loading history... Unused Code introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report The argument `kwargs` seems to be unused. Loading history... Coding Style introduced 2018-01-22 12:13 UTC by Report Bug Copy Issue Report This method could be written as a function/class method. If a method does not access any attributes of the class, it could also be implemented as a function or static method. This can help improve readability. For example class Foo: def some_method(self, x, y): return x + y; could be written as class Foo: @classmethod def some_method(cls, x, y): return x + y; Loading history...
82			steps = settings.PIPELINES['password_reset_confirm']
83			run_pipeline(request, steps)
84			return Response(status=status.HTTP_204_NO_CONTENT)
85

sunscrapers / djoser

Pull Request — master (#259)

UsernameUpdateViewSet A

Complexity

Size/Duplication

Importance

1 Method

Duplication Side-by-Side

Filter issues like