Pipeline - Code Metrics - Inspection of "[WIP] Version 2.0" - sunscrapers/djoser - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#259)

by Piotr

created 2018-01-31 23:28 UTC

Pipeline A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	12
Duplicated Lines	0 %

Importance

Changes	11
Bugs	0	Features	0

Metric	Value
c	11
b	0
f	0
dl	0
loc	12
rs	10
wmc	3

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__init__()	0	3	1
A	run()	0	7	2

from rest_framework import serializers
class SomeClass:
    def some_method(self):
        """Do x and return foo."""

from djoser import exceptions


def default_view_pipeline_adapter(request, steps):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    try:
        result = Pipeline(request, steps).run()
    except exceptions.ValidationError as e:

        raise serializers.ValidationError(e.errors)

    return result.get('response_data')


class Pipeline(object):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    def __init__(self, request, steps):
        self._request = request
        self._steps = steps

    def run(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        context = {'request': self._request}
        for step_func in self._steps:
            step_context = step_func(**context) or {}
            context.update(step_context)

        return context


1			from rest_framework import serializers
			0 ignored issues – show Coding Style introduced 2018-01-22 14:22 UTC by Report Bug Copy Issue Report This module should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
2
3			from djoser import exceptions
4
5
6			def default_view_pipeline_adapter(request, steps):
			0 ignored issues – show Coding Style introduced 2018-01-27 17:15 UTC by Report Bug Copy Issue Report This function should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
7			try:
8			result = Pipeline(request, steps).run()
9			except exceptions.ValidationError as e:
			0 ignored issues – show Coding Style Naming introduced 2018-01-22 14:22 UTC by Report Bug Copy Issue Report The name `e` does not conform to the variable naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
10			raise serializers.ValidationError(e.errors)
11
12			return result.get('response_data')
13
14
15			class Pipeline(object):
			0 ignored issues – show Coding Style introduced 2018-01-27 17:15 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
16			def __init__(self, request, steps):
17			self._request = request
18			self._steps = steps
19
20			def run(self):
			0 ignored issues – show Coding Style introduced 2018-01-27 17:15 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
21			context = {'request': self._request}
22			for step_func in self._steps:
23			step_context = step_func(**context) or {}
24			context.update(step_context)
25
26			return context
27

sunscrapers / djoser

Pull Request — master (#259)

Pipeline A

Complexity

Size/Duplication

Importance

2 Methods

Duplication Side-by-Side

Filter issues like