ActionViewMixin - Code Metrics - Inspection of "[WIP] Version 2.0" - sunscrapers/djoser - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#259)

by Piotr

created 2018-01-31 23:28 UTC

ActionViewMixin A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	5
Duplicated Lines	0 %

Importance

Changes

Metric	Value
wmc	1
c	0
b	0
f	0
dl	0
loc	5
rs	10

from django.contrib.auth import get_user_model
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
from django.utils.encoding import force_bytes, force_text
from django.utils.http import urlsafe_base64_encode, urlsafe_base64_decode

from djoser import constants

User = get_user_model()



def encode_uid(pk):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    return urlsafe_base64_encode(force_bytes(pk)).decode()


def decode_uid(pk):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    return force_text(urlsafe_base64_decode(pk))


def get_user_email(user):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    user_has_email_field = hasattr(User, 'get_email_field_name')
    assert user_has_email_field, constants.ASSERT_USER_EMAIL_FIELD_EXISTS
    return getattr(user, user.get_email_field_name(), None)


def get_users_for_email(email):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    email_field_name = User.get_email_field_name()
    users = User._default_manager.filter(**{
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent
        email_field_name + '__iexact': email
    })
    return [u for u in users if u.is_active]


1			from django.contrib.auth import get_user_model
			0 ignored issues – show Coding Style introduced 2018-01-16 14:36 UTC by Report Bug Copy Issue Report This module should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
2			from django.utils.encoding import force_bytes, force_text
3			from django.utils.http import urlsafe_base64_encode, urlsafe_base64_decode
4
5			from djoser import constants
6
7			User = get_user_model()
			0 ignored issues – show Coding Style Naming introduced 2018-01-17 17:20 UTC by Report Bug Copy Issue Report The name `User` does not conform to the constant naming conventions (`(([A-Z_][A-Z0-9_])\|(__.__))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
8
9
10			def encode_uid(pk):
			0 ignored issues – show Coding Style Naming introduced 2017-08-24 11:14 UTC by Report Bug Copy Issue Report The name `pk` does not conform to the argument naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history... Coding Style introduced 2017-08-24 11:14 UTC by Report Bug Copy Issue Report This function should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
11			return urlsafe_base64_encode(force_bytes(pk)).decode()
12
13
14			def decode_uid(pk):
			0 ignored issues – show Coding Style Naming introduced 2017-08-24 11:14 UTC by Report Bug Copy Issue Report The name `pk` does not conform to the argument naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history... Coding Style introduced 2017-08-24 11:14 UTC by Report Bug Copy Issue Report This function should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
15			return force_text(urlsafe_base64_decode(pk))
16
17
18			def get_user_email(user):
			0 ignored issues – show Coding Style introduced 2018-01-17 17:20 UTC by Report Bug Copy Issue Report This function should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
19			user_has_email_field = hasattr(User, 'get_email_field_name')
20			assert user_has_email_field, constants.ASSERT_USER_EMAIL_FIELD_EXISTS
21			return getattr(user, user.get_email_field_name(), None)
22
23
24			def get_users_for_email(email):
			0 ignored issues – show Coding Style introduced 2018-01-17 17:20 UTC by Report Bug Copy Issue Report This function should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
25			email_field_name = User.get_email_field_name()
26			users = User._default_manager.filter(**{
			0 ignored issues – show Coding Style Best Practice introduced 2017-08-24 11:14 UTC by Report Bug Copy Issue Report It seems like `_default_manager` was declared protected and should not be accessed from this context. Prefixing a member variable `_` is usually regarded as the equivalent of declaring it with protected visibility that exists in other languages. Consequentially, such a member should only be accessed from the same class or a child class: class MyParent: def __init__(self): self._x = 1; self.y = 2; class MyChild(MyParent): def some_method(self): return self._x # Ok, since accessed from a child class class AnotherClass: def some_method(self, instance_of_my_child): return instance_of_my_child._x # Would be flagged as AnotherClass is not # a child class of MyParent Loading history...
27			email_field_name + '__iexact': email
28			})
29			return [u for u in users if u.is_active]
30

sunscrapers / djoser

Pull Request — master (#259)

ActionViewMixin A

Complexity

Size/Duplication

Importance

Duplication Side-by-Side

Filter issues like